You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2012/05/05 02:03:48 UTC

[jira] [Created] (HDFS-3375) Put client name in DataXceiver thread name for readBlock and keepalive

Todd Lipcon created HDFS-3375:
---------------------------------

             Summary: Put client name in DataXceiver thread name for readBlock and keepalive
                 Key: HDFS-3375
                 URL: https://issues.apache.org/jira/browse/HDFS-3375
             Project: Hadoop HDFS
          Issue Type: Improvement
          Components: data-node
    Affects Versions: 2.0.0
            Reporter: Todd Lipcon
            Assignee: Todd Lipcon
            Priority: Trivial


Currently the datanode thread names include the client for write operations, but not for read. We should include the client name for read ops. Additionally, in the keepalive phase, we should include the client name that initiated the previous request as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3375) Put client name in DataXceiver thread name for readBlock and keepalive

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269983#comment-13269983 ] 

Todd Lipcon commented on HDFS-3375:
-----------------------------------

Since this just changes thread names, no new unit tests. I did verify manually on a cluster with jstack output:


- While uploading a file:

"DataXceiver for client DFSClient_NONMAPREDUCE_-769101204_1 at /127.0.0.1:45087 [Receiving block BP-1115842170-127.0.0.1-1336423035296:blk_1601307317176587197_1002]" daemon prio=10 tid=0x0000000040ff6000 nid=0x6215 runnable [0x00007fe5188c8000]

- While downloading the same file

"DataXceiver for client DFSClient_NONMAPREDUCE_-412315870_1 at /127.0.0.1:51891 [Sending block BP-1115842170-127.0.0.1-1336423035296:blk_1601307317176587197_1002]" daemon prio=10 tid=0x0000000040bb8000 nid=0xa83 runnable [0x00007fe5188c9000]

- During keepalive:
"DataXceiver for client DFSClient_NONMAPREDUCE_-1536450876_1 at /127.0.0.1:51896 [Waiting for operation #111]" daemon prio=10 tid=0x00000000409a3000 nid=0x38f3 runnable [0x00007fe5188c9000]

                
> Put client name in DataXceiver thread name for readBlock and keepalive
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3375
>                 URL: https://issues.apache.org/jira/browse/HDFS-3375
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Trivial
>         Attachments: hdfs-3375.txt
>
>
> Currently the datanode thread names include the client for write operations, but not for read. We should include the client name for read ops. Additionally, in the keepalive phase, we should include the client name that initiated the previous request as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3375) Put client name in DataXceiver thread name for readBlock and keepalive

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HDFS-3375:
------------------------------

    Status: Patch Available  (was: Open)
    
> Put client name in DataXceiver thread name for readBlock and keepalive
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3375
>                 URL: https://issues.apache.org/jira/browse/HDFS-3375
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Trivial
>         Attachments: hdfs-3375.txt
>
>
> Currently the datanode thread names include the client for write operations, but not for read. We should include the client name for read ops. Additionally, in the keepalive phase, we should include the client name that initiated the previous request as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3375) Put client name in DataXceiver thread name for readBlock and keepalive

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270041#comment-13270041 ] 

Hudson commented on HDFS-3375:
------------------------------

Integrated in Hadoop-Common-trunk-Commit #2201 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2201/])
    HDFS-3375. Put client name in DataXceiver thread name for readBlock and keepalive. Contributed by Todd Lipcon. (Revision 1335270)

     Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335270
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java

                
> Put client name in DataXceiver thread name for readBlock and keepalive
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3375
>                 URL: https://issues.apache.org/jira/browse/HDFS-3375
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: hdfs-3375.txt
>
>
> Currently the datanode thread names include the client for write operations, but not for read. We should include the client name for read ops. Additionally, in the keepalive phase, we should include the client name that initiated the previous request as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3375) Put client name in DataXceiver thread name for readBlock and keepalive

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270440#comment-13270440 ] 

Hudson commented on HDFS-3375:
------------------------------

Integrated in Hadoop-Hdfs-trunk #1038 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1038/])
    HDFS-3375. Put client name in DataXceiver thread name for readBlock and keepalive. Contributed by Todd Lipcon. (Revision 1335270)

     Result = FAILURE
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335270
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java

                
> Put client name in DataXceiver thread name for readBlock and keepalive
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3375
>                 URL: https://issues.apache.org/jira/browse/HDFS-3375
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: hdfs-3375.txt
>
>
> Currently the datanode thread names include the client for write operations, but not for read. We should include the client name for read ops. Additionally, in the keepalive phase, we should include the client name that initiated the previous request as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3375) Put client name in DataXceiver thread name for readBlock and keepalive

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270474#comment-13270474 ] 

Hudson commented on HDFS-3375:
------------------------------

Integrated in Hadoop-Mapreduce-trunk #1073 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1073/])
    HDFS-3375. Put client name in DataXceiver thread name for readBlock and keepalive. Contributed by Todd Lipcon. (Revision 1335270)

     Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335270
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java

                
> Put client name in DataXceiver thread name for readBlock and keepalive
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3375
>                 URL: https://issues.apache.org/jira/browse/HDFS-3375
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: hdfs-3375.txt
>
>
> Currently the datanode thread names include the client for write operations, but not for read. We should include the client name for read ops. Additionally, in the keepalive phase, we should include the client name that initiated the previous request as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3375) Put client name in DataXceiver thread name for readBlock and keepalive

Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269332#comment-13269332 ] 

Aaron T. Myers commented on HDFS-3375:
--------------------------------------

+1, the patch looks good to me.
                
> Put client name in DataXceiver thread name for readBlock and keepalive
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3375
>                 URL: https://issues.apache.org/jira/browse/HDFS-3375
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Trivial
>         Attachments: hdfs-3375.txt
>
>
> Currently the datanode thread names include the client for write operations, but not for read. We should include the client name for read ops. Additionally, in the keepalive phase, we should include the client name that initiated the previous request as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3375) Put client name in DataXceiver thread name for readBlock and keepalive

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268848#comment-13268848 ] 

Hadoop QA commented on HDFS-3375:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12525704/hdfs-3375.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated 2 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2381//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2381//console

This message is automatically generated.
                
> Put client name in DataXceiver thread name for readBlock and keepalive
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3375
>                 URL: https://issues.apache.org/jira/browse/HDFS-3375
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Trivial
>         Attachments: hdfs-3375.txt
>
>
> Currently the datanode thread names include the client for write operations, but not for read. We should include the client name for read ops. Additionally, in the keepalive phase, we should include the client name that initiated the previous request as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3375) Put client name in DataXceiver thread name for readBlock and keepalive

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HDFS-3375:
------------------------------

    Attachment: hdfs-3375.txt
    
> Put client name in DataXceiver thread name for readBlock and keepalive
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3375
>                 URL: https://issues.apache.org/jira/browse/HDFS-3375
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Trivial
>         Attachments: hdfs-3375.txt
>
>
> Currently the datanode thread names include the client for write operations, but not for read. We should include the client name for read ops. Additionally, in the keepalive phase, we should include the client name that initiated the previous request as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3375) Put client name in DataXceiver thread name for readBlock and keepalive

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270039#comment-13270039 ] 

Hudson commented on HDFS-3375:
------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2276 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2276/])
    HDFS-3375. Put client name in DataXceiver thread name for readBlock and keepalive. Contributed by Todd Lipcon. (Revision 1335270)

     Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335270
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java

                
> Put client name in DataXceiver thread name for readBlock and keepalive
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3375
>                 URL: https://issues.apache.org/jira/browse/HDFS-3375
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: hdfs-3375.txt
>
>
> Currently the datanode thread names include the client for write operations, but not for read. We should include the client name for read ops. Additionally, in the keepalive phase, we should include the client name that initiated the previous request as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3375) Put client name in DataXceiver thread name for readBlock and keepalive

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270067#comment-13270067 ] 

Hudson commented on HDFS-3375:
------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2218 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2218/])
    HDFS-3375. Put client name in DataXceiver thread name for readBlock and keepalive. Contributed by Todd Lipcon. (Revision 1335270)

     Result = ABORTED
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335270
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java

                
> Put client name in DataXceiver thread name for readBlock and keepalive
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3375
>                 URL: https://issues.apache.org/jira/browse/HDFS-3375
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: hdfs-3375.txt
>
>
> Currently the datanode thread names include the client for write operations, but not for read. We should include the client name for read ops. Additionally, in the keepalive phase, we should include the client name that initiated the previous request as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3375) Put client name in DataXceiver thread name for readBlock and keepalive

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HDFS-3375:
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

Committed to 2.0 and trunk. Thanks for reviewing, Aaron.
                
> Put client name in DataXceiver thread name for readBlock and keepalive
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3375
>                 URL: https://issues.apache.org/jira/browse/HDFS-3375
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: hdfs-3375.txt
>
>
> Currently the datanode thread names include the client for write operations, but not for read. We should include the client name for read ops. Additionally, in the keepalive phase, we should include the client name that initiated the previous request as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira