You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by "Aaron Anderson (JIRA)" <ji...@apache.org> on 2010/11/10 00:34:23 UTC

[jira] Created: (OWB-489) AnnotatedTypes added with BeforeBeanDiscovery.addAnnotatedType method are ignored

AnnotatedTypes added with BeforeBeanDiscovery.addAnnotatedType method are ignored
---------------------------------------------------------------------------------

                 Key: OWB-489
                 URL: https://issues.apache.org/jira/browse/OWB-489
             Project: OpenWebBeans
          Issue Type: Bug
          Components: Events
    Affects Versions: 1.0.0
         Environment: SE Standalone 
            Reporter: Aaron Anderson
            Assignee: Gurkan Erdogdu
            Priority: Minor


In section 11.5.1. of JSR 299 it states:

addAnnotatedType() adds a given AnnotatedType to the set of types which will be scanned during bean discovery.

However the addAdditionalAnnotatedType method of the BeanManagerImpl (https://svn.apache.org/repos/asf/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java) simply adds the types to a private list and the values are never acted upon. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (OWB-489) AnnotatedTypes added with BeforeBeanDiscovery.addAnnotatedType method are ignored

Posted by "Joe Bergmark (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OWB-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joe Bergmark reassigned OWB-489:
--------------------------------

    Assignee: Joe Bergmark  (was: Gurkan Erdogdu)

I took a look at this, and think it is pretty straight forward.

I believe we just need a way to expose those AnnotatedTypes from the BeanManagerImpl into BeansDeployer.

BeansDeployer would then add a new method (maybe deployAnnotatedTypes), that it would call during the deploy(ScannerService) method, probably right after deployFromClassPath.  As we are dealing with a list of AnnotatedTypes, the logic from deployFromClasspath can be probably simplified and re-used.

I'll start working on this, and if anyone has a concern or thinks I've chosen the wrong approach please let me know.

> AnnotatedTypes added with BeforeBeanDiscovery.addAnnotatedType method are ignored
> ---------------------------------------------------------------------------------
>
>                 Key: OWB-489
>                 URL: https://issues.apache.org/jira/browse/OWB-489
>             Project: OpenWebBeans
>          Issue Type: Bug
>          Components: Events
>    Affects Versions: 1.0.0
>         Environment: SE Standalone 
>            Reporter: Aaron Anderson
>            Assignee: Joe Bergmark
>            Priority: Minor
>
> In section 11.5.1. of JSR 299 it states:
> addAnnotatedType() adds a given AnnotatedType to the set of types which will be scanned during bean discovery.
> However the addAdditionalAnnotatedType method of the BeanManagerImpl (https://svn.apache.org/repos/asf/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java) simply adds the types to a private list and the values are never acted upon. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (OWB-489) AnnotatedTypes added with BeforeBeanDiscovery.addAnnotatedType method are ignored

Posted by "Joe Bergmark (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OWB-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joe Bergmark resolved OWB-489.
------------------------------

       Resolution: Fixed
    Fix Version/s: 1.0.1
                   1.1.0

Added support for this in both trunk and the 1.0.x branch.  Also added a very simple test case.

> AnnotatedTypes added with BeforeBeanDiscovery.addAnnotatedType method are ignored
> ---------------------------------------------------------------------------------
>
>                 Key: OWB-489
>                 URL: https://issues.apache.org/jira/browse/OWB-489
>             Project: OpenWebBeans
>          Issue Type: Bug
>          Components: Events
>    Affects Versions: 1.0.0
>         Environment: SE Standalone 
>            Reporter: Aaron Anderson
>            Assignee: Joe Bergmark
>            Priority: Minor
>             Fix For: 1.1.0, 1.0.1
>
>
> In section 11.5.1. of JSR 299 it states:
> addAnnotatedType() adds a given AnnotatedType to the set of types which will be scanned during bean discovery.
> However the addAdditionalAnnotatedType method of the BeanManagerImpl (https://svn.apache.org/repos/asf/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java) simply adds the types to a private list and the values are never acted upon. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.