You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Alexander Kolbasov <ak...@gmail.com> on 2017/11/07 21:58:50 UTC
Review Request 63647: SENTRY-2036: sentry_sync_notifications() should
set ID when it returns errors
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63647/
-----------------------------------------------------------
Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
Bugs: SENTRY-2036
https://issues.apache.org/jira/browse/SENTRY-2036
Repository: sentry
Description
-------
SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 71eb9c1b6d02326fc9a7b702652253bd9b57d725
Diff: https://reviews.apache.org/r/63647/diff/1/
Testing
-------
Thanks,
Alexander Kolbasov
Re: Review Request 63647: SENTRY-2036: sentry_sync_notifications()
should set ID when it returns errors
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63647/#review190617
-----------------------------------------------------------
Ship it!
Ship It!
- kalyan kumar kalvagadda
On Nov. 7, 2017, 9:58 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63647/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2017, 9:58 p.m.)
>
>
> Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
>
>
> Bugs: SENTRY-2036
> https://issues.apache.org/jira/browse/SENTRY-2036
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 71eb9c1b6d02326fc9a7b702652253bd9b57d725
>
>
> Diff: https://reviews.apache.org/r/63647/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 63647: SENTRY-2036: sentry_sync_notifications()
should set ID when it returns errors
Posted by Alexander Kolbasov <ak...@gmail.com>.
> On Nov. 9, 2017, 2:56 p.m., kalyan kumar kalvagadda wrote:
> > What is the issue we are observing when this id is not set?
When timeout exception occurs, id is not set. This is a mandatory field, so Thrift creates its own exception which replaces the original timeout exception. As a result, client gets the wrong exception information back.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63647/#review190589
-----------------------------------------------------------
On Nov. 7, 2017, 9:58 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63647/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2017, 9:58 p.m.)
>
>
> Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
>
>
> Bugs: SENTRY-2036
> https://issues.apache.org/jira/browse/SENTRY-2036
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 71eb9c1b6d02326fc9a7b702652253bd9b57d725
>
>
> Diff: https://reviews.apache.org/r/63647/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 63647: SENTRY-2036: sentry_sync_notifications()
should set ID when it returns errors
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63647/#review190589
-----------------------------------------------------------
What is the issue we are observing when this id is not set?
- kalyan kumar kalvagadda
On Nov. 7, 2017, 9:58 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63647/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2017, 9:58 p.m.)
>
>
> Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
>
>
> Bugs: SENTRY-2036
> https://issues.apache.org/jira/browse/SENTRY-2036
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 71eb9c1b6d02326fc9a7b702652253bd9b57d725
>
>
> Diff: https://reviews.apache.org/r/63647/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 63647: SENTRY-2036: sentry_sync_notifications()
should set ID when it returns errors
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63647/#review190472
-----------------------------------------------------------
Ship it!
Ship It!
- Sergio Pena
On Nov. 7, 2017, 9:58 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63647/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2017, 9:58 p.m.)
>
>
> Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
>
>
> Bugs: SENTRY-2036
> https://issues.apache.org/jira/browse/SENTRY-2036
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 71eb9c1b6d02326fc9a7b702652253bd9b57d725
>
>
> Diff: https://reviews.apache.org/r/63647/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 63647: SENTRY-2036: sentry_sync_notifications()
should set ID when it returns errors
Posted by Alexander Kolbasov <ak...@gmail.com>.
> On Nov. 9, 2017, 5:27 p.m., Na Li wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java
> > Lines 1164 (patched)
> > <https://reviews.apache.org/r/63647/diff/1/?file=1884192#file1884192line1164>
> >
> > Can we set the ID to be request.getId() instead of 0? So the value and the error message is consistent. Same thing for line 1170
I am not sure this would be correct since this ID wasn't processed yet. To some extend it doesn't matter because ID shouldn't be used by clients in case of errors.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63647/#review190613
-----------------------------------------------------------
On Nov. 7, 2017, 9:58 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63647/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2017, 9:58 p.m.)
>
>
> Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
>
>
> Bugs: SENTRY-2036
> https://issues.apache.org/jira/browse/SENTRY-2036
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 71eb9c1b6d02326fc9a7b702652253bd9b57d725
>
>
> Diff: https://reviews.apache.org/r/63647/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 63647: SENTRY-2036: sentry_sync_notifications()
should set ID when it returns errors
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63647/#review190613
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java
Lines 1164 (patched)
<https://reviews.apache.org/r/63647/#comment268116>
Can we set the ID to be request.getId() instead of 0? So the value and the error message is consistent. Same thing for line 1170
- Na Li
On Nov. 7, 2017, 9:58 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63647/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2017, 9:58 p.m.)
>
>
> Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
>
>
> Bugs: SENTRY-2036
> https://issues.apache.org/jira/browse/SENTRY-2036
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 71eb9c1b6d02326fc9a7b702652253bd9b57d725
>
>
> Diff: https://reviews.apache.org/r/63647/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>