[jira] [Commented] (CASSANDRA-13321) Add a checksum component for the sstable metadata (-Statistics.db) file

["Marcus Eriksson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-13321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956443#comment-15956443 ] 

Marcus Eriksson commented on CASSANDRA-13321:
---------------------------------------------

I made an alternative implementation of this: https://github.com/krummas/cassandra/commits/marcuse/appendedchecksum which just appends the checksum within the same file, much simpler but does not solve all the issues that the versioned component patch above solves, but feels much safer. We still need to rename the file on top of the old file using this patch, so not sure if the risk of the old patch is worth it, wdyt [~jasobrown]?

> Add a checksum component for the sstable metadata (-Statistics.db) file
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-13321
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13321
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>             Fix For: 4.x
>
>
> Since we keep important information in the sstable metadata file now, we should add a checksum component for it. One danger being if a bit gets flipped in repairedAt we could consider the sstable repaired when it is not.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)