You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Eriks Dobelis (JIRA)" <ji...@apache.org> on 2006/08/18 01:06:15 UTC
[jira] Commented: (OFBIZ-164) rateProductTaxCalcForDisplay returns
incorrect priceWithTax
[ http://issues.apache.org/jira/browse/OFBIZ-164?page=comments#action_12428823 ]
Eriks Dobelis commented on OFBIZ-164:
-------------------------------------
This is better as it performs necessary rounding.
Index: applications/accounting/src/org/ofbiz/accounting/tax/TaxAuthorityServices.java
===================================================================
--- applications/accounting/src/org/ofbiz/accounting/tax/TaxAuthorityServices.java (revision 431541)
+++ applications/accounting/src/org/ofbiz/accounting/tax/TaxAuthorityServices.java (working copy)
@@ -108,7 +108,7 @@
taxPercentage = taxPercentage.add(taxAdjustment.getBigDecimal("sourcePercentage"));
BigDecimal adjAmount = taxAdjustment.getBigDecimal("amount");
taxTotal = taxTotal.add(adjAmount);
- priceWithTax = priceWithTax.add(adjAmount);
+ priceWithTax = priceWithTax.add(adjAmount.divide(quantity,3,BigDecimal.ROUND_CEILING));
Debug.logInfo("For productId [" + productId + "] added [" + adjAmount + "] of tax to price for geoId [" + taxAdjustment.getString("taxAuthGeoId") + "], new price is [" + priceWithTax + "]", module);
}
}
> rateProductTaxCalcForDisplay returns incorrect priceWithTax
> -----------------------------------------------------------
>
> Key: OFBIZ-164
> URL: http://issues.apache.org/jira/browse/OFBIZ-164
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: accounting
> Reporter: Eriks Dobelis
>
> priceWithTax from rateProductTaxCalcForDisplay is returned incorrectly as the total tax. This is a simple diff that solves it.
> Index: applications/accounting/src/org/ofbiz/accounting/tax/TaxAuthorityServices.java
> ===================================================================
> --- applications/accounting/src/org/ofbiz/accounting/tax/TaxAuthorityServices.java (revision 431541)
> +++ applications/accounting/src/org/ofbiz/accounting/tax/TaxAuthorityServices.java (working copy)
> @@ -108,7 +108,7 @@
> taxPercentage = taxPercentage.add(taxAdjustment.getBigDecimal("sourcePercentage"));
> BigDecimal adjAmount = taxAdjustment.getBigDecimal("amount");
> taxTotal = taxTotal.add(adjAmount);
> - priceWithTax = priceWithTax.add(adjAmount);
> + priceWithTax = priceWithTax.add(adjAmount.divide(quantity));
> Debug.logInfo("For productId [" + productId + "] added [" + adjAmount + "] of tax to price for geoId [" + taxAdjustment.getString("taxAuthGeoId") + "], new price is [" + priceWithTax + "]", module);
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira