You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by su...@apache.org on 2023/05/14 15:46:01 UTC
[shardingsphere] branch master updated: Fix sonar issue of MethodTimeRecorder (#25665)
This is an automated email from the ASF dual-hosted git repository.
sunnianjun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new b28cbed93d8 Fix sonar issue of MethodTimeRecorder (#25665)
b28cbed93d8 is described below
commit b28cbed93d8a3b58f30eea633d1811fa086adc6c
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Sun May 14 23:45:54 2023 +0800
Fix sonar issue of MethodTimeRecorder (#25665)
---
.../shardingsphere/agent/plugin/core/recorder/MethodTimeRecorder.java | 2 +-
.../agent/plugin/core/recorder/MethodTimeRecorderTest.java | 2 +-
.../agent/plugin/logging/file/advice/MetaDataContextsFactoryAdvice.java | 2 +-
.../metrics/core/advice/jdbc/AbstractExecuteLatencyHistogramAdvice.java | 2 +-
.../plugin/metrics/core/advice/proxy/ExecuteLatencyHistogramAdvice.java | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/agent/plugins/core/src/main/java/org/apache/shardingsphere/agent/plugin/core/recorder/MethodTimeRecorder.java b/agent/plugins/core/src/main/java/org/apache/shardingsphere/agent/plugin/core/recorder/MethodTimeRecorder.java
index a89d750c775..b3d0fda3358 100644
--- a/agent/plugins/core/src/main/java/org/apache/shardingsphere/agent/plugin/core/recorder/MethodTimeRecorder.java
+++ b/agent/plugins/core/src/main/java/org/apache/shardingsphere/agent/plugin/core/recorder/MethodTimeRecorder.java
@@ -39,7 +39,7 @@ public final class MethodTimeRecorder {
*
* @param method method to be recorded
*/
- public void record(final Method method) {
+ public void recordNow(final Method method) {
CURRENT_RECORDER.get().put(getKey(method), System.currentTimeMillis());
}
diff --git a/agent/plugins/core/src/test/java/org/apache/shardingsphere/agent/plugin/core/recorder/MethodTimeRecorderTest.java b/agent/plugins/core/src/test/java/org/apache/shardingsphere/agent/plugin/core/recorder/MethodTimeRecorderTest.java
index eb4e63b4ca2..e841880acad 100644
--- a/agent/plugins/core/src/test/java/org/apache/shardingsphere/agent/plugin/core/recorder/MethodTimeRecorderTest.java
+++ b/agent/plugins/core/src/test/java/org/apache/shardingsphere/agent/plugin/core/recorder/MethodTimeRecorderTest.java
@@ -29,7 +29,7 @@ class MethodTimeRecorderTest {
@Test
void assertGetElapsedTimeAndCleanWithRecorded() throws InterruptedException, NoSuchMethodException {
MethodTimeRecorder methodTimeRecorder = new MethodTimeRecorder(AgentAdvice.class);
- methodTimeRecorder.record(Object.class.getDeclaredMethod("toString"));
+ methodTimeRecorder.recordNow(Object.class.getDeclaredMethod("toString"));
Thread.sleep(5L);
assertThat(methodTimeRecorder.getElapsedTimeAndClean(Object.class.getDeclaredMethod("toString")), greaterThanOrEqualTo(5L));
}
diff --git a/agent/plugins/logging/type/file/src/main/java/org/apache/shardingsphere/agent/plugin/logging/file/advice/MetaDataContextsFactoryAdvice.java b/agent/plugins/logging/type/file/src/main/java/org/apache/shardingsphere/agent/plugin/logging/file/advice/MetaDataContextsFactoryAdvice.java
index c0ef497ec14..9751a95c9f9 100644
--- a/agent/plugins/logging/type/file/src/main/java/org/apache/shardingsphere/agent/plugin/logging/file/advice/MetaDataContextsFactoryAdvice.java
+++ b/agent/plugins/logging/type/file/src/main/java/org/apache/shardingsphere/agent/plugin/logging/file/advice/MetaDataContextsFactoryAdvice.java
@@ -33,7 +33,7 @@ public final class MetaDataContextsFactoryAdvice implements StaticMethodAdvice {
@Override
public void beforeMethod(final Class<?> clazz, final Method method, final Object[] args, final String pluginType) {
- methodTimeRecorder.record(method);
+ methodTimeRecorder.recordNow(method);
}
@Override
diff --git a/agent/plugins/metrics/core/src/main/java/org/apache/shardingsphere/agent/plugin/metrics/core/advice/jdbc/AbstractExecuteLatencyHistogramAdvice.java b/agent/plugins/metrics/core/src/main/java/org/apache/shardingsphere/agent/plugin/metrics/core/advice/jdbc/AbstractExecuteLatencyHistogramAdvice.java
index 23cf2da75d8..a0df6b72817 100644
--- a/agent/plugins/metrics/core/src/main/java/org/apache/shardingsphere/agent/plugin/metrics/core/advice/jdbc/AbstractExecuteLatencyHistogramAdvice.java
+++ b/agent/plugins/metrics/core/src/main/java/org/apache/shardingsphere/agent/plugin/metrics/core/advice/jdbc/AbstractExecuteLatencyHistogramAdvice.java
@@ -49,7 +49,7 @@ public abstract class AbstractExecuteLatencyHistogramAdvice implements InstanceM
@Override
public void beforeMethod(final TargetAdviceObject target, final Method method, final Object[] args, final String pluginType) {
- getMethodTimeRecorder().record(method);
+ getMethodTimeRecorder().recordNow(method);
}
@Override
diff --git a/agent/plugins/metrics/core/src/main/java/org/apache/shardingsphere/agent/plugin/metrics/core/advice/proxy/ExecuteLatencyHistogramAdvice.java b/agent/plugins/metrics/core/src/main/java/org/apache/shardingsphere/agent/plugin/metrics/core/advice/proxy/ExecuteLatencyHistogramAdvice.java
index 51dd5a4e491..8e0631bc769 100644
--- a/agent/plugins/metrics/core/src/main/java/org/apache/shardingsphere/agent/plugin/metrics/core/advice/proxy/ExecuteLatencyHistogramAdvice.java
+++ b/agent/plugins/metrics/core/src/main/java/org/apache/shardingsphere/agent/plugin/metrics/core/advice/proxy/ExecuteLatencyHistogramAdvice.java
@@ -51,7 +51,7 @@ public final class ExecuteLatencyHistogramAdvice implements InstanceMethodAdvice
@Override
public void beforeMethod(final TargetAdviceObject target, final Method method, final Object[] args, final String pluginType) {
- methodTimeRecorder.record(method);
+ methodTimeRecorder.recordNow(method);
}
@Override