[GitHub] pengzhao-intel commented on a change in pull request #13749: Add NHWC layout support to Pooling (cpu, gpu cuda, gpu cuDNN)

[GitBox <gi...@apache.org>]

pengzhao-intel commented on a change in pull request #13749: Add NHWC layout support to Pooling (cpu, gpu cuda, gpu cuDNN)
URL: https://github.com/apache/incubator-mxnet/pull/13749#discussion_r255372521
 
 

 ##########
 File path: src/operator/nn/pooling.cc
 ##########
 @@ -421,11 +463,16 @@ NNVM_REGISTER_OP(_backward_Pooling)
 .set_attr<nnvm::FInplaceOption>(
     "FInplaceOption",
     [](const NodeAttrs &attrs) {
-#if MXNET_USE_CUDNN == 1
-  return std::vector<std::pair<int, int> >();
-#else
-  return std::vector<std::pair<int, int> >{{1, 0}};
+#if MXNET_USE_MKLDNN == 1 && MXNET_USE_CUDA == 0 && MXNET_USE_CUDNN == 0
 
 Review comment:
   Thanks for the explanation. I understand the current limitation in here. 
   My concern is the performance regression in the CPU side when _mxnet-cuXXmkl_ binary is used which actually is the widely used binary like sockeye, gluonNLP, gluonCV, etc. 
   Before we resolved issue #13598 (btw, we're working on this now）, I think we need to keep this line **AS-IS**.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services