[GitHub] [incubator-seatunnel] hailin0 commented on pull request #4660: [Feature][Zeta] Improve local mode startup request ports

["hailin0 (via GitHub)" <gi...@apache.org>]

hailin0 commented on PR #4660:
URL: https://github.com/apache/incubator-seatunnel/pull/4660#issuecomment-1536983200

   > @EricJoy2048 @hailin0 . now this [config](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-assert-e2e/src/test/resources/assertion/fakesource_to_assert.conf) has error. the assert sink has a min value check but the fake source doesn't has the min value config.
   > 
   > For Now, this pr has 3 commit:
   > 
   > 1. for issue [[Feature][Zeta] Improve local mode startup request ports  #4607](https://github.com/apache/incubator-seatunnel/issues/4607) , improve local mode startup request ports
   > 2. fix zeta engine recover job get NPE. (but it's not the finially solution, just added parameter check, need find where past the NULL to this method)
   > 3. fix Assert e2e config error
   
   3. suggestion remove MIN check from assert sink


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org