[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2746: HDDS-5864. Retry when DN connection issue during getBlock/ReadChunk call during Ozone key Read

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #2746:
URL: https://github.com/apache/ozone/pull/2746#discussion_r733911587



##########
File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockInputStream.java
##########
@@ -320,6 +345,17 @@ synchronized int readWithStrategy(ByteReaderStrategy strategy) throws
         } else {
           throw e;
         }
+      } catch(SCMSecurityException ex) {
+        throw ex;
+      } catch(IOException ex) {
+        // We got a IOException which might be due
+        // to DN down or connectivity issue.
+        if (shouldRetryRead(ex)) {
+          current.releaseClient();

Review comment:
       Because we should not refresh pipeline, when IOException we want to retry on the same pipeline. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org