You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Lav Jain <lj...@pivotal.io> on 2015/12/31 19:45:31 UTC
Review Request 41832: Run hawq init standby on standby node instead
of master
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41832/
-----------------------------------------------------------
Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, Jaimin Jetly, jun aoki, Matt, Newton Alex, and Oleksandr Diachenko.
Bugs: AMBARI-14527
https://issues.apache.org/jira/browse/AMBARI-14527
Repository: ambari
Description
-------
Driven by HAWQ change https://issues.apache.org/jira/browse/HAWQ-40
Diffs
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py cf7dc77
Diff: https://reviews.apache.org/r/41832/diff/
Testing
-------
Manually tested by adding HAWQ (using add service).
Thanks,
Lav Jain
Re: Review Request 41832: Run hawq init standby on standby node
instead of master
Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41832/#review112399
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py (line 74)
<https://reviews.apache.org/r/41832/#comment172890>
This is pretty much not relevant to the user, so you may remove the logger.info for configuring.
As for a new user configuring vs initializing will be almost ambigous.
- bhuvnesh chaudhary
On Dec. 31, 2015, 6:45 p.m., Lav Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41832/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2015, 6:45 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, Jaimin Jetly, jun aoki, Matt, Newton Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-14527
> https://issues.apache.org/jira/browse/AMBARI-14527
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Driven by HAWQ change https://issues.apache.org/jira/browse/HAWQ-40
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py cf7dc77
>
> Diff: https://reviews.apache.org/r/41832/diff/
>
>
> Testing
> -------
>
> Manually tested by adding HAWQ (using add service).
>
>
> Thanks,
>
> Lav Jain
>
>
Re: Review Request 41832: Run hawq init standby on standby node
instead of master
Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41832/#review112402
-----------------------------------------------------------
Ship it!
- bhuvnesh chaudhary
On Dec. 31, 2015, 7:48 p.m., Lav Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41832/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2015, 7:48 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, Jaimin Jetly, jun aoki, Matt, Newton Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-14527
> https://issues.apache.org/jira/browse/AMBARI-14527
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Driven by HAWQ change https://issues.apache.org/jira/browse/HAWQ-40
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py cf7dc77
>
> Diff: https://reviews.apache.org/r/41832/diff/
>
>
> Testing
> -------
>
> Manually tested by adding HAWQ (using add service).
>
>
> Thanks,
>
> Lav Jain
>
>
Re: Review Request 41832: Run hawq init standby on standby node
instead of master
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41832/#review112722
-----------------------------------------------------------
Ship it!
Ship It!
- Matt
On Jan. 4, 2016, 4:55 p.m., Lav Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41832/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 4:55 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, Jaimin Jetly, jun aoki, Matt, Newton Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-14527
> https://issues.apache.org/jira/browse/AMBARI-14527
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Driven by HAWQ change https://issues.apache.org/jira/browse/HAWQ-40
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py e15b64d
>
> Diff: https://reviews.apache.org/r/41832/diff/
>
>
> Testing
> -------
>
> Manually tested by adding HAWQ (using add service).
>
>
> Thanks,
>
> Lav Jain
>
>
Re: Review Request 41832: Run hawq init standby on standby node
instead of master
Posted by Lav Jain <lj...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41832/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 12:55 a.m.)
Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, Jaimin Jetly, jun aoki, Matt, Newton Alex, and Oleksandr Diachenko.
Changes
-------
Resolve merge conflicts with updated trunk.
Bugs: AMBARI-14527
https://issues.apache.org/jira/browse/AMBARI-14527
Repository: ambari
Description
-------
Driven by HAWQ change https://issues.apache.org/jira/browse/HAWQ-40
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py e15b64d
Diff: https://reviews.apache.org/r/41832/diff/
Testing
-------
Manually tested by adding HAWQ (using add service).
Thanks,
Lav Jain
Re: Review Request 41832: Run hawq init standby on standby node
instead of master
Posted by Lav Jain <lj...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41832/
-----------------------------------------------------------
(Updated Dec. 31, 2015, 7:48 p.m.)
Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, Jaimin Jetly, jun aoki, Matt, Newton Alex, and Oleksandr Diachenko.
Changes
-------
Applied feedback (remove log message for configure)
Bugs: AMBARI-14527
https://issues.apache.org/jira/browse/AMBARI-14527
Repository: ambari
Description
-------
Driven by HAWQ change https://issues.apache.org/jira/browse/HAWQ-40
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py cf7dc77
Diff: https://reviews.apache.org/r/41832/diff/
Testing
-------
Manually tested by adding HAWQ (using add service).
Thanks,
Lav Jain