[GitHub] [tvm] srkreddy1238 commented on a diff in pull request #14000: [DOCKER] Configurable NDK version support

["srkreddy1238 (via GitHub)" <gi...@apache.org>]

srkreddy1238 commented on code in PR #14000:
URL: https://github.com/apache/tvm/pull/14000#discussion_r1108874369


##########
docker/Dockerfile.ci_adreno:
##########
@@ -22,10 +22,7 @@ COPY utils/apt-install-and-clear.sh /usr/local/bin/apt-install-and-clear
 
 # Android SDK
 COPY install/ubuntu_install_androidsdk.sh /install/ubuntu_install_androidsdk.sh
-RUN bash /install/ubuntu_install_androidsdk.sh
-ENV ANDROID_HOME=/opt/android-sdk-linux
-ENV ANDROID_NDK_HOME=/opt/android-sdk-linux/ndk/21.3.6528147
-ENV ANDROID_NDK_MAJOR=21
+RUN bash /install/ubuntu_install_androidsdk.sh 25.2.9519653 25

Review Comment:
   Done. Made few other tools versions too configurable. Cmake was causing some warnings over older version with new NDK.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org