You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2026/09/11 10:59:42 UTC
[Impala-ASF-CR] Bump Java Thrift to 0.24.0 and migrate LdapHS2Test to httpclient5
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24820
Change subject: Bump Java Thrift to 0.24.0 and migrate LdapHS2Test to httpclient5
......................................................................
Bump Java Thrift to 0.24.0 and migrate LdapHS2Test to httpclient5
Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Co-Authored-By: Claude Opus 4.8 <no...@anthropic.com>
---
M bin/impala-config.sh
M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java
2 files changed, 11 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/24820/1
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-15367: Bump thrift to 0.24.0 - java parts
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24820 )
Change subject: IMPALA-15367: Bump thrift to 0.24.0 - java parts
......................................................................
IMPALA-15367: Bump thrift to 0.24.0 - java parts
Metastore thrift classes are still pulled in from Hive
and are generated with Thrift 0.16.0, which seems genarally
compatible with 0.24.0 runtime.
Thrift 0.24.0 moved from HttpClient 4 to 5, which required
workarounds in some tests:
- JdbcTest: xfail hs2-http tests until Hive also uses Thrift 0.24
- TestCaseLoaderTest: xfail until Hive also uses Thrift 0.24
- LdapHS2Test: don't compile when using Apache Hive, where Impala
uses Thrift 0.11.0
The xfails can be removed once Impala gets a cdp dependency with
Hive that uses Thrift 0.24.0 (IMPALA-15384).
org.apache.httpcomponents has both versions 4 and 5 in Impala,
which is normal as they use different group and arfifact id. There
are many dependencies that use 4 besides old Thrift.
Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Assisted-By: Claude Opus 4.8
Reviewed-on: http://gerrit.cloudera.org:8080/24820
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Quanlong Huang <hu...@gmail.com>
---
M bin/impala-config.sh
M fe/pom.xml
M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java
M fe/src/test/java/org/apache/impala/planner/TestCaseLoaderTest.java
M fe/src/test/java/org/apache/impala/service/JdbcTestBase.java
M java/pom.xml
6 files changed, 79 insertions(+), 13 deletions(-)
Approvals:
Michael Smith: Looks good to me, but someone else must approve
Impala Public Jenkins: Verified
Quanlong Huang: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 9
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
[Impala-ASF-CR] WIP IMPALA-15367: Bump thrift to 0.24.0 - java parts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24820 )
Change subject: WIP IMPALA-15367: Bump thrift to 0.24.0 - java parts
......................................................................
Patch Set 5: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/14100/
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 21 Sep 2026 01:16:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15367: Bump thrift to 0.24.0 - java parts
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24820 )
Change subject: IMPALA-15367: Bump thrift to 0.24.0 - java parts
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 8
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Sep 2026 12:00:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP IMPALA-15367: Bump thrift to 0.24.0 - java parts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24820 )
Change subject: WIP IMPALA-15367: Bump thrift to 0.24.0 - java parts
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14100/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Sun, 20 Sep 2026 20:56:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15367: Bump thrift to 0.24.0 - java parts
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24820 )
Change subject: IMPALA-15367: Bump thrift to 0.24.0 - java parts
......................................................................
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 8
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 21 Sep 2026 16:31:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15367: Bump thrift to 0.24.0 - java parts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24820 )
Change subject: IMPALA-15367: Bump thrift to 0.24.0 - java parts
......................................................................
Patch Set 8: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 8
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 21 Sep 2026 20:58:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump Java Thrift to 0.24.0 and migrate LdapHS2Test to httpclient5
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24820 )
Change subject: Bump Java Thrift to 0.24.0 and migrate LdapHS2Test to httpclient5
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14037/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 12:55:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump Java Thrift to 0.24.0 and migrate LdapHS2Test to httpclient5
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24820 )
Change subject: Bump Java Thrift to 0.24.0 and migrate LdapHS2Test to httpclient5
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/24820/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/24820/2//COMMIT_MSG@10
PS2, Line 10: Co-Authored-By: Claude Opus 4.8 <no...@anthropic.com>
Our recommendation on https://cwiki.apache.org/confluence/spaces/IMPALA/pages/65147115/Contributing+to+Impala is to use `Assisted-By:`.
http://gerrit.cloudera.org:8080/#/c/24820/2/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/24820/2/bin/impala-config.sh@90
PS2, Line 90: ${IMPALA_TOOLCHAIN_COMMIT_HASH-32269ea38b19f85985dc2234cc941bbf3ae6609e}
Confirmed head of https://github.com/cloudera/native-toolchain/commits/master/.
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 14:29:12 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] WIP IMPALA-15367: Bump thrift to 0.24.0 - java parts
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24820
to look at the new patch set (#3).
Change subject: WIP IMPALA-15367: Bump thrift to 0.24.0 - java parts
......................................................................
WIP IMPALA-15367: Bump thrift to 0.24.0 - java parts
Also upgrades from apache HttpClient 4 to 5 to follow
Thrift.
There are some failing tests due to conflict between
0.24.0 and Hive's 0.16.0 Thrift
Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Assisted-By: Claude Opus 4.8
---
M bin/impala-config.sh
M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java
M java/pom.xml
3 files changed, 37 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/24820/3
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-15367: Bump thrift to 0.24.0 - java parts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24820 )
Change subject: IMPALA-15367: Bump thrift to 0.24.0 - java parts
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/24119/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 21 Sep 2026 09:33:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump Java Thrift to 0.24.0 and migrate LdapHS2Test to httpclient5
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24820 )
Change subject: Bump Java Thrift to 0.24.0 and migrate LdapHS2Test to httpclient5
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/23978/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Sep 2026 11:09:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15367: Bump thrift to 0.24.0 - java parts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24820 )
Change subject: IMPALA-15367: Bump thrift to 0.24.0 - java parts
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14102/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 21 Sep 2026 09:40:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15367: Bump thrift to 0.24.0 - java parts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24820 )
Change subject: IMPALA-15367: Bump thrift to 0.24.0 - java parts
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/24120/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 21 Sep 2026 10:02:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15367: Bump thrift to 0.24.0 - java parts
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24820
to look at the new patch set (#8).
Change subject: IMPALA-15367: Bump thrift to 0.24.0 - java parts
......................................................................
IMPALA-15367: Bump thrift to 0.24.0 - java parts
Metastore thrift classes are still pulled in from Hive
and are generated with Thrift 0.16.0, which seems genarally
compatible with 0.24.0 runtime.
Thrift 0.24.0 moved from HttpClient 4 to 5, which required
workarounds in some tests:
- JdbcTest: xfail hs2-http tests until Hive also uses Thrift 0.24
- TestCaseLoaderTest: xfail until Hive also uses Thrift 0.24
- LdapHS2Test: don't compile when using Apache Hive, where Impala
uses Thrift 0.11.0
The xfails can be removed once Impala gets a cdp dependency with
Hive that uses Thrift 0.24.0 (IMPALA-15384).
org.apache.httpcomponents has both versions 4 and 5 in Impala,
which is normal as they use different group and arfifact id. There
are many dependencies that use 4 besides old Thrift.
Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Assisted-By: Claude Opus 4.8
---
M bin/impala-config.sh
M fe/pom.xml
M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java
M fe/src/test/java/org/apache/impala/planner/TestCaseLoaderTest.java
M fe/src/test/java/org/apache/impala/service/JdbcTestBase.java
M java/pom.xml
6 files changed, 79 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/24820/8
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 8
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-15367: Bump thrift to 0.24.0 - java parts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24820 )
Change subject: IMPALA-15367: Bump thrift to 0.24.0 - java parts
......................................................................
Patch Set 8:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14106/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 8
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 21 Sep 2026 16:32:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump Java Thrift to 0.24.0 and migrate LdapHS2Test to httpclient5
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24820 )
Change subject: Bump Java Thrift to 0.24.0 and migrate LdapHS2Test to httpclient5
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/24820/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/24820/2//COMMIT_MSG@10
PS2, Line 10: Co-Authored-By: Claude Opus 4.8 <no...@anthropic.com>
> Our recommendation on https://cwiki.apache.org/confluence/spaces/IMPALA/pag
I considered this WIP change and wanted to update commit message, including assigning a Jira. I haven't run all tests yet, will finalize this once they passed.
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 14:54:42 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-15367: Bump thrift to 0.24.0 - java parts
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24820
to look at the new patch set (#7).
Change subject: IMPALA-15367: Bump thrift to 0.24.0 - java parts
......................................................................
IMPALA-15367: Bump thrift to 0.24.0 - java parts
Metastore thrift classes are still pulled in from Hive
and are generated with Thrift 0.16.0, which seems genarally
compatible with 0.24.0 runtime.
Thrift 0.24.0 moved from HttpClient 4 to 5, which required
workarounds in some tests:
- JdbcTest: xfail hs2-http tests until Hive also uses Thrift 0.24
- TestCaseLoaderTest: xfail until Hive also uses Thrift 0.24
- LdapHS2Test: don't compile when using Apache Hive, where Impala
uses Thrift 0.11.0
The xfails can be removed once Impala gets a cdp dependency with
Hive that uses Thrift 0.24.0 (IMPALA-15384).
org.apache.httpcomponents has both versions 4 and 5 in Impala,
which is normal as they use different group and arfifact id. There
are many dependencies that use 4 besides old Thrift.
Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Assisted-By: Claude Opus 4.8
---
M bin/impala-config.sh
M fe/pom.xml
M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java
M fe/src/test/java/org/apache/impala/planner/TestCaseLoaderTest.java
M fe/src/test/java/org/apache/impala/service/JdbcTestBase.java
M java/pom.xml
6 files changed, 72 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/24820/7
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-15367: Bump thrift to 0.24.0 - java parts
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24820
to look at the new patch set (#6).
Change subject: IMPALA-15367: Bump thrift to 0.24.0 - java parts
......................................................................
IMPALA-15367: Bump thrift to 0.24.0 - java parts
Metastore thrift classes are still pulled in from Hive
and are generated with Thrift 0.16.0, which seems genarally
compatible with 0.24.0 runtime.
Thrift 0.24.0 moved from HttpClient 4 to 5, which required
workarounds in some tests:
- JdbcTest: xfail hs2-http tests until Hive also uses Thrift 0.24
- TestCaseLoaderTest: xfail until Hive also uses Thrift 0.24
- LdapHS2Test: don't compile when using Apache Hive, where Impala
uses Thrift 0.11.0
The xfails can be removed once Impala gets a cdp dependency with
Hive that uses Thrift 0.24.0 (IMPALA-15384).
org.apache.httpcomponents has both versions 4 and 5 in Impala,
which is normal as they use different group and arfifact id. There
are many dependencies that use 4.
Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Assisted-By: Claude Opus 4.8
---
M bin/impala-config.sh
M fe/pom.xml
M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java
M fe/src/test/java/org/apache/impala/planner/TestCaseLoaderTest.java
M fe/src/test/java/org/apache/impala/service/JdbcTestBase.java
M java/pom.xml
M java/shaded-deps/hive-exec/pom.xml
7 files changed, 80 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/24820/6
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] Bump Java Thrift to 0.24.0 and migrate LdapHS2Test to httpclient5
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24820 )
Change subject: Bump Java Thrift to 0.24.0 and migrate LdapHS2Test to httpclient5
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/14037/
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 17:29:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP IMPALA-15367: Bump thrift to 0.24.0 - java parts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24820 )
Change subject: WIP IMPALA-15367: Bump thrift to 0.24.0 - java parts
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14066/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Sep 2026 11:21:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP IMPALA-15367: Bump thrift to 0.24.0 - java parts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24820 )
Change subject: WIP IMPALA-15367: Bump thrift to 0.24.0 - java parts
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/24070/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Sep 2026 11:46:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump Java Thrift to 0.24.0 and migrate LdapHS2Test to httpclient5
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24820
to look at the new patch set (#2).
Change subject: Bump Java Thrift to 0.24.0 and migrate LdapHS2Test to httpclient5
......................................................................
Bump Java Thrift to 0.24.0 and migrate LdapHS2Test to httpclient5
Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Co-Authored-By: Claude Opus 4.8 <no...@anthropic.com>
---
M bin/impala-config.sh
M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java
2 files changed, 14 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/24820/2
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] Bump Java Thrift to 0.24.0 and migrate LdapHS2Test to httpclient5
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24820 )
Change subject: Bump Java Thrift to 0.24.0 and migrate LdapHS2Test to httpclient5
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/24032/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 13:16:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP IMPALA-15367: Bump thrift to 0.24.0 - java parts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24820 )
Change subject: WIP IMPALA-15367: Bump thrift to 0.24.0 - java parts
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/14066/
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Sep 2026 15:46:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP IMPALA-15367: Bump thrift to 0.24.0 - java parts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24820 )
Change subject: WIP IMPALA-15367: Bump thrift to 0.24.0 - java parts
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/24112/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Sun, 20 Sep 2026 21:17:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP IMPALA-15367: Bump thrift to 0.24.0 - java parts
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24820
to look at the new patch set (#5).
Change subject: WIP IMPALA-15367: Bump thrift to 0.24.0 - java parts
......................................................................
WIP IMPALA-15367: Bump thrift to 0.24.0 - java parts
Also upgrades from apache HttpClient 4 to 5 to follow
Thrift.
There are some failing tests due to conflict between
0.24.0 and Hive's 0.16.0 Thrift
Also fix the Apache Hive build (banned jersey-server dep; HttpClient-5 test split out).
Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Assisted-By: Claude Opus 4.8
---
M bin/impala-config.sh
M fe/pom.xml
A fe/src/test/java/org/apache/impala/customcluster/LdapHS2SharedCookieTest.java
M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java
M java/pom.xml
M java/shaded-deps/hive-exec/pom.xml
6 files changed, 246 insertions(+), 105 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/24820/5
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-15367: Bump thrift to 0.24.0 - java parts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24820 )
Change subject: IMPALA-15367: Bump thrift to 0.24.0 - java parts
......................................................................
Patch Set 7: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/14102/
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 21 Sep 2026 14:18:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15367: Bump thrift to 0.24.0 - java parts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24820 )
Change subject: IMPALA-15367: Bump thrift to 0.24.0 - java parts
......................................................................
Patch Set 8:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/24125/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 8
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 21 Sep 2026 16:48:39 +0000
Gerrit-HasComments: No