You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2021/05/26 22:13:20 UTC
[commons-pool] branch master updated: Use final.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-pool.git
The following commit(s) were added to refs/heads/master by this push:
new 20bdd4c Use final.
20bdd4c is described below
commit 20bdd4c18815f9e51a89a93535a999461ca69178
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Wed May 26 18:13:16 2021 -0400
Use final.
---
.../java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java | 2 +-
.../java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java | 2 +-
src/main/java/org/apache/commons/pool2/impl/PoolImplUtils.java | 4 ++--
src/test/java/org/apache/commons/pool2/impl/CallStackTest.java | 4 ++--
src/test/java/org/apache/commons/pool2/impl/TestEvictionConfig.java | 6 +++---
5 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java b/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java
index c00f43c..810111f 100644
--- a/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java
+++ b/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java
@@ -256,7 +256,7 @@ public abstract class BaseGenericObjectPool<T> extends BaseObject {
}
}
- void add(Duration value) {
+ void add(final Duration value) {
add(value.toMillis());
}
diff --git a/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java b/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
index 5e23b6c..ff42fd2 100644
--- a/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
+++ b/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
@@ -1530,7 +1530,7 @@ public class GenericKeyedObjectPool<K, T> extends BaseGenericObjectPool<T>
@SuppressWarnings("resource") // PrintWriter is managed elsewhere
private void removeAbandoned(final AbandonedConfig abandonedConfig) {
for (final Entry<K, GenericKeyedObjectPool<K, T>.ObjectDeque<T>> pool : poolMap.entrySet()) {
- Map<IdentityWrapper<T>, PooledObject<T>> allObjects = pool.getValue().getAllObjects();
+ final Map<IdentityWrapper<T>, PooledObject<T>> allObjects = pool.getValue().getAllObjects();
// Generate a list of abandoned objects to remove
final long nowMillis = System.currentTimeMillis();
diff --git a/src/main/java/org/apache/commons/pool2/impl/PoolImplUtils.java b/src/main/java/org/apache/commons/pool2/impl/PoolImplUtils.java
index e57f1a1..5aebe55 100644
--- a/src/main/java/org/apache/commons/pool2/impl/PoolImplUtils.java
+++ b/src/main/java/org/apache/commons/pool2/impl/PoolImplUtils.java
@@ -168,7 +168,7 @@ class PoolImplUtils {
* @param timeUnit A TimeUnit.
* @return The corresponding ChronoUnit.
*/
- static ChronoUnit toChronoUnit(TimeUnit timeUnit) {
+ static ChronoUnit toChronoUnit(final TimeUnit timeUnit) {
// TODO when using Java >= 9: Use TimeUnit.toChronoUnit().
switch (Objects.requireNonNull(timeUnit)) {
case NANOSECONDS:
@@ -197,7 +197,7 @@ class PoolImplUtils {
* @param timeUnit the unit that the duration is measured in, must have an exact duration, not null
* @return a Duration.
*/
- static Duration toDuration(long amount, TimeUnit timeUnit) {
+ static Duration toDuration(final long amount, final TimeUnit timeUnit) {
return Duration.of(amount, PoolImplUtils.toChronoUnit(timeUnit));
}
}
diff --git a/src/test/java/org/apache/commons/pool2/impl/CallStackTest.java b/src/test/java/org/apache/commons/pool2/impl/CallStackTest.java
index 805ee3a..c6f3988 100644
--- a/src/test/java/org/apache/commons/pool2/impl/CallStackTest.java
+++ b/src/test/java/org/apache/commons/pool2/impl/CallStackTest.java
@@ -41,7 +41,7 @@ public class CallStackTest {
@ParameterizedTest
@MethodSource("data")
- public void testPrintClearedStackTraceIsNoOp(CallStack stack) throws Exception {
+ public void testPrintClearedStackTraceIsNoOp(final CallStack stack) throws Exception {
stack.fillInStackTrace();
stack.clear();
stack.printStackTrace(new PrintWriter(writer));
@@ -51,7 +51,7 @@ public class CallStackTest {
@ParameterizedTest
@MethodSource("data")
- public void testPrintFilledStackTrace(CallStack stack) throws Exception {
+ public void testPrintFilledStackTrace(final CallStack stack) throws Exception {
stack.fillInStackTrace();
stack.printStackTrace(new PrintWriter(writer));
final String stackTrace = writer.toString();
diff --git a/src/test/java/org/apache/commons/pool2/impl/TestEvictionConfig.java b/src/test/java/org/apache/commons/pool2/impl/TestEvictionConfig.java
index 49cbdc4..f46044d 100644
--- a/src/test/java/org/apache/commons/pool2/impl/TestEvictionConfig.java
+++ b/src/test/java/org/apache/commons/pool2/impl/TestEvictionConfig.java
@@ -29,7 +29,7 @@ public class TestEvictionConfig {
@Test
public void testConstructor1s() {
- EvictionConfig config = new EvictionConfig(Duration.ofMillis(1), Duration.ofMillis(1), 1);
+ final EvictionConfig config = new EvictionConfig(Duration.ofMillis(1), Duration.ofMillis(1), 1);
assertEquals(1, config.getIdleEvictTime());
assertEquals(1, config.getIdleEvictTimeDuration().toMillis());
@@ -40,7 +40,7 @@ public class TestEvictionConfig {
@Test
public void testConstructorZerosDurations() {
- EvictionConfig config = new EvictionConfig(Duration.ZERO, Duration.ZERO, 0);
+ final EvictionConfig config = new EvictionConfig(Duration.ZERO, Duration.ZERO, 0);
assertEquals(Long.MAX_VALUE, config.getIdleEvictTime());
assertEquals(Long.MAX_VALUE, config.getIdleEvictTimeDuration().toMillis());
@@ -52,7 +52,7 @@ public class TestEvictionConfig {
@Test
public void testConstructorZerosMillis() {
@SuppressWarnings("deprecation")
- EvictionConfig config = new EvictionConfig(0, 0, 0);
+ final EvictionConfig config = new EvictionConfig(0, 0, 0);
assertEquals(Long.MAX_VALUE, config.getIdleEvictTime());
assertEquals(Long.MAX_VALUE, config.getIdleEvictTimeDuration().toMillis());