You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2021/01/17 15:28:22 UTC
[commons-net] 01/02: Use isEmpty().
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git
commit 30fe35d032c550d9295616538cf16b07bb9023c1
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Jan 17 10:28:02 2021 -0500
Use isEmpty().
---
src/main/java/org/apache/commons/net/examples/nntp/PostMessage.java | 4 ++--
src/main/java/org/apache/commons/net/ftp/FTPHTTPClient.java | 2 +-
.../java/org/apache/commons/net/ftp/parser/MVSFTPEntryParser.java | 2 +-
src/main/java/org/apache/commons/net/telnet/Telnet.java | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/main/java/org/apache/commons/net/examples/nntp/PostMessage.java b/src/main/java/org/apache/commons/net/examples/nntp/PostMessage.java
index ed4db38..5f4c0b8 100644
--- a/src/main/java/org/apache/commons/net/examples/nntp/PostMessage.java
+++ b/src/main/java/org/apache/commons/net/examples/nntp/PostMessage.java
@@ -114,11 +114,11 @@ public final class PostMessage
references = stdin.readLine();
- if (organization != null && organization.length() > 0) {
+ if (organization != null && !organization.isEmpty()) {
header.addHeaderField("Organization", organization);
}
- if (references != null && references.length() > 0) {
+ if (references != null && !references.isEmpty()) {
header.addHeaderField("References", references);
}
diff --git a/src/main/java/org/apache/commons/net/ftp/FTPHTTPClient.java b/src/main/java/org/apache/commons/net/ftp/FTPHTTPClient.java
index 207fcab..b51d046 100644
--- a/src/main/java/org/apache/commons/net/ftp/FTPHTTPClient.java
+++ b/src/main/java/org/apache/commons/net/ftp/FTPHTTPClient.java
@@ -209,7 +209,7 @@ public class FTPHTTPClient extends FTPClient {
final List<String> response = new ArrayList<>();
final BufferedReader reader = new BufferedReader(new InputStreamReader(input, getCharset()));
- for (String line = reader.readLine(); line != null && line.length() > 0; line = reader.readLine()) {
+ for (String line = reader.readLine(); line != null && !line.isEmpty(); line = reader.readLine()) {
response.add(line);
}
diff --git a/src/main/java/org/apache/commons/net/ftp/parser/MVSFTPEntryParser.java b/src/main/java/org/apache/commons/net/ftp/parser/MVSFTPEntryParser.java
index 389d8b2..7dce7db 100644
--- a/src/main/java/org/apache/commons/net/ftp/parser/MVSFTPEntryParser.java
+++ b/src/main/java/org/apache/commons/net/ftp/parser/MVSFTPEntryParser.java
@@ -376,7 +376,7 @@ public class MVSFTPEntryParser extends ConfigurableFTPFileEntryParserImpl {
* safe context, for example from a memberlist, where the regex for some
* reason fails. Then just assign the name field of FTPFile.
*/
- if (entry != null && entry.trim().length() > 0) {
+ if (entry != null && !entry.trim().isEmpty()) {
file.setRawListing(entry);
final String name = entry.split(" ")[0];
file.setName(name);
diff --git a/src/main/java/org/apache/commons/net/telnet/Telnet.java b/src/main/java/org/apache/commons/net/telnet/Telnet.java
index 257fa01..17658d8 100644
--- a/src/main/java/org/apache/commons/net/telnet/Telnet.java
+++ b/src/main/java/org/apache/commons/net/telnet/Telnet.java
@@ -441,7 +441,7 @@ class Telnet extends SocketClient
/* TERMINAL-TYPE option (start)*/
if (option == TERMINAL_TYPE)
{
- if (terminalType != null && terminalType.length() > 0)
+ if (terminalType != null && !terminalType.isEmpty())
{
acceptNewState = true;
}