You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/09/01 10:49:46 UTC
[GitHub] [flink] zentol opened a new pull request #17097: [FLINK-24047][tests] Retry if leader election is in progress
zentol opened a new pull request #17097:
URL: https://github.com/apache/flink/pull/17097
SavepointITCase#waitUntilAllTasksAreRunning is querying the REST API, but did not account for the possibility of requests failing due to leader elections being in progress. If the startup of the cluster was slow the test ended up failing.
We now use the RestClusterClient to submit these requests which automatically retries in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17097: [FLINK-24047][tests] Retry if leader election is in progress
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17097:
URL: https://github.com/apache/flink/pull/17097#issuecomment-910200050
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9b27cc0b4a03e389b297eb3325328bc73726042e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9b27cc0b4a03e389b297eb3325328bc73726042e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9b27cc0b4a03e389b297eb3325328bc73726042e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #17097: [FLINK-24047][tests] Retry if leader election is in progress
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #17097:
URL: https://github.com/apache/flink/pull/17097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17097: [FLINK-24047][tests] Retry if leader election is in progress
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17097:
URL: https://github.com/apache/flink/pull/17097#issuecomment-910200050
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9b27cc0b4a03e389b297eb3325328bc73726042e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9b27cc0b4a03e389b297eb3325328bc73726042e",
"triggerType" : "PUSH"
}, {
"hash" : "29fd058bb1bcb381b1b6d7420d5a019a56d67dda",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "29fd058bb1bcb381b1b6d7420d5a019a56d67dda",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9b27cc0b4a03e389b297eb3325328bc73726042e UNKNOWN
* 29fd058bb1bcb381b1b6d7420d5a019a56d67dda UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17097: [FLINK-24047][tests] Retry if leader election is in progress
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17097:
URL: https://github.com/apache/flink/pull/17097#issuecomment-910200050
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9b27cc0b4a03e389b297eb3325328bc73726042e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9b27cc0b4a03e389b297eb3325328bc73726042e",
"triggerType" : "PUSH"
}, {
"hash" : "29fd058bb1bcb381b1b6d7420d5a019a56d67dda",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23317",
"triggerID" : "29fd058bb1bcb381b1b6d7420d5a019a56d67dda",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9b27cc0b4a03e389b297eb3325328bc73726042e UNKNOWN
* 29fd058bb1bcb381b1b6d7420d5a019a56d67dda Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23317)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17097: [FLINK-24047][tests] Retry if leader election is in progress
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17097:
URL: https://github.com/apache/flink/pull/17097#issuecomment-910200050
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9b27cc0b4a03e389b297eb3325328bc73726042e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9b27cc0b4a03e389b297eb3325328bc73726042e",
"triggerType" : "PUSH"
}, {
"hash" : "29fd058bb1bcb381b1b6d7420d5a019a56d67dda",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23317",
"triggerID" : "29fd058bb1bcb381b1b6d7420d5a019a56d67dda",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9b27cc0b4a03e389b297eb3325328bc73726042e UNKNOWN
* 29fd058bb1bcb381b1b6d7420d5a019a56d67dda Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23317)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17097: [FLINK-24047][tests] Retry if leader election is in progress
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17097:
URL: https://github.com/apache/flink/pull/17097#issuecomment-910166465
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 9b27cc0b4a03e389b297eb3325328bc73726042e (Wed Sep 01 10:52:48 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org