You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by hv...@apache.org on 2018/04/08 18:26:38 UTC
spark git commit: [SPARK-23892][TEST] Improve converge and fix lint
error in UTF8String-related tests
Repository: spark
Updated Branches:
refs/heads/master 6a734575a -> 710a68cec
[SPARK-23892][TEST] Improve converge and fix lint error in UTF8String-related tests
## What changes were proposed in this pull request?
This PR improves test coverage in `UTF8StringSuite` and code efficiency in `UTF8StringPropertyCheckSuite`.
This PR also fixes lint-java issue in `UTF8StringSuite` reported at [here](https://github.com/apache/spark/pull/20995#issuecomment-379325527)
```[ERROR] src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java:[28,8] (imports) UnusedImports: Unused import - org.apache.spark.unsafe.Platform.```
## How was this patch tested?
Existing UT
Author: Kazuaki Ishizaki <is...@jp.ibm.com>
Closes #21000 from kiszk/SPARK-23892.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/710a68ce
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/710a68ce
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/710a68ce
Branch: refs/heads/master
Commit: 710a68cec27a94c2df10d8b4022a755a94a5443b
Parents: 6a73457
Author: Kazuaki Ishizaki <is...@jp.ibm.com>
Authored: Sun Apr 8 20:26:31 2018 +0200
Committer: Herman van Hovell <hv...@databricks.com>
Committed: Sun Apr 8 20:26:31 2018 +0200
----------------------------------------------------------------------
.../java/org/apache/spark/unsafe/types/UTF8StringSuite.java | 5 ++---
.../spark/unsafe/types/UTF8StringPropertyCheckSuite.scala | 2 +-
2 files changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/710a68ce/common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java
----------------------------------------------------------------------
diff --git a/common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java b/common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java
index 2c08535..42dda30 100644
--- a/common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java
+++ b/common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java
@@ -25,7 +25,6 @@ import java.nio.charset.StandardCharsets;
import java.util.*;
import com.google.common.collect.ImmutableMap;
-import org.apache.spark.unsafe.Platform;
import org.apache.spark.unsafe.memory.ByteArrayMemoryBlock;
import org.apache.spark.unsafe.memory.OnHeapMemoryBlock;
import org.junit.Test;
@@ -53,8 +52,8 @@ public class UTF8StringSuite {
assertTrue(s1.contains(s2));
assertTrue(s2.contains(s1));
- assertTrue(s1.startsWith(s1));
- assertTrue(s1.endsWith(s1));
+ assertTrue(s1.startsWith(s2));
+ assertTrue(s1.endsWith(s2));
}
@Test
http://git-wip-us.apache.org/repos/asf/spark/blob/710a68ce/common/unsafe/src/test/scala/org/apache/spark/unsafe/types/UTF8StringPropertyCheckSuite.scala
----------------------------------------------------------------------
diff --git a/common/unsafe/src/test/scala/org/apache/spark/unsafe/types/UTF8StringPropertyCheckSuite.scala b/common/unsafe/src/test/scala/org/apache/spark/unsafe/types/UTF8StringPropertyCheckSuite.scala
index 62d4176..48004e8 100644
--- a/common/unsafe/src/test/scala/org/apache/spark/unsafe/types/UTF8StringPropertyCheckSuite.scala
+++ b/common/unsafe/src/test/scala/org/apache/spark/unsafe/types/UTF8StringPropertyCheckSuite.scala
@@ -164,7 +164,7 @@ class UTF8StringPropertyCheckSuite extends FunSuite with GeneratorDrivenProperty
def padding(origin: String, pad: String, length: Int, isLPad: Boolean): String = {
if (length <= 0) return ""
if (length <= origin.length) {
- if (length <= 0) "" else origin.substring(0, length)
+ origin.substring(0, length)
} else {
if (pad.length == 0) return origin
val toPad = length - origin.length
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org