You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2018/09/18 16:18:35 UTC
Review Request 68746: ATLAS-2877: updated notification processing to
wait only before retry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68746/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-2877
https://issues.apache.org/jira/browse/ATLAS-2877
Repository: atlas
Description
-------
- updated notification processing to skip wait after the last attempt
- also updated failedMessages buffer to store string instead of HookNotification message, to avoid holding complex HookNotification objects
Diffs
-----
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java d680e4e92
Diff: https://reviews.apache.org/r/68746/diff/1/
Testing
-------
- verified that excessive wait in notification processing is avoided
- pre-commit test run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/665/
Thanks,
Madhan Neethiraj
Re: Review Request 68746: ATLAS-2877: updated notification processing
to wait only before retry
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68746/#review208711
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Sept. 18, 2018, 9:18 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68746/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2018, 9:18 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2877
> https://issues.apache.org/jira/browse/ATLAS-2877
>
>
> Repository: atlas
>
>
> Description
> -------
>
> - updated notification processing to skip wait after the last attempt
> - also updated failedMessages buffer to store string instead of HookNotification message, to avoid holding complex HookNotification objects
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java d680e4e92
>
>
> Diff: https://reviews.apache.org/r/68746/diff/1/
>
>
> Testing
> -------
>
> - verified that excessive wait in notification processing is avoided
> - pre-commit test run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/665/
>
>
> Thanks,
>
> Madhan Neethiraj
>
>