You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@artemis.apache.org by "GChuf (via GitHub)" <gi...@apache.org> on 2026/06/23 07:30:57 UTC

[PR] ARTEMIS-6127 Remove JDK8/IBM related code [artemis]

GChuf opened a new pull request, #6536:
URL: https://github.com/apache/artemis/pull/6536

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org

Re: [PR] ARTEMIS-6127 Remove JDK8/IBM related code [artemis]

Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on PR #6536:
URL: https://github.com/apache/artemis/pull/6536#issuecomment-4791593020

   lgtm. We don't support JDK 1.8 for some time already.
   
   I guess you could squash your commits though?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org

Re: [PR] ARTEMIS-6127 Remove JDK8/IBM related code [artemis]

Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #6536:
URL: https://github.com/apache/artemis/pull/6536#issuecomment-4791679128

   The code in question lists JDK 8 in the comment, but it's not applying that in practice. It is simply checking for an IBM JDK. My concern here is that if later versions of IBM JDKs (e.g. 17) have the same behavior as they did in 8 then removing this code could break them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org

Re: [PR] ARTEMIS-6127 Remove JDK8/IBM related code [artemis]

Posted by "GChuf (via GitHub)" <gi...@apache.org>.
GChuf commented on PR #6536:
URL: https://github.com/apache/artemis/pull/6536#issuecomment-4797013045

   @clebertsuconic I can squash the commits into 2 or 1, not a problem - up to you.
   @jbertram you're right - while I didn't test these changes, a google search indicated that TLS1.2 "should" be available on all major vendors' JDKs from 17 onwards (or from 11 already).
   This would make sense to me, since JDK8 and TLS1.2 **support/availability** are roughly of the same age (TLS1.2 was starting to be supported on browsers since 2014) - this is probably why someone had issues with JDK8 and TLS1.2 in the first place.
   There's also the problem of TLS1.3 not being included in the "included protocols" when that code fires ...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org

Re: [PR] ARTEMIS-6127 Remove JDK8/IBM related code [artemis]

Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram merged PR #6536:
URL: https://github.com/apache/artemis/pull/6536


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org