You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Kevin Oliver (JIRA)" <ji...@apache.org> on 2009/12/18 18:16:18 UTC
[jira] Created: (AVRO-259) GenericData.Array should fail fast when
constructed with a null Schema
GenericData.Array should fail fast when constructed with a null Schema
----------------------------------------------------------------------
Key: AVRO-259
URL: https://issues.apache.org/jira/browse/AVRO-259
Project: Avro
Issue Type: Bug
Components: java
Reporter: Kevin Oliver
Priority: Trivial
Fix For: 1.3.0
GenericData.Array's constructor takes a Schema but doesn't validate that it is not null. The schema is assumed to be not null in other places (equals() and hashCode()) which then trigger NPEs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-259) GenericData.Array should fail fast when
constructed with a null Schema
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-259:
------------------------------
Resolution: Fixed
Assignee: Kevin Oliver
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. I also implemented the null check for GenericData.Record.
Sorry it took me so long.
Thanks, Kevin!
> GenericData.Array should fail fast when constructed with a null Schema
> ----------------------------------------------------------------------
>
> Key: AVRO-259
> URL: https://issues.apache.org/jira/browse/AVRO-259
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Kevin Oliver
> Assignee: Kevin Oliver
> Priority: Trivial
> Fix For: 1.3.0
>
> Attachments: AVRO-259.patch
>
>
> GenericData.Array's constructor takes a Schema but doesn't validate that it is not null. The schema is assumed to be not null in other places (equals() and hashCode()) which then trigger NPEs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-259) GenericData.Array should fail fast when
constructed with a null Schema
Posted by "Kevin Oliver (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Oliver updated AVRO-259:
------------------------------
Attachment: AVRO-259.patch
> GenericData.Array should fail fast when constructed with a null Schema
> ----------------------------------------------------------------------
>
> Key: AVRO-259
> URL: https://issues.apache.org/jira/browse/AVRO-259
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Kevin Oliver
> Priority: Trivial
> Fix For: 1.3.0
>
> Attachments: AVRO-259.patch
>
>
> GenericData.Array's constructor takes a Schema but doesn't validate that it is not null. The schema is assumed to be not null in other places (equals() and hashCode()) which then trigger NPEs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-259) GenericData.Array should fail fast when
constructed with a null Schema
Posted by "Kevin Oliver (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Oliver updated AVRO-259:
------------------------------
Status: Patch Available (was: Open)
> GenericData.Array should fail fast when constructed with a null Schema
> ----------------------------------------------------------------------
>
> Key: AVRO-259
> URL: https://issues.apache.org/jira/browse/AVRO-259
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Kevin Oliver
> Priority: Trivial
> Fix For: 1.3.0
>
> Attachments: AVRO-259.patch
>
>
> GenericData.Array's constructor takes a Schema but doesn't validate that it is not null. The schema is assumed to be not null in other places (equals() and hashCode()) which then trigger NPEs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-259) GenericData.Array should fail fast
when constructed with a null Schema
Posted by "Kevin Oliver (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798237#action_12798237 ]
Kevin Oliver commented on AVRO-259:
-----------------------------------
Anything I can do to help this patch along? Was my initial assumption valid?
> GenericData.Array should fail fast when constructed with a null Schema
> ----------------------------------------------------------------------
>
> Key: AVRO-259
> URL: https://issues.apache.org/jira/browse/AVRO-259
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Kevin Oliver
> Priority: Trivial
> Fix For: 1.3.0
>
> Attachments: AVRO-259.patch
>
>
> GenericData.Array's constructor takes a Schema but doesn't validate that it is not null. The schema is assumed to be not null in other places (equals() and hashCode()) which then trigger NPEs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-259) GenericData.Array should fail fast
when constructed with a null Schema
Posted by "Kevin Oliver (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12792534#action_12792534 ]
Kevin Oliver commented on AVRO-259:
-----------------------------------
Patch coming that includes a testcase.
The patch also includes fixing some missing @Overrides and 2 unnecessary @SuppressWarnings. These can be removed if the committers would prefer they were not included.
> GenericData.Array should fail fast when constructed with a null Schema
> ----------------------------------------------------------------------
>
> Key: AVRO-259
> URL: https://issues.apache.org/jira/browse/AVRO-259
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Kevin Oliver
> Priority: Trivial
> Fix For: 1.3.0
>
>
> GenericData.Array's constructor takes a Schema but doesn't validate that it is not null. The schema is assumed to be not null in other places (equals() and hashCode()) which then trigger NPEs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.