[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5079: Insert target columns empty fix

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #5079:
URL: https://github.com/apache/arrow-datafusion/pull/5079#discussion_r1089736283


##########
datafusion/common/src/config.rs:
##########
@@ -323,7 +323,7 @@ pub struct ConfigOptions {
     pub catalog: CatalogOptions,
     /// Execution options
     pub execution: ExecutionOptions,
-    /// Explain options
+    /// Optimizer options

Review Comment:
   ❤️ Nice drive by cleanup



##########
datafusion/sql/tests/integration_test.rs:
##########
@@ -165,13 +165,60 @@ fn plan_insert() {
         "insert into person (id, first_name, last_name) values (1, 'Alan', 'Turing')";
     let plan = r#"
 Dml: op=[Insert] table=[person]
-  Projection: CAST(column1 AS id AS UInt32), column2 AS first_name, column3 AS last_name

Review Comment:
   👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org