[jira] [Updated] (FLINK-33022) Log when FailureEnricherUtils load FailureEnricherFactory failed should throw exception or add some error logs

["Panagiotis Garefalakis (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-33022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Panagiotis Garefalakis updated FLINK-33022:
-------------------------------------------
    Summary: Log when FailureEnricherUtils load FailureEnricherFactory failed should throw exception or add some error logs  (was: When FailureEnricherUtils load FailureEnricherFactory failed should throw exception or add some error logs)

> Log when FailureEnricherUtils load FailureEnricherFactory failed should throw exception or add some error logs
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-33022
>                 URL: https://issues.apache.org/jira/browse/FLINK-33022
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / Coordination
>    Affects Versions: 1.18.0
>            Reporter: Matt Wang
>            Assignee: Panagiotis Garefalakis
>            Priority: Minor
>
> if we configurate the `jobmanager.failure-enrichers`, but could not load the class in 
> FailureEnricherUtils, no exceptions can be seen in the log currently, and it is very inconvenient to check the problem. Here I suggest that some ERROR-level logs should be added, or an exception should be thrown directly (because the load cannot be uploaded is not an expected result)
> {code:java}
> // code placeholder
> @VisibleForTesting
> static Collection<FailureEnricher> getFailureEnrichers(
>         final Configuration configuration, final PluginManager pluginManager) {
>     Set<String> includedEnrichers = getIncludedFailureEnrichers(configuration);
>     LOG.info("includedEnrichers: {}", includedEnrichers);
>     //  When empty, NO enrichers will be started.
>     if (includedEnrichers.isEmpty()) {
>         return Collections.emptySet();
>     }
>     // TODO: here maybe load nothing
>     final Iterator<FailureEnricherFactory> factoryIterator =
>             pluginManager.load(FailureEnricherFactory.class);
>     ....
> } {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)