[GitHub] [incubator-echarts] dr-itz commented on a change in pull request #8490: Add null checks for setAxisModel

[GitBox <gi...@apache.org>]

dr-itz commented on a change in pull request #8490: Add null checks for setAxisModel
URL: https://github.com/apache/incubator-echarts/pull/8490#discussion_r348177010
 
 

 ##########
 File path: src/component/dataZoom/AxisProxy.js
 ##########
 @@ -481,8 +481,8 @@ function setAxisModel(axisProxy, isRestore) {
     var useOrigin = isRestore || (percentWindow[0] === 0 && percentWindow[1] === 100);
 
     axisModel.setRange(
-        useOrigin ? null : +valueWindow[0].toFixed(precision),
-        useOrigin ? null : +valueWindow[1].toFixed(precision)
+        (useOrigin || valueWindow[0] === null) ? null : +valueWindow[0].toFixed(precision),
+        (useOrigin || valueWindow[1] === null) ? null : +valueWindow[1].toFixed(precision)
 
 Review comment:
   yes, this was on 4.2.1. Unfortunately we cannot really test with the latest version with a time axis since 4.4 and 4.5 break dataZoom as described in #11679. Will report back once that's sorted. Thanks all.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org