You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/09 09:43:39 UTC

[GitHub] [apisix-website] juzhiyuan opened a new issue #407: check out why auto-update docs doesn't work

juzhiyuan opened a new issue #407:
URL: https://github.com/apache/apisix-website/issues/407


   **Actual Behaviour**
   
   We are using `cron` to auto-update docs here: https://github.com/apache/apisix-website/blob/master/.github/workflows/deploy.yml#L14
   
   But it doesn't work now 🤔 according to the `asf-site`'s commit history, no auto-update anymore.
   
   **Expected Behaviour**
   
   It should work as expected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] juzhiyuan commented on issue #407: check out why auto-update docs doesn't work

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #407:
URL: https://github.com/apache/apisix-website/issues/407#issuecomment-877061029


   I just checked this page: https://github.com/apache/apisix-website/actions/workflows/deploy.yml
   
   ![image](https://user-images.githubusercontent.com/2106987/125059150-9957e280-e0dd-11eb-81d7-fde0d691c706.png)
   
   
   And the `cron` works, but when you click to see the detail, you will find that the `Deploy` step is skipped, e.g https://github.com/apache/apisix-website/runs/3015733766?check_suite_focus=true
   
   ![image](https://user-images.githubusercontent.com/2106987/125059247-aecd0c80-e0dd-11eb-82a4-b5ffd2f5d3eb.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] Yiyiyimu commented on issue #407: check out why auto-update docs doesn't work

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on issue #407:
URL: https://github.com/apache/apisix-website/issues/407#issuecomment-877082183


   I think we could change it to
   ```diff
   - if: github.event_name == 'push' && github.ref == 'refs/heads/master'
   + if: github.event_name == 'push' && github.ref == 'refs/heads/master' || github.event_name == 'schedule'
   ```
   
   Ref: https://github.community/t/how-to-set-schedule-event-for-two-branches-and-push-pull-request-events-for-only-one/18267/2?u=yiyiyimu


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] juzhiyuan commented on issue #407: check out why auto-update docs doesn't work

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #407:
URL: https://github.com/apache/apisix-website/issues/407#issuecomment-877063932


   need @Yiyiyimu @liuxiran 's help 🤣
   
   https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#onevent_nametypes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] Yiyiyimu closed issue #407: check out why auto-update docs doesn't work

Posted by GitBox <gi...@apache.org>.
Yiyiyimu closed issue #407:
URL: https://github.com/apache/apisix-website/issues/407


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] juzhiyuan commented on issue #407: check out why auto-update docs doesn't work

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #407:
URL: https://github.com/apache/apisix-website/issues/407#issuecomment-877063063


   How to allow `event_name == 'push'` or `push from Action's cron job`? 🤔 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] Yiyiyimu edited a comment on issue #407: check out why auto-update docs doesn't work

Posted by GitBox <gi...@apache.org>.
Yiyiyimu edited a comment on issue #407:
URL: https://github.com/apache/apisix-website/issues/407#issuecomment-877082183


   I think we could change it to
   ```diff
   - if: github.event_name == 'push' && github.ref == 'refs/heads/master'
   + if: github.event_name == 'push' && github.ref == 'refs/heads/master' || github.event_name == 'schedule'
   ```
   
   Ref: https://github.community/t/how-to-set-schedule-event-for-two-branches-and-push-pull-request-events-for-only-one/18267/2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] juzhiyuan commented on issue #407: check out why auto-update docs doesn't work

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #407:
URL: https://github.com/apache/apisix-website/issues/407#issuecomment-877059042


   cc @iamayushdas to have a check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] juzhiyuan commented on issue #407: check out why auto-update docs doesn't work

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #407:
URL: https://github.com/apache/apisix-website/issues/407#issuecomment-877062057


   Maybe this issue is related to https://github.com/apache/apisix-website/actions/runs/1014046063/workflow#L42 🤔 
   
   We use `github.event_name == 'push'` to check the deploy step is valid (because contributors who have privileges could push codes), what should we change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org