You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2015/03/01 14:36:51 UTC
svn commit: r1663097 - in
/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress:
ArchiveReadTest.java archivers/LongPathTest.java
archivers/LongSymLinkTest.java
Author: sebb
Date: Sun Mar 1 13:36:51 2015
New Revision: 1663097
URL: http://svn.apache.org/r1663097
Log:
Name the parameterised tests
Modified:
commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/ArchiveReadTest.java
commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/LongPathTest.java
commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/LongSymLinkTest.java
Modified: commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/ArchiveReadTest.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/ArchiveReadTest.java?rev=1663097&r1=1663096&r2=1663097&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/ArchiveReadTest.java (original)
+++ commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/ArchiveReadTest.java Sun Mar 1 13:36:51 2015
@@ -53,8 +53,8 @@ public class ArchiveReadTest extends Abs
private File file;
- public ArchiveReadTest(File file){
- this.file = file;
+ public ArchiveReadTest(String file){
+ this.file = new File(ARCDIR, file);
}
@BeforeClass
@@ -72,11 +72,11 @@ public class ArchiveReadTest extends Abs
br.close();
}
- @Parameters
+ @Parameters(name = "file={0}")
public static Collection<Object[]> data() {
assertTrue(ARCDIR.exists());
Collection<Object[]> params = new ArrayList<Object[]>();
- for (File f : ARCDIR.listFiles(new FilenameFilter() {
+ for (String f : ARCDIR.list(new FilenameFilter() {
public boolean accept(File dir, String name) {
return !name.endsWith(".txt");
}
Modified: commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/LongPathTest.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/LongPathTest.java?rev=1663097&r1=1663096&r2=1663097&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/LongPathTest.java (original)
+++ commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/LongPathTest.java Sun Mar 1 13:36:51 2015
@@ -60,8 +60,8 @@ public class LongPathTest extends Abstra
private File file;
- public LongPathTest(File file){
- this.file = file;
+ public LongPathTest(String file){
+ this.file = new File(ARCDIR, file);
}
@BeforeClass
@@ -79,10 +79,10 @@ public class LongPathTest extends Abstra
br.close();
}
- @Parameters
+ @Parameters(name = "file={0}")
public static Collection<Object[]> data() {
Collection<Object[]> params = new ArrayList<Object[]>();
- for (File f : ARCDIR.listFiles(new FilenameFilter() {
+ for (String f : ARCDIR.list(new FilenameFilter() {
public boolean accept(File dir, String name) {
return !name.endsWith(".txt");
}
Modified: commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/LongSymLinkTest.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/LongSymLinkTest.java?rev=1663097&r1=1663096&r2=1663097&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/LongSymLinkTest.java (original)
+++ commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/LongSymLinkTest.java Sun Mar 1 13:36:51 2015
@@ -60,8 +60,8 @@ public class LongSymLinkTest extends Abs
private File file;
- public LongSymLinkTest(File file){
- this.file = file;
+ public LongSymLinkTest(String file){
+ this.file = new File(ARCDIR, file);
}
@BeforeClass
@@ -79,10 +79,10 @@ public class LongSymLinkTest extends Abs
br.close();
}
- @Parameters
+ @Parameters(name = "file={0}")
public static Collection<Object[]> data() {
Collection<Object[]> params = new ArrayList<Object[]>();
- for (File f : ARCDIR.listFiles(new FilenameFilter() {
+ for (String f : ARCDIR.list(new FilenameFilter() {
public boolean accept(File dir, String name) {
return !name.endsWith(".txt");
}