[GitHub] [geode] dschneider-pivotal opened pull request #2711: GEODE-5927: enhance create jndi-binding to configure pool

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

The create jndi-binding --datasource-config-properties will now check each
name for a "pool." prefix. If found then that property, minus the prefix,
will be added to the properties that the PooledDataSourceFactory gets to
configure the pool. The other datasource config properties are still used
to configure the database.
The help strings on create jndi-binding have been updated.

@monkeyherder @BenjaminPerryRoss 

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2711 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #2711: GEODE-5927: enhance create jndi-binding to configure pool

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

Good idea. I will update the unit test

[ Full content available at: https://github.com/apache/geode/pull/2711 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jchen21 commented on pull request #2711: GEODE-5927: enhance create jndi-binding to configure pool

["jchen21 (GitHub)" <gi...@apache.org>]

How about a non-null DataSource?

[ Full content available at: https://github.com/apache/geode/pull/2711 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal closed pull request #2711: GEODE-5927: enhance create jndi-binding to configure pool

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

[ pull request closed by dschneider-pivotal ]

[ Full content available at: https://github.com/apache/geode/pull/2711 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #2711: GEODE-5927: enhance create jndi-binding to configure pool

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

will do

[ Full content available at: https://github.com/apache/geode/pull/2711 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org