You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/24 06:55:27 UTC

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9473: [WIP] Dag Runs CRUD endpoints

ephraimbuddy commented on a change in pull request #9473:
URL: https://github.com/apache/airflow/pull/9473#discussion_r444682662



##########
File path: airflow/api_connexion/endpoints/dag_run_endpoint.py
##########
@@ -70,10 +92,14 @@ def get_dag_runs(session, dag_id, start_date_gte=None, start_date_lte=None,
 
     # filter execution date
     if execution_date_gte:
-        query = query.filter(DagRun.execution_date >= conn_parse_datetime(execution_date_gte))
+        query = query.filter(
+            DagRun.execution_date >= conn_parse_datetime(execution_date_gte)

Review comment:
       It looks to me, conflicts was not resolved well on this endpoint. Can you check the one on master. It uses format_parameters to parse date instead of conn_parse_datetime




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org