You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Joost Schouten (JIRA)" <ji...@apache.org> on 2009/11/28 19:55:20 UTC
[jira] Created: (TAP5-937) LinkImpl does not handle parameters
propery when passed into the constructor
LinkImpl does not handle parameters propery when passed into the constructor
----------------------------------------------------------------------------
Key: TAP5-937
URL: https://issues.apache.org/jira/browse/TAP5-937
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.1
Reporter: Joost Schouten
I noticed this after using the AjaxFormLoop AddRowLink on a page which has an onActivate and onPassivate resulting in the addition of a "t:ac" to the url. Debugging showed me that the t:ac is already present on instantiation of the LinkImpl. When calling toAbsoluteUri the parameters are added in a way where they will always start with a "?". Obvisouly resulting in an invalid URL with two ?'s
I'm building a failing test at this stage and will provide a patch once resolved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-937) LinkImpl does not handle parameters
propery when passed into the constructor
Posted by "Joost Schouten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joost Schouten updated TAP5-937:
--------------------------------
Attachment: parameter_addition_patch.txt
this patch will make sure that added parameters start with a ? when no params are available in the base uri yet, and a & when parameters are already available.
> LinkImpl does not handle parameters propery when passed into the constructor
> ----------------------------------------------------------------------------
>
> Key: TAP5-937
> URL: https://issues.apache.org/jira/browse/TAP5-937
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1
> Reporter: Joost Schouten
> Attachments: parameter_addition_patch.txt
>
>
> I noticed this after using the AjaxFormLoop AddRowLink on a page which has an onActivate and onPassivate resulting in the addition of a "t:ac" to the url. Debugging showed me that the t:ac is already present on instantiation of the LinkImpl. When calling toAbsoluteUri the parameters are added in a way where they will always start with a "?". Obvisouly resulting in an invalid URL with two ?'s
> I'm building a failing test at this stage and will provide a patch once resolved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-937) LinkImpl does not handle parameters
propery when passed into the constructor
Posted by "Joost Schouten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joost Schouten updated TAP5-937:
--------------------------------
Attachment: parameter_addition_patch.txt
patch checks if the baseURI already contains a '?', if so start adding the new params with an '&', otherwise start with a '?'. Also added a test for a situation where a base URI with parameters on the path in instantiated.
> LinkImpl does not handle parameters propery when passed into the constructor
> ----------------------------------------------------------------------------
>
> Key: TAP5-937
> URL: https://issues.apache.org/jira/browse/TAP5-937
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1
> Reporter: Joost Schouten
> Attachments: parameter_addition_patch.txt
>
>
> I noticed this after using the AjaxFormLoop AddRowLink on a page which has an onActivate and onPassivate resulting in the addition of a "t:ac" to the url. Debugging showed me that the t:ac is already present on instantiation of the LinkImpl. When calling toAbsoluteUri the parameters are added in a way where they will always start with a "?". Obvisouly resulting in an invalid URL with two ?'s
> I'm building a failing test at this stage and will provide a patch once resolved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-937) LinkImpl does not handle parameters
properly when passed into the constructor
Posted by "Igor Drobiazko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Drobiazko reassigned TAP5-937:
-----------------------------------
Assignee: Igor Drobiazko
> LinkImpl does not handle parameters properly when passed into the constructor
> -----------------------------------------------------------------------------
>
> Key: TAP5-937
> URL: https://issues.apache.org/jira/browse/TAP5-937
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1
> Reporter: Joost Schouten
> Assignee: Igor Drobiazko
> Fix For: 5.2.0
>
> Attachments: parameter_addition_patch.txt
>
>
> I noticed this after using the AjaxFormLoop AddRowLink on a page which has an onActivate and onPassivate resulting in the addition of a "t:ac" to the url. Debugging showed me that the t:ac is already present on instantiation of the LinkImpl. When calling toAbsoluteUri the parameters are added in a way where they will always start with a "?". Obvisouly resulting in an invalid URL with two ?'s
> I'm building a failing test at this stage and will provide a patch once resolved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-937) LinkImpl does not handle parameters
propery when passed into the constructor
Posted by "Joost Schouten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joost Schouten updated TAP5-937:
--------------------------------
Attachment: parameter_addition_patch.txt
patch checks if the baseURI already contains a '?', if so start adding the new params with an '&', otherwise start with a '?'. Also added a test for a situation where a base URI with parameters on the path in instantiated.
> LinkImpl does not handle parameters propery when passed into the constructor
> ----------------------------------------------------------------------------
>
> Key: TAP5-937
> URL: https://issues.apache.org/jira/browse/TAP5-937
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1
> Reporter: Joost Schouten
> Attachments: parameter_addition_patch.txt
>
>
> I noticed this after using the AjaxFormLoop AddRowLink on a page which has an onActivate and onPassivate resulting in the addition of a "t:ac" to the url. Debugging showed me that the t:ac is already present on instantiation of the LinkImpl. When calling toAbsoluteUri the parameters are added in a way where they will always start with a "?". Obvisouly resulting in an invalid URL with two ?'s
> I'm building a failing test at this stage and will provide a patch once resolved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-937) LinkImpl does not handle parameters
propery when passed into the constructor
Posted by "Joost Schouten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783563#action_12783563 ]
Joost Schouten commented on TAP5-937:
-------------------------------------
The problem only exists when using any UrlRewriteRule, activation context and additional parameters. The t:ac seems to be added to the URL before the UrlRewriting happens, where the AjaxFormLoop parameters seem to be added after the rewriting which results in the buildURI being called twice, causing the double questionmark.
> LinkImpl does not handle parameters propery when passed into the constructor
> ----------------------------------------------------------------------------
>
> Key: TAP5-937
> URL: https://issues.apache.org/jira/browse/TAP5-937
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1
> Reporter: Joost Schouten
> Attachments: parameter_addition_patch.txt
>
>
> I noticed this after using the AjaxFormLoop AddRowLink on a page which has an onActivate and onPassivate resulting in the addition of a "t:ac" to the url. Debugging showed me that the t:ac is already present on instantiation of the LinkImpl. When calling toAbsoluteUri the parameters are added in a way where they will always start with a "?". Obvisouly resulting in an invalid URL with two ?'s
> I'm building a failing test at this stage and will provide a patch once resolved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-937) LinkImpl does not handle parameters
propery when passed into the constructor
Posted by "Joost Schouten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joost Schouten updated TAP5-937:
--------------------------------
Attachment: (was: parameter_addition_patch.txt)
> LinkImpl does not handle parameters propery when passed into the constructor
> ----------------------------------------------------------------------------
>
> Key: TAP5-937
> URL: https://issues.apache.org/jira/browse/TAP5-937
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1
> Reporter: Joost Schouten
>
> I noticed this after using the AjaxFormLoop AddRowLink on a page which has an onActivate and onPassivate resulting in the addition of a "t:ac" to the url. Debugging showed me that the t:ac is already present on instantiation of the LinkImpl. When calling toAbsoluteUri the parameters are added in a way where they will always start with a "?". Obvisouly resulting in an invalid URL with two ?'s
> I'm building a failing test at this stage and will provide a patch once resolved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-937) LinkImpl does not handle parameters
properly when passed into the constructor
Posted by "Igor Drobiazko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Drobiazko updated TAP5-937:
--------------------------------
Summary: LinkImpl does not handle parameters properly when passed into the constructor (was: LinkImpl does not handle parameters propery when passed into the constructor)
> LinkImpl does not handle parameters properly when passed into the constructor
> -----------------------------------------------------------------------------
>
> Key: TAP5-937
> URL: https://issues.apache.org/jira/browse/TAP5-937
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1
> Reporter: Joost Schouten
> Attachments: parameter_addition_patch.txt
>
>
> I noticed this after using the AjaxFormLoop AddRowLink on a page which has an onActivate and onPassivate resulting in the addition of a "t:ac" to the url. Debugging showed me that the t:ac is already present on instantiation of the LinkImpl. When calling toAbsoluteUri the parameters are added in a way where they will always start with a "?". Obvisouly resulting in an invalid URL with two ?'s
> I'm building a failing test at this stage and will provide a patch once resolved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-937) LinkImpl does not handle parameters
propery when passed into the constructor
Posted by "Joost Schouten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783563#action_12783563 ]
Joost Schouten commented on TAP5-937:
-------------------------------------
The problem only exists when using any UrlRewriteRule, activation context and additional parameters. The t:ac seems to be added to the URL before the UrlRewriting happens, where the AjaxFormLoop parameters seem to be added after the rewriting which results in the buildURI being called twice, causing the double questionmark.
> LinkImpl does not handle parameters propery when passed into the constructor
> ----------------------------------------------------------------------------
>
> Key: TAP5-937
> URL: https://issues.apache.org/jira/browse/TAP5-937
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1
> Reporter: Joost Schouten
> Attachments: parameter_addition_patch.txt
>
>
> I noticed this after using the AjaxFormLoop AddRowLink on a page which has an onActivate and onPassivate resulting in the addition of a "t:ac" to the url. Debugging showed me that the t:ac is already present on instantiation of the LinkImpl. When calling toAbsoluteUri the parameters are added in a way where they will always start with a "?". Obvisouly resulting in an invalid URL with two ?'s
> I'm building a failing test at this stage and will provide a patch once resolved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-937) LinkImpl does not handle parameters
propery when passed into the constructor
Posted by "Joost Schouten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joost Schouten updated TAP5-937:
--------------------------------
Attachment: (was: parameter_addition_patch.txt)
> LinkImpl does not handle parameters propery when passed into the constructor
> ----------------------------------------------------------------------------
>
> Key: TAP5-937
> URL: https://issues.apache.org/jira/browse/TAP5-937
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1
> Reporter: Joost Schouten
>
> I noticed this after using the AjaxFormLoop AddRowLink on a page which has an onActivate and onPassivate resulting in the addition of a "t:ac" to the url. Debugging showed me that the t:ac is already present on instantiation of the LinkImpl. When calling toAbsoluteUri the parameters are added in a way where they will always start with a "?". Obvisouly resulting in an invalid URL with two ?'s
> I'm building a failing test at this stage and will provide a patch once resolved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-937) LinkImpl does not handle parameters
properly when passed into the constructor
Posted by "Igor Drobiazko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Drobiazko closed TAP5-937.
-------------------------------
Resolution: Fixed
Fix Version/s: 5.2.0
Thanks.
> LinkImpl does not handle parameters properly when passed into the constructor
> -----------------------------------------------------------------------------
>
> Key: TAP5-937
> URL: https://issues.apache.org/jira/browse/TAP5-937
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1
> Reporter: Joost Schouten
> Assignee: Igor Drobiazko
> Fix For: 5.2.0
>
> Attachments: parameter_addition_patch.txt
>
>
> I noticed this after using the AjaxFormLoop AddRowLink on a page which has an onActivate and onPassivate resulting in the addition of a "t:ac" to the url. Debugging showed me that the t:ac is already present on instantiation of the LinkImpl. When calling toAbsoluteUri the parameters are added in a way where they will always start with a "?". Obvisouly resulting in an invalid URL with two ?'s
> I'm building a failing test at this stage and will provide a patch once resolved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-937) LinkImpl does not handle parameters
properly when passed into the constructor
Posted by "Igor Drobiazko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Drobiazko closed TAP5-937.
-------------------------------
Resolution: Fixed
Fix Version/s: 5.2.0
Thanks.
> LinkImpl does not handle parameters properly when passed into the constructor
> -----------------------------------------------------------------------------
>
> Key: TAP5-937
> URL: https://issues.apache.org/jira/browse/TAP5-937
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1
> Reporter: Joost Schouten
> Assignee: Igor Drobiazko
> Fix For: 5.2.0
>
> Attachments: parameter_addition_patch.txt
>
>
> I noticed this after using the AjaxFormLoop AddRowLink on a page which has an onActivate and onPassivate resulting in the addition of a "t:ac" to the url. Debugging showed me that the t:ac is already present on instantiation of the LinkImpl. When calling toAbsoluteUri the parameters are added in a way where they will always start with a "?". Obvisouly resulting in an invalid URL with two ?'s
> I'm building a failing test at this stage and will provide a patch once resolved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-937) LinkImpl does not handle parameters
properly when passed into the constructor
Posted by "Igor Drobiazko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Drobiazko reassigned TAP5-937:
-----------------------------------
Assignee: Igor Drobiazko
> LinkImpl does not handle parameters properly when passed into the constructor
> -----------------------------------------------------------------------------
>
> Key: TAP5-937
> URL: https://issues.apache.org/jira/browse/TAP5-937
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1
> Reporter: Joost Schouten
> Assignee: Igor Drobiazko
> Fix For: 5.2.0
>
> Attachments: parameter_addition_patch.txt
>
>
> I noticed this after using the AjaxFormLoop AddRowLink on a page which has an onActivate and onPassivate resulting in the addition of a "t:ac" to the url. Debugging showed me that the t:ac is already present on instantiation of the LinkImpl. When calling toAbsoluteUri the parameters are added in a way where they will always start with a "?". Obvisouly resulting in an invalid URL with two ?'s
> I'm building a failing test at this stage and will provide a patch once resolved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-937) LinkImpl does not handle parameters
propery when passed into the constructor
Posted by "Joost Schouten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joost Schouten updated TAP5-937:
--------------------------------
Attachment: parameter_addition_patch.txt
this patch will make sure that added parameters start with a ? when no params are available in the base uri yet, and a & when parameters are already available.
> LinkImpl does not handle parameters propery when passed into the constructor
> ----------------------------------------------------------------------------
>
> Key: TAP5-937
> URL: https://issues.apache.org/jira/browse/TAP5-937
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1
> Reporter: Joost Schouten
> Attachments: parameter_addition_patch.txt
>
>
> I noticed this after using the AjaxFormLoop AddRowLink on a page which has an onActivate and onPassivate resulting in the addition of a "t:ac" to the url. Debugging showed me that the t:ac is already present on instantiation of the LinkImpl. When calling toAbsoluteUri the parameters are added in a way where they will always start with a "?". Obvisouly resulting in an invalid URL with two ?'s
> I'm building a failing test at this stage and will provide a patch once resolved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-937) LinkImpl does not handle parameters
properly when passed into the constructor
Posted by "Igor Drobiazko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Drobiazko updated TAP5-937:
--------------------------------
Summary: LinkImpl does not handle parameters properly when passed into the constructor (was: LinkImpl does not handle parameters propery when passed into the constructor)
> LinkImpl does not handle parameters properly when passed into the constructor
> -----------------------------------------------------------------------------
>
> Key: TAP5-937
> URL: https://issues.apache.org/jira/browse/TAP5-937
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1
> Reporter: Joost Schouten
> Attachments: parameter_addition_patch.txt
>
>
> I noticed this after using the AjaxFormLoop AddRowLink on a page which has an onActivate and onPassivate resulting in the addition of a "t:ac" to the url. Debugging showed me that the t:ac is already present on instantiation of the LinkImpl. When calling toAbsoluteUri the parameters are added in a way where they will always start with a "?". Obvisouly resulting in an invalid URL with two ?'s
> I'm building a failing test at this stage and will provide a patch once resolved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.