[GitHub] [incubator-dubbo] khanimteyaz commented on pull request #3141: optimize outbound event

["khanimteyaz (GitHub)" <gi...@apache.org>]

Should we refactore this by extrating to a method to make it reusable and more readable e.g. 

```
handler.received(channel,buildErrorResponse((Request)msg);

private static Response buildErrorResponse(Request request) {
   Response response = new Response(request.getId(), request.getVersion());
   response.setStatus(Response.BAD_REQUEST);
   response.setErrorMessage(StringUtils.toString(t));
   return response;
}
```

Is the something do you feel should be good ?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3141 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org