You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "anjakefala (via GitHub)" <gi...@apache.org> on 2023/09/21 22:15:30 UTC
[GitHub] [arrow] anjakefala commented on a diff in pull request #34616: GH-29238 [C++][Dataset][Parquet] Support parquet modular encryption in the new Dataset API
anjakefala commented on code in PR #34616:
URL: https://github.com/apache/arrow/pull/34616#discussion_r1333651503
##########
python/pyarrow/_parquet_encryption.pxd:
##########
@@ -131,3 +131,22 @@ cdef extern from "arrow/python/parquet_encryption.h" \
SafeGetFileDecryptionProperties(
const CKmsConnectionConfig& kms_connection_config,
const CDecryptionConfiguration& decryption_config)
+
+cdef extern from "arrow/dataset/parquet_encryption_config.h" namespace "arrow::dataset" nogil:
+ cdef cppclass CParquetEncryptionConfig "arrow::dataset::ParquetEncryptionConfig":
+ CParquetEncryptionConfig() except +
Review Comment:
It seems this is true!
> Note that, like C++, if the class has only one constructor and it is a nullary one, it’s not necessary to declare it.
##########
python/pyarrow/_parquet_encryption.pxd:
##########
@@ -131,3 +131,22 @@ cdef extern from "arrow/python/parquet_encryption.h" \
SafeGetFileDecryptionProperties(
const CKmsConnectionConfig& kms_connection_config,
const CDecryptionConfiguration& decryption_config)
+
+cdef extern from "arrow/dataset/parquet_encryption_config.h" namespace "arrow::dataset" nogil:
+ cdef cppclass CParquetEncryptionConfig "arrow::dataset::ParquetEncryptionConfig":
+ CParquetEncryptionConfig() except +
Review Comment:
It seems this is true!
> Note that, like C++, if the class has only one constructor and it is a nullary one, it’s not necessary to declare it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org