You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/02/09 17:11:54 UTC
[GitHub] [ozone] adoroszlai opened a new pull request #3064: HDDS-6291. Do not let slf4j-log4j12 leak into Ozone FS shaded jar
adoroszlai opened a new pull request #3064:
URL: https://github.com/apache/ozone/pull/3064
## What changes were proposed in this pull request?
`slf4j-log4j12` was accidentally introduced as compile-time dependency for `ozone-client` in 9644f83c0. This made it leak into the Ozone FS shaded jars:
```
[INFO] Including org.slf4j:slf4j-log4j12:jar:1.7.30 in the shaded jar.
```
https://github.com/apache/ozone/runs/4756057859#step:6:2442
This PR has the following changes:
* Exclude all `org.slf4j` artifacts from Ozone FS shaded jar (just in case).
* Restore scope of dependency on `slf4j-log4j12` to `test` in `ozone-client`.
https://issues.apache.org/jira/browse/HDDS-6291
## How was this patch tested?
Tested the effect of exclusion separately. Verified that the dependency is excluded from the shaded jar. Then restored `test` scope.
https://github.com/adoroszlai/hadoop-ozone/runs/5128091580#step:6:7386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3064: HDDS-6291. Do not let slf4j-log4j12 leak into Ozone FS shaded jar
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #3064:
URL: https://github.com/apache/ozone/pull/3064#issuecomment-1034647338
Thanks @jojochuang for the review and the example script. I have filed HDDS-6297 for a new check based on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jojochuang commented on pull request #3064: HDDS-6291. Do not let slf4j-log4j12 leak into Ozone FS shaded jar
Posted by GitBox <gi...@apache.org>.
jojochuang commented on pull request #3064:
URL: https://github.com/apache/ozone/pull/3064#issuecomment-1034273762
What Hadoop and HBase does is have a shell script which inspects the classes included in the shaded jar, and abort when an unexpected classpath prefix is found. https://github.com/apache/hadoop/blob/f608cda72976d62354e063472d9b985eed48ebae/hadoop-client-modules/hadoop-client-check-test-invariants/src/test/resources/ensure-jars-have-correct-contents.sh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3064: HDDS-6291. Do not let slf4j-log4j12 leak into Ozone FS shaded jar
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #3064:
URL: https://github.com/apache/ozone/pull/3064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3064: HDDS-6291. Do not let slf4j-log4j12 leak into Ozone FS shaded jar
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #3064:
URL: https://github.com/apache/ozone/pull/3064#issuecomment-1034261532
Thanks @jojochuang for the review.
> On a side note, how did you find this out?
It was reported by downstream user.
> It would be great to break the build in the future if something unintended gets in the classpath.
Added a Robot test assertion for this specific `multiple SLF4J bindings` problem, verifying the output of `hdfs`/`yarn` commands. For a more generic solution, would it make sense to compare the jars included by shade plugin against list of known dependencies?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org