[GitHub] [pinot] richardstartin commented on a change in pull request #7610: Stringutil cleanup

[GitBox <gi...@apache.org>]

richardstartin commented on a change in pull request #7610:
URL: https://github.com/apache/pinot/pull/7610#discussion_r733778834



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/utils/StringUtil.java
##########
@@ -28,7 +27,6 @@ private StringUtil() {
   }

Review comment:
       I'm not sure/ Why would you put this in an SPI (service provider interface)? It doesn't provide a service, there is no value in overriding it. It only exists to sanitise strings in a couple of places in pinot-core, and to provide a convenience layer around apache commons `StringUtils.join`. I would reserve SPIs for real service providers, e.g. allow to swap out storage, indexes and so on.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org