You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gaurav Nagar <gn...@hortonworks.com> on 2016/01/28 12:53:01 UTC
Review Request 42906: HiveViews: Value in cell coming up as null for
select query
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42906/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Rohit Choudhary, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-14827
https://issues.apache.org/jira/browse/AMBARI-14827
Repository: ambari
Description
-------
Added null check for cell value. If the value is null don't add String value.
Diffs
-----
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/ResultsPaginationController.java 84dec4d
Diff: https://reviews.apache.org/r/42906/diff/
Testing
-------
Manual Testing.
Output of mvn clean install
-------------------------------------------------------
T E S T S
-------------------------------------------------------
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.ambari.view.hive.backgroundjobs.BackgroundJobControllerTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.475 sec
Running org.apache.ambari.view.hive.client.ConnectionTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.362 sec
Running org.apache.ambari.view.hive.client.UtilsTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.291 sec
Running org.apache.ambari.view.hive.PropertyValidatorTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.154 sec
Running org.apache.ambari.view.hive.resources.files.FileServiceTest
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.568 sec
Running org.apache.ambari.view.hive.resources.jobs.AggregatorTest
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.257 sec
Running org.apache.ambari.view.hive.resources.jobs.ATSParserTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.206 sec
Running org.apache.ambari.view.hive.resources.jobs.JobLDAPServiceTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.921 sec
Running org.apache.ambari.view.hive.resources.jobs.JobServiceTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.941 sec
Running org.apache.ambari.view.hive.resources.jobs.LogParserTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.076 sec
Running org.apache.ambari.view.hive.resources.resources.FileResourceServiceTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.623 sec
Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryResourceManagerTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.144 sec
Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryServiceTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.982 sec
Running org.apache.ambari.view.hive.resources.udfs.UDFServiceTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.666 sec
Running org.apache.ambari.view.hive.resources.upload.DataParserTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.107 sec
Results :
Tests run: 62, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Gaurav Nagar
Re: Review Request 42906: HiveViews: Value in cell coming up as null
for select query
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42906/#review120155
-----------------------------------------------------------
Ship it!
Ship It!
- DIPAYAN BHOWMICK
On Feb. 9, 2016, 9:47 a.m., Gaurav Nagar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42906/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 9:47 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Rohit Choudhary, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-14827
> https://issues.apache.org/jira/browse/AMBARI-14827
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added null check for cell value. If the value is null don't add String value.
>
>
> Diffs
> -----
>
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/ResultsPaginationController.java 84dec4d
>
> Diff: https://reviews.apache.org/r/42906/diff/
>
>
> Testing
> -------
>
> Manual Testing.
>
> Output of mvn clean install
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.ambari.view.hive.backgroundjobs.BackgroundJobControllerTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.475 sec
> Running org.apache.ambari.view.hive.client.ConnectionTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.362 sec
> Running org.apache.ambari.view.hive.client.UtilsTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.291 sec
> Running org.apache.ambari.view.hive.PropertyValidatorTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.154 sec
> Running org.apache.ambari.view.hive.resources.files.FileServiceTest
> Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.568 sec
> Running org.apache.ambari.view.hive.resources.jobs.AggregatorTest
> Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.257 sec
> Running org.apache.ambari.view.hive.resources.jobs.ATSParserTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.206 sec
> Running org.apache.ambari.view.hive.resources.jobs.JobLDAPServiceTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.921 sec
> Running org.apache.ambari.view.hive.resources.jobs.JobServiceTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.941 sec
> Running org.apache.ambari.view.hive.resources.jobs.LogParserTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.076 sec
> Running org.apache.ambari.view.hive.resources.resources.FileResourceServiceTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.623 sec
> Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryResourceManagerTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.144 sec
> Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryServiceTest
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.982 sec
> Running org.apache.ambari.view.hive.resources.udfs.UDFServiceTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.666 sec
> Running org.apache.ambari.view.hive.resources.upload.DataParserTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.107 sec
>
> Results :
>
> Tests run: 62, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Gaurav Nagar
>
>
Re: Review Request 42906: HiveViews: Value in cell coming up as null
for select query
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42906/#review120168
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Feb. 9, 2016, 9:47 a.m., Gaurav Nagar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42906/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 9:47 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Rohit Choudhary, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-14827
> https://issues.apache.org/jira/browse/AMBARI-14827
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added null check for cell value. If the value is null don't add String value.
>
>
> Diffs
> -----
>
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/ResultsPaginationController.java 84dec4d
>
> Diff: https://reviews.apache.org/r/42906/diff/
>
>
> Testing
> -------
>
> Manual Testing.
>
> Output of mvn clean install
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.ambari.view.hive.backgroundjobs.BackgroundJobControllerTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.475 sec
> Running org.apache.ambari.view.hive.client.ConnectionTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.362 sec
> Running org.apache.ambari.view.hive.client.UtilsTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.291 sec
> Running org.apache.ambari.view.hive.PropertyValidatorTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.154 sec
> Running org.apache.ambari.view.hive.resources.files.FileServiceTest
> Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.568 sec
> Running org.apache.ambari.view.hive.resources.jobs.AggregatorTest
> Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.257 sec
> Running org.apache.ambari.view.hive.resources.jobs.ATSParserTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.206 sec
> Running org.apache.ambari.view.hive.resources.jobs.JobLDAPServiceTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.921 sec
> Running org.apache.ambari.view.hive.resources.jobs.JobServiceTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.941 sec
> Running org.apache.ambari.view.hive.resources.jobs.LogParserTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.076 sec
> Running org.apache.ambari.view.hive.resources.resources.FileResourceServiceTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.623 sec
> Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryResourceManagerTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.144 sec
> Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryServiceTest
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.982 sec
> Running org.apache.ambari.view.hive.resources.udfs.UDFServiceTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.666 sec
> Running org.apache.ambari.view.hive.resources.upload.DataParserTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.107 sec
>
> Results :
>
> Tests run: 62, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Gaurav Nagar
>
>
Re: Review Request 42906: HiveViews: Value in cell coming up as null
for select query
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42906/
-----------------------------------------------------------
(Updated Feb. 9, 2016, 9:47 a.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Rohit Choudhary, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
Changes
-------
Handled null,empty and null value string in following way:
empty string - ""
null - null
string with value null - "null"
Bugs: AMBARI-14827
https://issues.apache.org/jira/browse/AMBARI-14827
Repository: ambari
Description
-------
Added null check for cell value. If the value is null don't add String value.
Diffs (updated)
-----
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/ResultsPaginationController.java 84dec4d
Diff: https://reviews.apache.org/r/42906/diff/
Testing
-------
Manual Testing.
Output of mvn clean install
-------------------------------------------------------
T E S T S
-------------------------------------------------------
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.ambari.view.hive.backgroundjobs.BackgroundJobControllerTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.475 sec
Running org.apache.ambari.view.hive.client.ConnectionTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.362 sec
Running org.apache.ambari.view.hive.client.UtilsTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.291 sec
Running org.apache.ambari.view.hive.PropertyValidatorTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.154 sec
Running org.apache.ambari.view.hive.resources.files.FileServiceTest
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.568 sec
Running org.apache.ambari.view.hive.resources.jobs.AggregatorTest
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.257 sec
Running org.apache.ambari.view.hive.resources.jobs.ATSParserTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.206 sec
Running org.apache.ambari.view.hive.resources.jobs.JobLDAPServiceTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.921 sec
Running org.apache.ambari.view.hive.resources.jobs.JobServiceTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.941 sec
Running org.apache.ambari.view.hive.resources.jobs.LogParserTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.076 sec
Running org.apache.ambari.view.hive.resources.resources.FileResourceServiceTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.623 sec
Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryResourceManagerTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.144 sec
Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryServiceTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.982 sec
Running org.apache.ambari.view.hive.resources.udfs.UDFServiceTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.666 sec
Running org.apache.ambari.view.hive.resources.upload.DataParserTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.107 sec
Results :
Tests run: 62, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Gaurav Nagar