You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "LZD-PratyushBhatt (via GitHub)" <gi...@apache.org> on 2023/10/13 05:50:07 UTC
[PR] HDDS-9437 : Intermittent failure in test-scm-decommission [ozone]
LZD-PratyushBhatt opened a new pull request, #5436:
URL: https://github.com/apache/ozone/pull/5436
## What changes were proposed in this pull request?
The robot test currently was decommissioning the scm node that we were running the tests from. Hence the tests were abruptly stopping without any Pass/Fail message.
Changing the exec container to s3g to prevent this.
## What is the link to the Apache JIRA
[HDDS-9437](https://issues.apache.org/jira/browse/HDDS-9437)
## How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9437 : Intermittent failure in test-scm-decommission [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #5436:
URL: https://github.com/apache/ozone/pull/5436#discussion_r1357828332
##########
hadoop-ozone/dist/src/main/compose/ozonesecure-ha/test-scm-decommission.sh:
##########
@@ -47,4 +47,4 @@ SCMID=$(execute_command_in_container scm4.org bash -c "ozone admin scm roles" |
docker-compose stop scm4.org
execute_robot_test scm3.org kinit.robot
wait_for_execute_command scm3.org 60 "ozone admin scm decommission --nodeid=${SCMID} | grep Decommissioned"
Review Comment:
I'm guessing `kinit` is required for the commands in `scm-decommission.robot`, too. Either all 3 steps should be executed on `s3g`, or better yet, `Kinit` test setup step should be added to `scm-decommission.robot` like this:
https://github.com/apache/ozone/blob/2af0e64675aaad616cff1952eb0b6c5c12ceea21/hadoop-ozone/dist/src/main/smoketest/omha/om-fetch-key.robot#L21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9437 : Intermittent failure in test-scm-decommission [ozone]
Posted by "LZD-PratyushBhatt (via GitHub)" <gi...@apache.org>.
LZD-PratyushBhatt commented on code in PR #5436:
URL: https://github.com/apache/ozone/pull/5436#discussion_r1357886074
##########
hadoop-ozone/dist/src/main/compose/ozonesecure-ha/test-scm-decommission.sh:
##########
@@ -47,4 +47,4 @@ SCMID=$(execute_command_in_container scm4.org bash -c "ozone admin scm roles" |
docker-compose stop scm4.org
execute_robot_test scm3.org kinit.robot
wait_for_execute_command scm3.org 60 "ozone admin scm decommission --nodeid=${SCMID} | grep Decommissioned"
Review Comment:
Updated the PR. Tested locally on s3g, works fine.
```
export SECURITY_ENABLED=true
❯ ../test-single.sh s3g scmha/scm-decommission.robot
==============================================================================
Scm-Decommission :: Test Ozone SCM Decommissioning
==============================================================================
Decommission SCM Primordial Node | PASS |
------------------------------------------------------------------------------
Scm-Decommission :: Test Ozone SCM Decommissioning | PASS |
1 test, 1 passed, 0 failed
==============================================================================
```
##########
hadoop-ozone/dist/src/main/compose/ozonesecure-ha/test-scm-decommission.sh:
##########
@@ -47,4 +47,4 @@ SCMID=$(execute_command_in_container scm4.org bash -c "ozone admin scm roles" |
docker-compose stop scm4.org
execute_robot_test scm3.org kinit.robot
wait_for_execute_command scm3.org 60 "ozone admin scm decommission --nodeid=${SCMID} | grep Decommissioned"
Review Comment:
Updated the PR. Tested locally on s3g, works fine.
```
export SECURITY_ENABLED=true
❯ ../test-single.sh s3g scmha/scm-decommission.robot
==============================================================================
Scm-Decommission :: Test Ozone SCM Decommissioning
==============================================================================
Decommission SCM Primordial Node | PASS |
------------------------------------------------------------------------------
Scm-Decommission :: Test Ozone SCM Decommissioning | PASS |
1 test, 1 passed, 0 failed
==============================================================================
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9437. Intermittent failure in test-scm-decommission [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5436:
URL: https://github.com/apache/ozone/pull/5436#issuecomment-1761718428
Thanks @LZD-PratyushBhatt for the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9437 : Intermittent failure in test-scm-decommission [ozone]
Posted by "LZD-PratyushBhatt (via GitHub)" <gi...@apache.org>.
LZD-PratyushBhatt commented on code in PR #5436:
URL: https://github.com/apache/ozone/pull/5436#discussion_r1357886669
##########
hadoop-ozone/dist/src/main/compose/ozonesecure-ha/test-scm-decommission.sh:
##########
@@ -47,4 +47,4 @@ SCMID=$(execute_command_in_container scm4.org bash -c "ozone admin scm roles" |
docker-compose stop scm4.org
execute_robot_test scm3.org kinit.robot
wait_for_execute_command scm3.org 60 "ozone admin scm decommission --nodeid=${SCMID} | grep Decommissioned"
Review Comment:
Started new CI runs on my fork, cancelled old ones. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9437 : Intermittent failure in test-scm-decommission [ozone]
Posted by "LZD-PratyushBhatt (via GitHub)" <gi...@apache.org>.
LZD-PratyushBhatt commented on code in PR #5436:
URL: https://github.com/apache/ozone/pull/5436#discussion_r1358004537
##########
hadoop-ozone/dist/src/main/compose/ozonesecure-ha/test-scm-decommission.sh:
##########
@@ -47,4 +47,4 @@ SCMID=$(execute_command_in_container scm4.org bash -c "ozone admin scm roles" |
docker-compose stop scm4.org
execute_robot_test scm3.org kinit.robot
wait_for_execute_command scm3.org 60 "ozone admin scm decommission --nodeid=${SCMID} | grep Decommissioned"
Review Comment:
CI Passed: https://github.com/LZD-PratyushBhatt/ozone/actions/runs/6505325429/job/17669363810?pr=8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9437 : Intermittent failure in test-scm-decommission [ozone]
Posted by "LZD-PratyushBhatt (via GitHub)" <gi...@apache.org>.
LZD-PratyushBhatt commented on code in PR #5436:
URL: https://github.com/apache/ozone/pull/5436#discussion_r1358005068
##########
hadoop-ozone/dist/src/main/compose/ozonesecure-ha/test-scm-decommission.sh:
##########
@@ -47,4 +47,4 @@ SCMID=$(execute_command_in_container scm4.org bash -c "ozone admin scm roles" |
docker-compose stop scm4.org
execute_robot_test scm3.org kinit.robot
wait_for_execute_command scm3.org 60 "ozone admin scm decommission --nodeid=${SCMID} | grep Decommissioned"
Review Comment:
@adoroszlai can you please review again? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9437. Intermittent failure in test-scm-decommission [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #5436:
URL: https://github.com/apache/ozone/pull/5436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9437 : Intermittent failure in test-scm-decommission [ozone]
Posted by "LZD-PratyushBhatt (via GitHub)" <gi...@apache.org>.
LZD-PratyushBhatt commented on code in PR #5436:
URL: https://github.com/apache/ozone/pull/5436#discussion_r1357868474
##########
hadoop-ozone/dist/src/main/compose/ozonesecure-ha/test-scm-decommission.sh:
##########
@@ -47,4 +47,4 @@ SCMID=$(execute_command_in_container scm4.org bash -c "ozone admin scm roles" |
docker-compose stop scm4.org
execute_robot_test scm3.org kinit.robot
wait_for_execute_command scm3.org 60 "ozone admin scm decommission --nodeid=${SCMID} | grep Decommissioned"
Review Comment:
Sorry, my bad, missed this one.
Updating the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org