[GitHub] [skywalking-rover] wu-sheng commented on a diff in pull request #16: Add Kubernetes process detector support

[GitBox <gi...@apache.org>]

wu-sheng commented on code in PR #16:
URL: https://github.com/apache/skywalking-rover/pull/16#discussion_r857616623


##########
configs/rover_configs.yaml:
##########
@@ -64,6 +64,37 @@ process_discovery:
         # The Process Labels, used to aggregate similar process from service entity
         # Multiple labels split by ","
         labels: ${ROVER_PROCESS_DISCOVERY_REGEX_SCANNER_LABELS:}
+  kubernetes:
+    # Is active the kubernetes process detector
+    active: ${ROVER_PROCESS_DISCOVERY_KUBERNETES_ACTIVE:false}
+    # Current node name in kubernetes environment
+    node_name: ${ROVER_PROCESS_DISCOVERY_KUBERNETES_NODE_NAME:}
+    # include namespaces, multiple namespace split by ",", if empty means including all namespaces
+    namespaces: ${ROVER_PROCESS_DISCOVERY_KUBERNETES_NAMESPACES:}
+    # Activated process analyze features
+    activated: ${ROVER_PROCESS_DISCOVERY_KUBERNETES_ACTIVATED:mesh,k8s}
+    # Customized the cluster name

Review Comment:
   `active` V.S. `activated`, these would be super confusing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org