[jira] [Commented] (MINIFI-254) Update codebase to C++ Linter standards

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFI-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954462#comment-15954462 ] 

ASF GitHub Bot commented on MINIFI-254:
---------------------------------------

GitHub user phrocker opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/73

    MINIFI-254: Incremental update for linter changes

    This particular commit reduces the number < 200. 
    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFI-254

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/73.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #73
    
----
commit 2717886b316af480912e4a50192899e570c28356
Author: Marc Parisi <ph...@apache.org>
Date:   2017-04-03T20:27:24Z

    MINIFI-254: Incremental update for linter changes

----


> Update codebase to C++ Linter standards
> ---------------------------------------
>
>                 Key: MINIFI-254
>                 URL: https://issues.apache.org/jira/browse/MINIFI-254
>             Project: Apache NiFi MiNiFi
>          Issue Type: Task
>          Components: Build
>            Reporter: Aldrin Piri
>
> An onerous task not for the faint of heart. Embark at your own peril.
> MINIFI-225 established a linter for use on inspecting the codebase as a target of the build.  To derive greater value from this and make it a mandatory and automated part of our build/review process we need to get the current state of  the codebase passing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)