You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/07/05 18:22:15 UTC
[GitHub] [trafficcontrol] rob05c commented on a change in pull request
#3713: Refactor deliveryservice API minor versioning
rob05c commented on a change in pull request #3713: Refactor deliveryservice API minor versioning
URL: https://github.com/apache/trafficcontrol/pull/3713#discussion_r300747526
##########
File path: traffic_ops/traffic_ops_golang/api/api.go
##########
@@ -379,6 +382,37 @@ func (val APIInfoImpl) APIInfo() *APIInfo {
return val.ReqInfo
}
+type Version struct {
+ Major uint64
+ Minor uint64
+}
+
+// getRequestedAPIVersion returns a pointer to the requested API Version from the request if it exists, otherwise nil
Review comment:
Nitpick: symbol comments should be full sentences, should end in a period.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services