[jira] [Created] (ZOOKEEPER-2804) Node creation fails with NPE if ACLs are null

["Bhupendra Kumar Jain (JIRA)" <ji...@apache.org>]

Bhupendra Kumar Jain created ZOOKEEPER-2804:
-----------------------------------------------

             Summary: Node creation fails with NPE if ACLs are null
                 Key: ZOOKEEPER-2804
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2804
             Project: ZooKeeper
          Issue Type: Bug
            Reporter: Bhupendra Kumar Jain


If null ACLs are passed then zk node creation fails with NPE
{code}
java.lang.NullPointerException
	at org.apache.zookeeper.server.PrepRequestProcessor.removeDuplicates(PrepRequestProcessor.java:1301)
	at org.apache.zookeeper.server.PrepRequestProcessor.fixupACL(PrepRequestProcessor.java:1341)
	at org.apache.zookeeper.server.PrepRequestProcessor.pRequest2Txn(PrepRequestProcessor.java:519)
	at org.apache.zookeeper.server.PrepRequestProcessor.pRequest(PrepRequestProcessor.java:1126)
	at org.apache.zookeeper.server.PrepRequestProcessor.run(PrepRequestProcessor.java:178)
{code}

Below APIs have problem.
{code}
public void create(final String path, byte data[], List<ACL> acl,
            CreateMode createMode, StringCallback cb, Object ctx)

public void create(final String path, byte data[], List<ACL> acl,
            CreateMode createMode, Create2Callback cb, Object ctx)
{code}

Solution: 
a)  Need to handle NULL ACLs in removeDuplicates method in server.  
b) Also add the client side validation for null / empty ACL for above API similar to other create API



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)