You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by sv...@apache.org on 2014/04/05 10:15:42 UTC
git commit: use generic parameter for #onSelectionChanged();
added reference to #wantOnSelectionChangedNotifications in javadoc
Repository: wicket
Updated Branches:
refs/heads/master f1af9e038 -> 1426abb90
use generic parameter for #onSelectionChanged(); added reference
to #wantOnSelectionChangedNotifications in javadoc
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/1426abb9
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/1426abb9
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/1426abb9
Branch: refs/heads/master
Commit: 1426abb909b542b4a283690454884a83fbbc50f7
Parents: f1af9e0
Author: svenmeier <sv...@meiers.net>
Authored: Sat Apr 5 10:15:19 2014 +0200
Committer: svenmeier <sv...@meiers.net>
Committed: Sat Apr 5 10:15:19 2014 +0200
----------------------------------------------------------------------
.../main/java/org/apache/wicket/markup/html/form/CheckBox.java | 1 +
.../java/org/apache/wicket/markup/html/form/CheckGroup.java | 2 ++
.../org/apache/wicket/markup/html/form/DropDownChoice.java | 5 +++--
.../java/org/apache/wicket/markup/html/form/RadioChoice.java | 5 +++--
.../java/org/apache/wicket/markup/html/form/RadioGroup.java | 6 ++++--
5 files changed, 13 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/1426abb9/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckBox.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckBox.java b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckBox.java
index cacd548..310ccc9 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckBox.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckBox.java
@@ -95,6 +95,7 @@ public class CheckBox extends FormComponent<Boolean> implements IOnChangeListene
* @param newSelection
* The newly selected object of the backing model NOTE this is the same as you would
* get by calling getModelObject() if the new selection were current
+ * @see #wantOnSelectionChangedNotifications()
*/
protected void onSelectionChanged(Boolean newSelection)
{
http://git-wip-us.apache.org/repos/asf/wicket/blob/1426abb9/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckGroup.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckGroup.java b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckGroup.java
index 8c85867..cec0f48 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckGroup.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckGroup.java
@@ -222,6 +222,8 @@ public class CheckGroup<T> extends FormComponent<Collection<T>> implements IOnCh
* @param newSelection
* The new selection of the {@link CheckGroup}. NOTE this is the same as you would
* get by calling getModelObject() if the new selection were current
+ *
+ * @see #wantOnSelectionChangedNotifications()
*/
protected void onSelectionChanged(final Collection<? extends T> newSelection)
{
http://git-wip-us.apache.org/repos/asf/wicket/blob/1426abb9/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
index fe5d977..e6ec9ca 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
@@ -19,10 +19,10 @@ package org.apache.wicket.markup.html.form;
import java.util.List;
import org.apache.wicket.ajax.form.AjaxFormComponentUpdatingBehavior;
-import org.apache.wicket.markup.ComponentTag;
-import org.apache.wicket.model.IModel;
import org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler;
import org.apache.wicket.core.request.handler.PageAndComponentProvider;
+import org.apache.wicket.markup.ComponentTag;
+import org.apache.wicket.model.IModel;
import org.apache.wicket.request.mapper.parameter.PageParameters;
@@ -263,6 +263,7 @@ public class DropDownChoice<T> extends AbstractSingleSelectChoice<T> implements
* @param newSelection
* The newly selected object of the backing model NOTE this is the same as you would
* get by calling getModelObject() if the new selection were current
+ * @see #wantOnSelectionChangedNotifications()
*/
protected void onSelectionChanged(final T newSelection)
{
http://git-wip-us.apache.org/repos/asf/wicket/blob/1426abb9/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioChoice.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioChoice.java b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioChoice.java
index 73720a2..3078729 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioChoice.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioChoice.java
@@ -248,7 +248,7 @@ public class RadioChoice<T> extends AbstractSingleSelectChoice<T> implements IOn
{
convertInput();
updateModel();
- onSelectionChanged(getDefaultModelObject());
+ onSelectionChanged(getModelObject());
}
/**
@@ -261,8 +261,9 @@ public class RadioChoice<T> extends AbstractSingleSelectChoice<T> implements IOn
* @param newSelection
* The newly selected object of the backing model NOTE this is the same as you would
* get by calling getModelObject() if the new selection were current
+ * @see #wantOnSelectionChangedNotifications()
*/
- protected void onSelectionChanged(Object newSelection)
+ protected void onSelectionChanged(T newSelection)
{
}
http://git-wip-us.apache.org/repos/asf/wicket/blob/1426abb9/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioGroup.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioGroup.java b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioGroup.java
index b577615..4bcccd6 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioGroup.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioGroup.java
@@ -176,7 +176,7 @@ public class RadioGroup<T> extends FormComponent<T> implements IOnChangeListener
{
convertInput();
updateModel();
- onSelectionChanged(getDefaultModelObject());
+ onSelectionChanged(getModelObject());
}
/**
@@ -189,8 +189,10 @@ public class RadioGroup<T> extends FormComponent<T> implements IOnChangeListener
* @param newSelection
* The newly selected object of the backing model NOTE this is the same as you would
* get by calling getModelObject() if the new selection were current
+ *
+ * @see #wantOnSelectionChangedNotifications()
*/
- protected void onSelectionChanged(final Object newSelection)
+ protected void onSelectionChanged(final T newSelection)
{
}
}