You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Lily Chen <li...@mesosphere.io> on 2015/08/15 02:48:20 UTC
Review Request 37496: Move docker provisioner local store into
dedicated folders.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37496/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Move docker provisioner local store into dedicated folders.
Diffs
-----
src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24
src/slave/containerizer/provisioners/docker/local_store.hpp PRE-CREATION
src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION
src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37496/diff/
Testing
-------
sudo make check
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 --gtest_shuffle=1
Thanks,
Lily Chen
Re: Review Request 37496: Move docker provisioner local store into
dedicated folders.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37496/#review96554
-----------------------------------------------------------
At this point I partially stopped re-raising previously raised issues -- please make sure you are globally fixing things I mentioned in earlier reviews within this chain.
src/Makefile.am (lines 755 - 759)
<https://reviews.apache.org/r/37496/#comment152046>
Spaces vs. hard-tabs!
src/slave/containerizer/provisioners/docker/local_store.hpp (line 34)
<https://reviews.apache.org/r/37496/#comment152047>
Kill this blank line please.
src/slave/containerizer/provisioners/docker/local_store.hpp (lines 57 - 59)
<https://reviews.apache.org/r/37496/#comment152048>
As mentioned before, not sure we should use doxygen on these attribute comments.
- Till Toenshoff
On Aug. 25, 2015, 9:02 p.m., Lily Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37496/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 9:02 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-2849
> https://issues.apache.org/jira/browse/MESOS-2849
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Move docker provisioner local store into dedicated folders.
>
>
> Diffs
> -----
>
> src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab
> src/slave/containerizer/provisioners/docker/local_store.hpp PRE-CREATION
> src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION
> src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37496/diff/
>
>
> Testing
> -------
>
> sudo make check
> ./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 --gtest_shuffle=1
>
>
> Thanks,
>
> Lily Chen
>
>
Re: Review Request 37496: Move docker provisioner local store into
dedicated folders.
Posted by Lily Chen <li...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37496/
-----------------------------------------------------------
(Updated Aug. 25, 2015, 9:02 p.m.)
Review request for mesos and Timothy Chen.
Changes
-------
Rebased on master.
Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849
Repository: mesos
Description
-------
Move docker provisioner local store into dedicated folders.
Diffs (updated)
-----
src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab
src/slave/containerizer/provisioners/docker/local_store.hpp PRE-CREATION
src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION
src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37496/diff/
Testing
-------
sudo make check
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 --gtest_shuffle=1
Thanks,
Lily Chen
Re: Review Request 37496: Move docker provisioner local store into
dedicated folders.
Posted by Lily Chen <li...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37496/
-----------------------------------------------------------
(Updated Aug. 25, 2015, 6:50 p.m.)
Review request for mesos and Timothy Chen.
Changes
-------
Rebased on master.
Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849
Repository: mesos
Description
-------
Move docker provisioner local store into dedicated folders.
Diffs (updated)
-----
src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db
src/slave/containerizer/provisioners/docker/local_store.hpp PRE-CREATION
src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION
src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37496/diff/
Testing
-------
sudo make check
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 --gtest_shuffle=1
Thanks,
Lily Chen
Re: Review Request 37496: Move docker provisioner local store into
dedicated folders.
Posted by Lily Chen <li...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37496/
-----------------------------------------------------------
(Updated Aug. 25, 2015, 1:34 a.m.)
Review request for mesos and Timothy Chen.
Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849
Repository: mesos
Description
-------
Move docker provisioner local store into dedicated folders.
Diffs (updated)
-----
src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db
src/slave/containerizer/provisioners/docker/local_store.hpp PRE-CREATION
src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION
src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37496/diff/
Testing
-------
sudo make check
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 --gtest_shuffle=1
Thanks,
Lily Chen
Re: Review Request 37496: Move docker provisioner local store into
dedicated folders.
Posted by Lily Chen <li...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37496/
-----------------------------------------------------------
(Updated Aug. 19, 2015, 6:46 p.m.)
Review request for mesos and Timothy Chen.
Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849
Repository: mesos
Description
-------
Move docker provisioner local store into dedicated folders.
Diffs (updated)
-----
src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5
src/slave/containerizer/provisioners/docker/local_store.hpp PRE-CREATION
src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION
src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37496/diff/
Testing
-------
sudo make check
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 --gtest_shuffle=1
Thanks,
Lily Chen
Re: Review Request 37496: Move docker provisioner local store into
dedicated folders.
Posted by Lily Chen <li...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37496/
-----------------------------------------------------------
(Updated Aug. 16, 2015, 8:36 a.m.)
Review request for mesos and Timothy Chen.
Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849
Repository: mesos
Description
-------
Move docker provisioner local store into dedicated folders.
Diffs (updated)
-----
src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5
src/slave/containerizer/provisioners/docker/local_store.hpp PRE-CREATION
src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION
src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37496/diff/
Testing
-------
sudo make check
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 --gtest_shuffle=1
Thanks,
Lily Chen
Re: Review Request 37496: Move docker provisioner local store into
dedicated folders.
Posted by Lily Chen <li...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37496/
-----------------------------------------------------------
(Updated Aug. 15, 2015, 12:54 a.m.)
Review request for mesos and Timothy Chen.
Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849
Repository: mesos
Description
-------
Move docker provisioner local store into dedicated folders.
Diffs
-----
src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24
src/slave/containerizer/provisioners/docker/local_store.hpp PRE-CREATION
src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION
src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37496/diff/
Testing
-------
sudo make check
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 --gtest_shuffle=1
Thanks,
Lily Chen