[GitHub] [netbeans] neilcsmith-net commented on pull request #4498: Revert PR4025 due to changes in compile time constants.

[GitBox <gi...@apache.org>]

neilcsmith-net commented on PR #4498:
URL: https://github.com/apache/netbeans/pull/4498#issuecomment-1213133786

   I'm not sure it's "can inline" but rather "must inline". eg. from JLS "If a final field is initialized to a constant expression in the field declaration, ... uses of that final field are replaced at compile time with the value of the [constant expression](https://docs.oracle.com/javase/specs/jls/se14/html/jls-15.html#jls-15.29)".
   
   @BradWalker this means that the value those fields are assigned should not change. Code (eg. third-party plugins) compiled against older versions of the IDE could have different values. The masks are also constant expressions.  It's a binary incompatible change.
   
   The values are also in the API signature files - I saw it initially when generating those for NB15.  Check the diff in #4487  The tests should really have not passed with the changes.
   
   I'm of the opinion that revert, fix, re-apply is sometimes a better strategy for handling breaking changes.  Obviously here the re-apply would be in master for NB16 though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists