[GitHub] [dubbo] LQLlulu commented on a diff in pull request #10642: P2C load balance algorithm

[GitBox <gi...@apache.org>]

LQLlulu commented on code in PR #10642:
URL: https://github.com/apache/dubbo/pull/10642#discussion_r990575714


##########
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/loadbalance/PowerOfTwoChoiceWithLeastActive.java:
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.rpc.cluster.loadbalance;
+
+import org.apache.dubbo.common.URL;
+import org.apache.dubbo.rpc.Invocation;
+import org.apache.dubbo.rpc.Invoker;
+import org.apache.dubbo.rpc.RpcStatus;
+
+import java.util.List;
+import java.util.concurrent.ThreadLocalRandom;
+
+public class PowerOfTwoChoiceWithLeastActive extends AbstractLoadBalance{
+    public static final String NAME = "p2c";
+
+    @Override
+    protected <T> Invoker<T> doSelect(List<Invoker<T>> invokers, URL url, Invocation invocation){
+        int length = invokers.size();
+        if(length == 1){
+            return invokers.get(0);
+        }
+        if(length == 2){
+            return leastActive(invokers.get(0),invokers.get(1),invocation);
+        }
+        int pos1 = ThreadLocalRandom.current().nextInt(length);
+        int pos2 = ThreadLocalRandom.current().nextInt(length - 1);
+
+        if(pos2 >= pos1){
+            pos2 = pos2 + 1;
+        }
+
+        return leastActive(invokers.get(pos1),invokers.get(pos2),invocation);
+    }
+
+    private <T> Invoker<T> leastActive(Invoker<T> invoker1,Invoker<T> invoker2,Invocation invocation){
+        int active1 = RpcStatus.getStatus(invoker1.getUrl(),invocation.getMethodName()).getActive();
+        int active2 = RpcStatus.getStatus(invoker2.getUrl(),invocation.getMethodName()).getActive();

Review Comment:
   RpcStatus supports only method level operations for now and will be improved in the future
    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org