You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/01/06 05:50:19 UTC
[GitHub] [incubator-gobblin] shirshanka opened a new pull request #2860:
[Placeholder] Support for direct Avro and Protobuf formats through Parquet
writer
shirshanka opened a new pull request #2860: [Placeholder] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] shirshanka commented on a change in pull
request #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats
through Parquet writer
Posted by GitBox <gi...@apache.org>.
shirshanka commented on a change in pull request #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860#discussion_r367061312
##########
File path: gobblin-data-management/src/test/java/org/apache/gobblin/data/management/copy/UnixTimestampRecursiveCopyableDatasetTest.java
##########
@@ -116,7 +121,8 @@ public boolean accept(Path path) {
String datasetRoot = rootPath + "/" + databaseName;
UnixTimestampRecursiveCopyableDataset dataset = (UnixTimestampRecursiveCopyableDataset) finder.datasetAtPath(new Path(datasetRoot));
List<FileStatus> fileStatusList = dataset.getFilesAtPath(fs, baseSrcDir, ACCEPT_ALL_PATH_FILTER);
- Assert.assertTrue(fileStatusList.size() == 30);
+ Assert.assertEquals(fileStatusList.size(), NUM_FILES_PER_DIR * NUM_DIRS_PER_DAY * NUM_LOOKBACK_DAYS);
+ //Assert.assertTrue(fileStatusList.size() == 30);
Review comment:
reverted my changes to this test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] shirshanka commented on a change in pull
request #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats
through Parquet writer
Posted by GitBox <gi...@apache.org>.
shirshanka commented on a change in pull request #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860#discussion_r367061276
##########
File path: gobblin-data-management/src/test/java/org/apache/gobblin/data/management/copy/UnixTimestampRecursiveCopyableDatasetTest.java
##########
@@ -62,7 +65,9 @@ public void setUp()
}
fs.mkdirs(baseSrcDir);
- baseDstDir = new Path("/tmp/dst/dataset1/");
+// baseDstDir = new Path("/tmp/dst/dataset1/");
Review comment:
reverted my changes to this test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2860:
[GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet
writer
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860#issuecomment-571389021
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=h1) Report
> Merging [#2860](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/4483268e3885adb63da7253df5ab0c00eb86aece?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `60%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2860 +/- ##
============================================
+ Coverage 45.72% 45.73% +0.01%
- Complexity 9085 9094 +9
============================================
Files 1913 1915 +2
Lines 72021 72162 +141
Branches 7943 7954 +11
============================================
+ Hits 32929 33004 +75
- Misses 36074 36136 +62
- Partials 3018 3022 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/org/apache/gobblin/test/TestRecord.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi10ZXN0LXV0aWxzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Rlc3QvVGVzdFJlY29yZC5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [.../org/apache/gobblin/test/SequentialTestSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9TZXF1ZW50aWFsVGVzdFNvdXJjZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/gobblin/test/AnyToJsonConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb0pzb25Db252ZXJ0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/gobblin/test/AnyToStringConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb1N0cmluZ0NvbnZlcnRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC1hcGFjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1BhcnF1ZXREYXRhV3JpdGVyQnVpbGRlci5qYXZh) | `94.73% <94.73%> (+8.52%)` | `5 <5> (-1)` | :arrow_down: |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi93cml0ZXIvUGFycXVldERhdGFXcml0ZXJCdWlsZGVyLmphdmE=) | `94.73% <94.73%> (+8.52%)` | `5 <5> (-1)` | :arrow_down: |
| [...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh) | `40% <0%> (-20%)` | `2% <0%> (-1%)` | |
| [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `85.71% <0%> (-14.29%)` | `3% <0%> (-1%)` | |
| [...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh) | `59.09% <0%> (-1.52%)` | `14% <0%> (-1%)` | |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `63.42% <0%> (-1.39%)` | `27% <0%> (-1%)` | |
| ... and [10 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=footer). Last update [4483268...e87be37](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] shirshanka commented on issue #2860:
[GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet
writer
Posted by GitBox <gi...@apache.org>.
shirshanka commented on issue #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860#issuecomment-571479021
@htran1 : this is ready for review now.
I tried reducing the amount of copy-paste code across the two modules and lifted code into the gobblin-parquet-common module.
Support for JSON generation in SequentialTestSource doesn't exist currently, related to where it is located (gobblin-core-base versus gobblin-core). I will add that in later as part of the separate PR on data generation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] htran1 commented on a change in pull request
#2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through
Parquet writer
Posted by GitBox <gi...@apache.org>.
htran1 commented on a change in pull request #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860#discussion_r366392795
##########
File path: gobblin-data-management/src/test/java/org/apache/gobblin/data/management/copy/UnixTimestampRecursiveCopyableDatasetTest.java
##########
@@ -116,7 +121,8 @@ public boolean accept(Path path) {
String datasetRoot = rootPath + "/" + databaseName;
UnixTimestampRecursiveCopyableDataset dataset = (UnixTimestampRecursiveCopyableDataset) finder.datasetAtPath(new Path(datasetRoot));
List<FileStatus> fileStatusList = dataset.getFilesAtPath(fs, baseSrcDir, ACCEPT_ALL_PATH_FILTER);
- Assert.assertTrue(fileStatusList.size() == 30);
+ Assert.assertEquals(fileStatusList.size(), NUM_FILES_PER_DIR * NUM_DIRS_PER_DAY * NUM_LOOKBACK_DAYS);
+ //Assert.assertTrue(fileStatusList.size() == 30);
Review comment:
Remove this too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io commented on issue #2860:
[GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet
writer
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860#issuecomment-571389021
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=h1) Report
> Merging [#2860](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/d18783df7ab29b161cca59ca907fb47e1366b358?src=pr&el=desc) will **increase** coverage by `0.93%`.
> The diff coverage is `33.33%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2860 +/- ##
============================================
+ Coverage 44.8% 45.73% +0.93%
- Complexity 8933 9103 +170
============================================
Files 1917 1917
Lines 72131 72168 +37
Branches 7956 7960 +4
============================================
+ Hits 32316 33005 +689
+ Misses 36832 36134 -698
- Partials 2983 3029 +46
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/apache/gobblin/writer/ParquetHdfsDataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi93cml0ZXIvUGFycXVldEhkZnNEYXRhV3JpdGVyLmphdmE=) | `100% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...g/apache/gobblin/writer/ParquetHdfsDataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC1hcGFjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1BhcnF1ZXRIZGZzRGF0YVdyaXRlci5qYXZh) | `100% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [.../main/java/org/apache/gobblin/test/TestRecord.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi10ZXN0LXV0aWxzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Rlc3QvVGVzdFJlY29yZC5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [.../org/apache/gobblin/test/SequentialTestSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9TZXF1ZW50aWFsVGVzdFNvdXJjZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/gobblin/test/AnyToJsonConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb0pzb25Db252ZXJ0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/gobblin/test/AnyToStringConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb1N0cmluZ0NvbnZlcnRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC1hcGFjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1BhcnF1ZXREYXRhV3JpdGVyQnVpbGRlci5qYXZh) | `64.51% <66.66%> (-21.7%)` | `4 <2> (-2)` | |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi93cml0ZXIvUGFycXVldERhdGFXcml0ZXJCdWlsZGVyLmphdmE=) | `64.51% <66.66%> (-21.7%)` | `4 <2> (-2)` | |
| [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `61.42% <0%> (-1.43%)` | `4% <0%> (ø)` | |
| [...src/main/java/org/apache/gobblin/runtime/Task.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFzay5qYXZh) | `67.05% <0%> (+0.23%)` | `82% <0%> (+1%)` | :arrow_up: |
| ... and [46 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=footer). Last update [d18783d...c01cc58](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] asfgit closed pull request #2860:
[GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet
writer
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] htran1 commented on a change in pull request
#2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through
Parquet writer
Posted by GitBox <gi...@apache.org>.
htran1 commented on a change in pull request #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860#discussion_r366392120
##########
File path: gobblin-data-management/src/test/java/org/apache/gobblin/data/management/copy/UnixTimestampRecursiveCopyableDatasetTest.java
##########
@@ -37,15 +38,17 @@
public class UnixTimestampRecursiveCopyableDatasetTest {
- String rootPath = "/tmp/src";
+ //String rootPath = "/tmp/src";
Review comment:
This line can be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2860:
[GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet
writer
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860#issuecomment-571389021
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=h1) Report
> Merging [#2860](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/4483268e3885adb63da7253df5ab0c00eb86aece?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `60%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2860 +/- ##
============================================
+ Coverage 45.72% 45.73% +0.01%
- Complexity 9085 9094 +9
============================================
Files 1913 1915 +2
Lines 72021 72162 +141
Branches 7943 7954 +11
============================================
+ Hits 32929 33004 +75
- Misses 36074 36136 +62
- Partials 3018 3022 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/org/apache/gobblin/test/TestRecord.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi10ZXN0LXV0aWxzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Rlc3QvVGVzdFJlY29yZC5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [.../org/apache/gobblin/test/SequentialTestSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9TZXF1ZW50aWFsVGVzdFNvdXJjZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/gobblin/test/AnyToJsonConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb0pzb25Db252ZXJ0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/gobblin/test/AnyToStringConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb1N0cmluZ0NvbnZlcnRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC1hcGFjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1BhcnF1ZXREYXRhV3JpdGVyQnVpbGRlci5qYXZh) | `94.73% <94.73%> (+8.52%)` | `5 <5> (-1)` | :arrow_down: |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi93cml0ZXIvUGFycXVldERhdGFXcml0ZXJCdWlsZGVyLmphdmE=) | `94.73% <94.73%> (+8.52%)` | `5 <5> (-1)` | :arrow_down: |
| [...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh) | `40% <0%> (-20%)` | `2% <0%> (-1%)` | |
| [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `85.71% <0%> (-14.29%)` | `3% <0%> (-1%)` | |
| [...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh) | `59.09% <0%> (-1.52%)` | `14% <0%> (-1%)` | |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `63.42% <0%> (-1.39%)` | `27% <0%> (-1%)` | |
| ... and [10 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=footer). Last update [4483268...e87be37](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2860:
[GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet
writer
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860#issuecomment-571389021
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=h1) Report
> Merging [#2860](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/d18783df7ab29b161cca59ca907fb47e1366b358?src=pr&el=desc) will **increase** coverage by `0.9%`.
> The diff coverage is `36.63%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2860 +/- ##
==========================================
+ Coverage 44.8% 45.7% +0.9%
- Complexity 8933 9095 +162
==========================================
Files 1917 1916 -1
Lines 72131 72164 +33
Branches 7956 7957 +1
==========================================
+ Hits 32316 32985 +669
+ Misses 36832 36154 -678
- Partials 2983 3025 +42
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/apache/gobblin/writer/ParquetHdfsDataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi93cml0ZXIvUGFycXVldEhkZnNEYXRhV3JpdGVyLmphdmE=) | `100% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [.../main/java/org/apache/gobblin/test/TestRecord.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi10ZXN0LXV0aWxzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Rlc3QvVGVzdFJlY29yZC5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [.../org/apache/gobblin/test/SequentialTestSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9TZXF1ZW50aWFsVGVzdFNvdXJjZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/gobblin/test/AnyToJsonConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb0pzb25Db252ZXJ0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/gobblin/test/AnyToStringConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb1N0cmluZ0NvbnZlcnRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC1hcGFjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1BhcnF1ZXREYXRhV3JpdGVyQnVpbGRlci5qYXZh) | `60.52% <60.52%> (-25.69%)` | `3 <3> (-3)` | |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi93cml0ZXIvUGFycXVldERhdGFXcml0ZXJCdWlsZGVyLmphdmE=) | `64.51% <66.66%> (-21.7%)` | `4 <2> (-2)` | |
| [...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=) | `70% <0%> (-2.23%)` | `13% <0%> (ø)` | |
| [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `61.42% <0%> (-1.43%)` | `4% <0%> (ø)` | |
| [...src/main/java/org/apache/gobblin/runtime/Task.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFzay5qYXZh) | `67.05% <0%> (+0.23%)` | `82% <0%> (+1%)` | :arrow_up: |
| ... and [43 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=footer). Last update [d18783d...1cb9204](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] shirshanka commented on a change in pull
request #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats
through Parquet writer
Posted by GitBox <gi...@apache.org>.
shirshanka commented on a change in pull request #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860#discussion_r367061425
##########
File path: gobblin-core-base/src/main/java/org/apache/gobblin/test/SequentialTestSource.java
##########
@@ -169,28 +191,72 @@ public TestBatchExtractor(int partition,
this.numRecordsPerExtract = numRecordsPerExtract;
this.sleepTimePerRecord = sleepTimePerRecord;
this.workUnitState = wuState;
+ this.inMemoryFormat = InMemoryFormat.valueOf(this.workUnitState.getProp(MEMORY_FORMAT_KEY));
+ this.schema = getSchema(inMemoryFormat);
}
@Override
- public String getSchema()
+ public Object getSchema()
throws IOException {
- return "";
+ return this.schema;
+ }
+
+ private Object getSchema(InMemoryFormat inMemoryFormat) {
+ switch (inMemoryFormat) {
+ case POJO: {
+ return TestRecord.class;
+ }
+ case AVRO: {
+ return org.apache.gobblin.test.avro.TestRecord.getClassSchema();
+ }
+ case PROTOBUF: {
+ return TestRecordProtos.TestRecord.class;
+ }
+ default:
+ throw new RuntimeException("Not implemented " + inMemoryFormat.name());
+ }
}
@Override
- public Object readRecord(@Deprecated Object reuse)
+ public RecordEnvelope readRecordEnvelope()
throws DataRecordException, IOException {
if (recordsExtracted < numRecordsPerExtract) {
try {
Thread.sleep(sleepTimePerRecord);
} catch (InterruptedException e) {
Throwables.propagate(e);
}
- TestRecord record = new TestRecord(this.partition, this.currentWatermark.getValue(), null);
+ Object record;
+ switch (this.inMemoryFormat) {
+ case POJO: {
+ record = new TestRecord(this.partition, this.currentWatermark.getValue(), "I am a POJO message");
+ break;
+ }
+ case AVRO: {
+ record = org.apache.gobblin.test.avro.TestRecord.newBuilder()
+ .setPartition(this.partition)
+ .setSequence(this.currentWatermark.getValue())
+ .setPayload("I am an Avro message")
+ .build();
+ break;
+ }
+ case PROTOBUF: {
+ record = TestRecordProtos.TestRecord.newBuilder()
+ .setPartition(this.partition)
+ .setSequence(this.currentWatermark.getValue())
+ .setPayload("I am a Protobuf message")
+ .build();
+ break;
+ }
+ default: throw new RuntimeException("");
+ }
log.debug("Extracted record -> {}", record);
+ RecordEnvelope re = new RecordEnvelope<>((Object) record,
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] htran1 commented on a change in pull request
#2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through
Parquet writer
Posted by GitBox <gi...@apache.org>.
htran1 commented on a change in pull request #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860#discussion_r366391012
##########
File path: gobblin-core-base/src/main/java/org/apache/gobblin/test/SequentialTestSource.java
##########
@@ -169,28 +191,72 @@ public TestBatchExtractor(int partition,
this.numRecordsPerExtract = numRecordsPerExtract;
this.sleepTimePerRecord = sleepTimePerRecord;
this.workUnitState = wuState;
+ this.inMemoryFormat = InMemoryFormat.valueOf(this.workUnitState.getProp(MEMORY_FORMAT_KEY));
+ this.schema = getSchema(inMemoryFormat);
}
@Override
- public String getSchema()
+ public Object getSchema()
throws IOException {
- return "";
+ return this.schema;
+ }
+
+ private Object getSchema(InMemoryFormat inMemoryFormat) {
+ switch (inMemoryFormat) {
+ case POJO: {
+ return TestRecord.class;
+ }
+ case AVRO: {
+ return org.apache.gobblin.test.avro.TestRecord.getClassSchema();
+ }
+ case PROTOBUF: {
+ return TestRecordProtos.TestRecord.class;
+ }
+ default:
+ throw new RuntimeException("Not implemented " + inMemoryFormat.name());
+ }
}
@Override
- public Object readRecord(@Deprecated Object reuse)
+ public RecordEnvelope readRecordEnvelope()
throws DataRecordException, IOException {
if (recordsExtracted < numRecordsPerExtract) {
try {
Thread.sleep(sleepTimePerRecord);
} catch (InterruptedException e) {
Throwables.propagate(e);
}
- TestRecord record = new TestRecord(this.partition, this.currentWatermark.getValue(), null);
+ Object record;
+ switch (this.inMemoryFormat) {
+ case POJO: {
+ record = new TestRecord(this.partition, this.currentWatermark.getValue(), "I am a POJO message");
+ break;
+ }
+ case AVRO: {
+ record = org.apache.gobblin.test.avro.TestRecord.newBuilder()
+ .setPartition(this.partition)
+ .setSequence(this.currentWatermark.getValue())
+ .setPayload("I am an Avro message")
+ .build();
+ break;
+ }
+ case PROTOBUF: {
+ record = TestRecordProtos.TestRecord.newBuilder()
+ .setPartition(this.partition)
+ .setSequence(this.currentWatermark.getValue())
+ .setPayload("I am a Protobuf message")
+ .build();
+ break;
+ }
+ default: throw new RuntimeException("");
+ }
log.debug("Extracted record -> {}", record);
+ RecordEnvelope re = new RecordEnvelope<>((Object) record,
Review comment:
Is the casting to (Object) required?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2860:
[GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet
writer
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860#issuecomment-571389021
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=h1) Report
> Merging [#2860](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/4483268e3885adb63da7253df5ab0c00eb86aece?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `60%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2860 +/- ##
============================================
+ Coverage 45.72% 45.73% +0.01%
- Complexity 9085 9094 +9
============================================
Files 1913 1915 +2
Lines 72021 72162 +141
Branches 7943 7954 +11
============================================
+ Hits 32929 33004 +75
- Misses 36074 36136 +62
- Partials 3018 3022 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/org/apache/gobblin/test/TestRecord.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi10ZXN0LXV0aWxzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Rlc3QvVGVzdFJlY29yZC5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [.../org/apache/gobblin/test/SequentialTestSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9TZXF1ZW50aWFsVGVzdFNvdXJjZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/gobblin/test/AnyToJsonConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb0pzb25Db252ZXJ0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/gobblin/test/AnyToStringConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb1N0cmluZ0NvbnZlcnRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC1hcGFjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1BhcnF1ZXREYXRhV3JpdGVyQnVpbGRlci5qYXZh) | `94.73% <94.73%> (+8.52%)` | `5 <5> (-1)` | :arrow_down: |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi93cml0ZXIvUGFycXVldERhdGFXcml0ZXJCdWlsZGVyLmphdmE=) | `94.73% <94.73%> (+8.52%)` | `5 <5> (-1)` | :arrow_down: |
| [...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh) | `40% <0%> (-20%)` | `2% <0%> (-1%)` | |
| [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `85.71% <0%> (-14.29%)` | `3% <0%> (-1%)` | |
| [...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh) | `59.09% <0%> (-1.52%)` | `14% <0%> (-1%)` | |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `63.42% <0%> (-1.39%)` | `27% <0%> (-1%)` | |
| ... and [10 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=footer). Last update [4483268...e87be37](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2860:
[GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet
writer
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860#issuecomment-571389021
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=h1) Report
> Merging [#2860](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/4483268e3885adb63da7253df5ab0c00eb86aece?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `60%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2860 +/- ##
============================================
+ Coverage 45.72% 45.73% +0.01%
- Complexity 9085 9094 +9
============================================
Files 1913 1915 +2
Lines 72021 72162 +141
Branches 7943 7954 +11
============================================
+ Hits 32929 33004 +75
- Misses 36074 36136 +62
- Partials 3018 3022 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/org/apache/gobblin/test/TestRecord.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi10ZXN0LXV0aWxzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Rlc3QvVGVzdFJlY29yZC5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [.../org/apache/gobblin/test/SequentialTestSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9TZXF1ZW50aWFsVGVzdFNvdXJjZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/gobblin/test/AnyToJsonConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb0pzb25Db252ZXJ0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/gobblin/test/AnyToStringConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb1N0cmluZ0NvbnZlcnRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC1hcGFjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1BhcnF1ZXREYXRhV3JpdGVyQnVpbGRlci5qYXZh) | `94.73% <94.73%> (+8.52%)` | `5 <5> (-1)` | :arrow_down: |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi93cml0ZXIvUGFycXVldERhdGFXcml0ZXJCdWlsZGVyLmphdmE=) | `94.73% <94.73%> (+8.52%)` | `5 <5> (-1)` | :arrow_down: |
| [...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh) | `40% <0%> (-20%)` | `2% <0%> (-1%)` | |
| [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `85.71% <0%> (-14.29%)` | `3% <0%> (-1%)` | |
| [...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh) | `59.09% <0%> (-1.52%)` | `14% <0%> (-1%)` | |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `63.42% <0%> (-1.39%)` | `27% <0%> (-1%)` | |
| ... and [10 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=footer). Last update [4483268...e87be37](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2860:
[GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet
writer
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860#issuecomment-571389021
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=h1) Report
> Merging [#2860](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/64b074182a7bea017a249204c5448ee79a0a28ac?src=pr&el=desc) will **increase** coverage by `41.67%`.
> The diff coverage is `60%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2860 +/- ##
=============================================
+ Coverage 4.1% 45.78% +41.67%
- Complexity 747 9101 +8354
=============================================
Files 1917 1915 -2
Lines 72131 72219 +88
Branches 7956 7966 +10
=============================================
+ Hits 2961 33065 +30104
+ Misses 68851 36128 -32723
- Partials 319 3026 +2707
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/org/apache/gobblin/test/TestRecord.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi10ZXN0LXV0aWxzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Rlc3QvVGVzdFJlY29yZC5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [.../org/apache/gobblin/test/SequentialTestSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9TZXF1ZW50aWFsVGVzdFNvdXJjZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/gobblin/test/AnyToJsonConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb0pzb25Db252ZXJ0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/gobblin/test/AnyToStringConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb1N0cmluZ0NvbnZlcnRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC1hcGFjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1BhcnF1ZXREYXRhV3JpdGVyQnVpbGRlci5qYXZh) | `94.73% <94.73%> (+94.73%)` | `5 <5> (+5)` | :arrow_up: |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi93cml0ZXIvUGFycXVldERhdGFXcml0ZXJCdWlsZGVyLmphdmE=) | `94.73% <94.73%> (+94.73%)` | `5 <5> (+5)` | :arrow_up: |
| [...gobblin/service/monitoring/JobStatusRetriever.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9Kb2JTdGF0dXNSZXRyaWV2ZXIuamF2YQ==) | `0% <0%> (ø)` | `2% <0%> (+2%)` | :arrow_up: |
| [...pache/gobblin/runtime/GobblinMultiTaskAttempt.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvR29iYmxpbk11bHRpVGFza0F0dGVtcHQuamF2YQ==) | `55.85% <0%> (+0.9%)` | `26% <0%> (+1%)` | :arrow_up: |
| [...ata/management/copy/hive/HivePartitionFileSet.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9IaXZlUGFydGl0aW9uRmlsZVNldC5qYXZh) | `0.95% <0%> (+0.95%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=) | `64.44% <0%> (+1.11%)` | `16% <0%> (+1%)` | :arrow_up: |
| ... and [1113 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=footer). Last update [64b0741...2abaf5e](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] shirshanka commented on a change in pull
request #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats
through Parquet writer
Posted by GitBox <gi...@apache.org>.
shirshanka commented on a change in pull request #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860#discussion_r367061133
##########
File path: gobblin-core-base/src/main/java/org/apache/gobblin/test/SequentialTestSource.java
##########
@@ -169,28 +191,72 @@ public TestBatchExtractor(int partition,
this.numRecordsPerExtract = numRecordsPerExtract;
this.sleepTimePerRecord = sleepTimePerRecord;
this.workUnitState = wuState;
+ this.inMemoryFormat = InMemoryFormat.valueOf(this.workUnitState.getProp(MEMORY_FORMAT_KEY));
+ this.schema = getSchema(inMemoryFormat);
}
@Override
- public String getSchema()
+ public Object getSchema()
throws IOException {
- return "";
+ return this.schema;
+ }
+
+ private Object getSchema(InMemoryFormat inMemoryFormat) {
+ switch (inMemoryFormat) {
+ case POJO: {
+ return TestRecord.class;
+ }
+ case AVRO: {
+ return org.apache.gobblin.test.avro.TestRecord.getClassSchema();
+ }
+ case PROTOBUF: {
+ return TestRecordProtos.TestRecord.class;
+ }
+ default:
+ throw new RuntimeException("Not implemented " + inMemoryFormat.name());
+ }
}
@Override
- public Object readRecord(@Deprecated Object reuse)
+ public RecordEnvelope readRecordEnvelope()
throws DataRecordException, IOException {
if (recordsExtracted < numRecordsPerExtract) {
try {
Thread.sleep(sleepTimePerRecord);
} catch (InterruptedException e) {
Throwables.propagate(e);
}
- TestRecord record = new TestRecord(this.partition, this.currentWatermark.getValue(), null);
+ Object record;
+ switch (this.inMemoryFormat) {
+ case POJO: {
+ record = new TestRecord(this.partition, this.currentWatermark.getValue(), "I am a POJO message");
+ break;
+ }
+ case AVRO: {
+ record = org.apache.gobblin.test.avro.TestRecord.newBuilder()
+ .setPartition(this.partition)
+ .setSequence(this.currentWatermark.getValue())
+ .setPayload("I am an Avro message")
+ .build();
+ break;
+ }
+ case PROTOBUF: {
+ record = TestRecordProtos.TestRecord.newBuilder()
+ .setPartition(this.partition)
+ .setSequence(this.currentWatermark.getValue())
+ .setPayload("I am a Protobuf message")
+ .build();
+ break;
+ }
+ default: throw new RuntimeException("");
+ }
log.debug("Extracted record -> {}", record);
+ RecordEnvelope re = new RecordEnvelope<>((Object) record,
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2860:
[GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet
writer
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860#issuecomment-571389021
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=h1) Report
> Merging [#2860](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/4483268e3885adb63da7253df5ab0c00eb86aece?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `60%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2860 +/- ##
============================================
+ Coverage 45.72% 45.73% +0.01%
- Complexity 9085 9094 +9
============================================
Files 1913 1915 +2
Lines 72021 72162 +141
Branches 7943 7954 +11
============================================
+ Hits 32929 33004 +75
- Misses 36074 36136 +62
- Partials 3018 3022 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/org/apache/gobblin/test/TestRecord.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi10ZXN0LXV0aWxzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Rlc3QvVGVzdFJlY29yZC5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [.../org/apache/gobblin/test/SequentialTestSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9TZXF1ZW50aWFsVGVzdFNvdXJjZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/gobblin/test/AnyToJsonConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb0pzb25Db252ZXJ0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/gobblin/test/AnyToStringConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb1N0cmluZ0NvbnZlcnRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC1hcGFjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1BhcnF1ZXREYXRhV3JpdGVyQnVpbGRlci5qYXZh) | `94.73% <94.73%> (+8.52%)` | `5 <5> (-1)` | :arrow_down: |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi93cml0ZXIvUGFycXVldERhdGFXcml0ZXJCdWlsZGVyLmphdmE=) | `94.73% <94.73%> (+8.52%)` | `5 <5> (-1)` | :arrow_down: |
| [...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh) | `40% <0%> (-20%)` | `2% <0%> (-1%)` | |
| [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `85.71% <0%> (-14.29%)` | `3% <0%> (-1%)` | |
| [...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh) | `59.09% <0%> (-1.52%)` | `14% <0%> (-1%)` | |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `63.42% <0%> (-1.39%)` | `27% <0%> (-1%)` | |
| ... and [10 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=footer). Last update [4483268...e87be37](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2860:
[GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet
writer
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860#issuecomment-571389021
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=h1) Report
> Merging [#2860](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/4483268e3885adb63da7253df5ab0c00eb86aece?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `60%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2860 +/- ##
============================================
+ Coverage 45.72% 45.73% +0.01%
- Complexity 9085 9094 +9
============================================
Files 1913 1915 +2
Lines 72021 72162 +141
Branches 7943 7954 +11
============================================
+ Hits 32929 33004 +75
- Misses 36074 36136 +62
- Partials 3018 3022 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/org/apache/gobblin/test/TestRecord.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi10ZXN0LXV0aWxzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Rlc3QvVGVzdFJlY29yZC5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [.../org/apache/gobblin/test/SequentialTestSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9TZXF1ZW50aWFsVGVzdFNvdXJjZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/gobblin/test/AnyToJsonConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb0pzb25Db252ZXJ0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/gobblin/test/AnyToStringConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb1N0cmluZ0NvbnZlcnRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC1hcGFjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1BhcnF1ZXREYXRhV3JpdGVyQnVpbGRlci5qYXZh) | `94.73% <94.73%> (+8.52%)` | `5 <5> (-1)` | :arrow_down: |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi93cml0ZXIvUGFycXVldERhdGFXcml0ZXJCdWlsZGVyLmphdmE=) | `94.73% <94.73%> (+8.52%)` | `5 <5> (-1)` | :arrow_down: |
| [...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh) | `40% <0%> (-20%)` | `2% <0%> (-1%)` | |
| [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `85.71% <0%> (-14.29%)` | `3% <0%> (-1%)` | |
| [...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh) | `59.09% <0%> (-1.52%)` | `14% <0%> (-1%)` | |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `63.42% <0%> (-1.39%)` | `27% <0%> (-1%)` | |
| ... and [10 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=footer). Last update [4483268...e87be37](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] shirshanka commented on a change in pull
request #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats
through Parquet writer
Posted by GitBox <gi...@apache.org>.
shirshanka commented on a change in pull request #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860#discussion_r367061227
##########
File path: gobblin-data-management/src/test/java/org/apache/gobblin/data/management/copy/UnixTimestampRecursiveCopyableDatasetTest.java
##########
@@ -37,15 +38,17 @@
public class UnixTimestampRecursiveCopyableDatasetTest {
- String rootPath = "/tmp/src";
+ //String rootPath = "/tmp/src";
Review comment:
reverted my changes to this test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2860:
[GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet
writer
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860#issuecomment-571389021
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=h1) Report
> Merging [#2860](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/4483268e3885adb63da7253df5ab0c00eb86aece?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `60%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2860 +/- ##
============================================
+ Coverage 45.72% 45.73% +0.01%
- Complexity 9085 9094 +9
============================================
Files 1913 1915 +2
Lines 72021 72162 +141
Branches 7943 7954 +11
============================================
+ Hits 32929 33004 +75
- Misses 36074 36136 +62
- Partials 3018 3022 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/org/apache/gobblin/test/TestRecord.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi10ZXN0LXV0aWxzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Rlc3QvVGVzdFJlY29yZC5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [.../org/apache/gobblin/test/SequentialTestSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9TZXF1ZW50aWFsVGVzdFNvdXJjZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/gobblin/test/AnyToJsonConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb0pzb25Db252ZXJ0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/gobblin/test/AnyToStringConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb1N0cmluZ0NvbnZlcnRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC1hcGFjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1BhcnF1ZXREYXRhV3JpdGVyQnVpbGRlci5qYXZh) | `94.73% <94.73%> (+8.52%)` | `5 <5> (-1)` | :arrow_down: |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi93cml0ZXIvUGFycXVldERhdGFXcml0ZXJCdWlsZGVyLmphdmE=) | `94.73% <94.73%> (+8.52%)` | `5 <5> (-1)` | :arrow_down: |
| [...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh) | `40% <0%> (-20%)` | `2% <0%> (-1%)` | |
| [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `85.71% <0%> (-14.29%)` | `3% <0%> (-1%)` | |
| [...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh) | `59.09% <0%> (-1.52%)` | `14% <0%> (-1%)` | |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `63.42% <0%> (-1.39%)` | `27% <0%> (-1%)` | |
| ... and [10 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=footer). Last update [4483268...e87be37](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] htran1 commented on a change in pull request
#2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through
Parquet writer
Posted by GitBox <gi...@apache.org>.
htran1 commented on a change in pull request #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860#discussion_r366392544
##########
File path: gobblin-data-management/src/test/java/org/apache/gobblin/data/management/copy/UnixTimestampRecursiveCopyableDatasetTest.java
##########
@@ -62,7 +65,9 @@ public void setUp()
}
fs.mkdirs(baseSrcDir);
- baseDstDir = new Path("/tmp/dst/dataset1/");
+// baseDstDir = new Path("/tmp/dst/dataset1/");
Review comment:
Remove this line too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] shirshanka commented on a change in pull
request #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats
through Parquet writer
Posted by GitBox <gi...@apache.org>.
shirshanka commented on a change in pull request #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860#discussion_r367061425
##########
File path: gobblin-core-base/src/main/java/org/apache/gobblin/test/SequentialTestSource.java
##########
@@ -169,28 +191,72 @@ public TestBatchExtractor(int partition,
this.numRecordsPerExtract = numRecordsPerExtract;
this.sleepTimePerRecord = sleepTimePerRecord;
this.workUnitState = wuState;
+ this.inMemoryFormat = InMemoryFormat.valueOf(this.workUnitState.getProp(MEMORY_FORMAT_KEY));
+ this.schema = getSchema(inMemoryFormat);
}
@Override
- public String getSchema()
+ public Object getSchema()
throws IOException {
- return "";
+ return this.schema;
+ }
+
+ private Object getSchema(InMemoryFormat inMemoryFormat) {
+ switch (inMemoryFormat) {
+ case POJO: {
+ return TestRecord.class;
+ }
+ case AVRO: {
+ return org.apache.gobblin.test.avro.TestRecord.getClassSchema();
+ }
+ case PROTOBUF: {
+ return TestRecordProtos.TestRecord.class;
+ }
+ default:
+ throw new RuntimeException("Not implemented " + inMemoryFormat.name());
+ }
}
@Override
- public Object readRecord(@Deprecated Object reuse)
+ public RecordEnvelope readRecordEnvelope()
throws DataRecordException, IOException {
if (recordsExtracted < numRecordsPerExtract) {
try {
Thread.sleep(sleepTimePerRecord);
} catch (InterruptedException e) {
Throwables.propagate(e);
}
- TestRecord record = new TestRecord(this.partition, this.currentWatermark.getValue(), null);
+ Object record;
+ switch (this.inMemoryFormat) {
+ case POJO: {
+ record = new TestRecord(this.partition, this.currentWatermark.getValue(), "I am a POJO message");
+ break;
+ }
+ case AVRO: {
+ record = org.apache.gobblin.test.avro.TestRecord.newBuilder()
+ .setPartition(this.partition)
+ .setSequence(this.currentWatermark.getValue())
+ .setPayload("I am an Avro message")
+ .build();
+ break;
+ }
+ case PROTOBUF: {
+ record = TestRecordProtos.TestRecord.newBuilder()
+ .setPartition(this.partition)
+ .setSequence(this.currentWatermark.getValue())
+ .setPayload("I am a Protobuf message")
+ .build();
+ break;
+ }
+ default: throw new RuntimeException("");
+ }
log.debug("Extracted record -> {}", record);
+ RecordEnvelope re = new RecordEnvelope<>((Object) record,
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2860:
[GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet
writer
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860#issuecomment-571389021
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=h1) Report
> Merging [#2860](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/d18783df7ab29b161cca59ca907fb47e1366b358?src=pr&el=desc) will **increase** coverage by `0.93%`.
> The diff coverage is `60%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2860 +/- ##
============================================
+ Coverage 44.8% 45.73% +0.93%
- Complexity 8933 9094 +161
============================================
Files 1917 1915 -2
Lines 72131 72162 +31
Branches 7956 7954 -2
============================================
+ Hits 32316 33004 +688
+ Misses 36832 36136 -696
- Partials 2983 3022 +39
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/org/apache/gobblin/test/TestRecord.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi10ZXN0LXV0aWxzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Rlc3QvVGVzdFJlY29yZC5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [.../org/apache/gobblin/test/SequentialTestSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9TZXF1ZW50aWFsVGVzdFNvdXJjZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/gobblin/test/AnyToJsonConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb0pzb25Db252ZXJ0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/gobblin/test/AnyToStringConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb1N0cmluZ0NvbnZlcnRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC1hcGFjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1BhcnF1ZXREYXRhV3JpdGVyQnVpbGRlci5qYXZh) | `94.73% <94.73%> (+8.52%)` | `5 <5> (-1)` | :arrow_down: |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi93cml0ZXIvUGFycXVldERhdGFXcml0ZXJCdWlsZGVyLmphdmE=) | `94.73% <94.73%> (+8.52%)` | `5 <5> (-1)` | :arrow_down: |
| [...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=) | `70% <0%> (-2.23%)` | `13% <0%> (ø)` | |
| [...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh) | `59.09% <0%> (-1.52%)` | `14% <0%> (-1%)` | |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `63.42% <0%> (-1.39%)` | `27% <0%> (-1%)` | |
| [...src/main/java/org/apache/gobblin/runtime/Task.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFzay5qYXZh) | `67.05% <0%> (+0.23%)` | `82% <0%> (+1%)` | :arrow_up: |
| ... and [43 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=footer). Last update [d18783d...e87be37](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2860:
[GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet
writer
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2860: [GOBBLIN-1015] Support for direct Avro and Protobuf formats through Parquet writer
URL: https://github.com/apache/incubator-gobblin/pull/2860#issuecomment-571389021
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=h1) Report
> Merging [#2860](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/4483268e3885adb63da7253df5ab0c00eb86aece?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `60%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2860 +/- ##
============================================
+ Coverage 45.72% 45.74% +0.02%
- Complexity 9085 9095 +10
============================================
Files 1913 1915 +2
Lines 72021 72162 +141
Branches 7943 7954 +11
============================================
+ Hits 32929 33009 +80
- Misses 36074 36131 +57
- Partials 3018 3022 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/org/apache/gobblin/test/TestRecord.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi10ZXN0LXV0aWxzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Rlc3QvVGVzdFJlY29yZC5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [.../org/apache/gobblin/test/SequentialTestSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9TZXF1ZW50aWFsVGVzdFNvdXJjZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/gobblin/test/AnyToJsonConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb0pzb25Db252ZXJ0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/gobblin/test/AnyToStringConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9BbnlUb1N0cmluZ0NvbnZlcnRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC1hcGFjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1BhcnF1ZXREYXRhV3JpdGVyQnVpbGRlci5qYXZh) | `94.73% <94.73%> (+8.52%)` | `5 <5> (-1)` | :arrow_down: |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi93cml0ZXIvUGFycXVldERhdGFXcml0ZXJCdWlsZGVyLmphdmE=) | `94.73% <94.73%> (+8.52%)` | `5 <5> (-1)` | :arrow_down: |
| [...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh) | `40% <0%> (-20%)` | `2% <0%> (-1%)` | |
| [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `85.71% <0%> (-14.29%)` | `3% <0%> (-1%)` | |
| [...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==) | `30.2% <0%> (-0.68%)` | `24% <0%> (-1%)` | |
| [...n/compaction/action/CompactionWatermarkAction.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25XYXRlcm1hcmtBY3Rpb24uamF2YQ==) | `77.04% <0%> (ø)` | `11% <0%> (?)` | |
| ... and [8 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=footer). Last update [4483268...1103960](https://codecov.io/gh/apache/incubator-gobblin/pull/2860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services