You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2015/01/02 05:46:09 UTC

Review Request 29530: Used new std::string Socket::recv/send overloads in tests.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29530/
-----------------------------------------------------------

Review request for mesos, Joris Van Remoortere and Niklas Nielsen.


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  3rdparty/libprocess/src/tests/http_tests.cpp c71a91d516214d20d3df4c220e4a39a070db3260 
  3rdparty/libprocess/src/tests/process_tests.cpp 3bbfe0a7a65acb52d139fda81816acf305d891f5 

Diff: https://reviews.apache.org/r/29530/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman


Re: Review Request 29530: Used new std::string Socket::recv/send overloads in tests.

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29530/#review66828
-----------------------------------------------------------

Ship it!


Ship It!

- Niklas Nielsen


On Jan. 1, 2015, 8:46 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29530/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2015, 8:46 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/http_tests.cpp c71a91d516214d20d3df4c220e4a39a070db3260 
>   3rdparty/libprocess/src/tests/process_tests.cpp 3bbfe0a7a65acb52d139fda81816acf305d891f5 
> 
> Diff: https://reviews.apache.org/r/29530/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request 29530: Used new std::string Socket::recv/send overloads in tests.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29530/#review69291
-----------------------------------------------------------

Ship it!


Ship It!

- Joris Van Remoortere


On Jan. 2, 2015, 4:46 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29530/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2015, 4:46 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/http_tests.cpp c71a91d516214d20d3df4c220e4a39a070db3260 
>   3rdparty/libprocess/src/tests/process_tests.cpp 3bbfe0a7a65acb52d139fda81816acf305d891f5 
> 
> Diff: https://reviews.apache.org/r/29530/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>