You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Patrik Márton via Review Board <no...@reviews.apache.org> on 2022/06/22 15:15:35 UTC

Review Request 74035: RANGER-3790: Ranger tagsync module should not depend on kafka server

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74035/
-----------------------------------------------------------

Review request for ranger.


Repository: ranger


Description
-------

This commit removes the unused kafka core dependency from the assembly xml of the tagsync module, so it will not be added to the distribution.


Diffs
-----

  distro/src/main/assembly/tagsync.xml c467e5a97 


Diff: https://reviews.apache.org/r/74035/diff/1/


Testing
-------

Tested manually by checking the dependencies for tagsync module in the distribution.


Thanks,

Patrik Márton


Re: Review Request 74035: RANGER-3790: Ranger tagsync module should not depend on kafka server

Posted by Patrik Márton via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74035/
-----------------------------------------------------------

(Updated July 13, 2022, 12:58 p.m.)


Review request for ranger.


Changes
-------

Further Testing done.


Bugs: RANGER-3790
    https://issues.apache.org/jira/browse/RANGER-3790


Repository: ranger


Description
-------

This commit removes the unused kafka core dependency from the assembly xml of the tagsync module, so it will not be added to the distribution.


Diffs
-----

  distro/src/main/assembly/tagsync.xml c467e5a97 


Diff: https://reviews.apache.org/r/74035/diff/1/


Testing (updated)
-------

Tested manually by checking the dependencies for tagsync module in the distribution.
Tested the TagSync module on a manually provisioned cluster.


Thanks,

Patrik Márton


Re: Review Request 74035: RANGER-3790: Ranger tagsync module should not depend on kafka server

Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74035/#review224533
-----------------------------------------------------------



Can you please also verify the basic tagsync functionality.

- bhavik patel


On June 23, 2022, 2:27 p.m., Patrik Márton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74035/
> -----------------------------------------------------------
> 
> (Updated June 23, 2022, 2:27 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-3790
>     https://issues.apache.org/jira/browse/RANGER-3790
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> This commit removes the unused kafka core dependency from the assembly xml of the tagsync module, so it will not be added to the distribution.
> 
> 
> Diffs
> -----
> 
>   distro/src/main/assembly/tagsync.xml c467e5a97 
> 
> 
> Diff: https://reviews.apache.org/r/74035/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually by checking the dependencies for tagsync module in the distribution.
> 
> 
> Thanks,
> 
> Patrik Márton
> 
>


Re: Review Request 74035: RANGER-3790: Ranger tagsync module should not depend on kafka server

Posted by Andras Katona via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74035/#review224527
-----------------------------------------------------------


Ship it!




Ship It!

- Andras Katona


On June 23, 2022, 2:27 p.m., Patrik Márton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74035/
> -----------------------------------------------------------
> 
> (Updated June 23, 2022, 2:27 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-3790
>     https://issues.apache.org/jira/browse/RANGER-3790
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> This commit removes the unused kafka core dependency from the assembly xml of the tagsync module, so it will not be added to the distribution.
> 
> 
> Diffs
> -----
> 
>   distro/src/main/assembly/tagsync.xml c467e5a97 
> 
> 
> Diff: https://reviews.apache.org/r/74035/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually by checking the dependencies for tagsync module in the distribution.
> 
> 
> Thanks,
> 
> Patrik Márton
> 
>


Re: Review Request 74035: RANGER-3790: Ranger tagsync module should not depend on kafka server

Posted by Patrik Márton via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74035/
-----------------------------------------------------------

(Updated June 23, 2022, 2:27 p.m.)


Review request for ranger.


Changes
-------

Added jira ticket


Bugs: RANGER-3790
    https://issues.apache.org/jira/browse/RANGER-3790


Repository: ranger


Description
-------

This commit removes the unused kafka core dependency from the assembly xml of the tagsync module, so it will not be added to the distribution.


Diffs
-----

  distro/src/main/assembly/tagsync.xml c467e5a97 


Diff: https://reviews.apache.org/r/74035/diff/1/


Testing
-------

Tested manually by checking the dependencies for tagsync module in the distribution.


Thanks,

Patrik Márton