You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/23 06:30:40 UTC
[GitHub] [cloudstack] davidjumani opened a new pull request #5354: Fix security_groups for c8/suse
davidjumani opened a new pull request #5354:
URL: https://github.com/apache/cloudstack/pull/5354
### Description
Fixes fetching the bridge name for c8 / suse where the result of virsh domlist contains leading spaces
Used only in component tests, so not a functionality break
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### How Has This Been Tested?
#### Before :
```
# virsh domiflist i-2-3-VM |grep -w '02:00:12:b0:00:01'
vnet6 bridge cloudbr1 virtio 02:00:12:b0:00:01 <- notice the leading space
# virsh domiflist i-2-3-VM |grep -w '02:00:12:b0:00:01' |tr -s ' '|cut -d ' ' -f3
bridge <- Displays the second field
```
#### After :
```
# virsh domiflist i-2-3-VM |grep -w '02:00:12:b0:00:01'
vnet6 bridge cloudbr1 virtio 02:00:12:b0:00:01 <- notice the leading space
# virsh domiflist i-2-3-VM |grep -w '02:00:12:b0:00:01' | awk '{print $3}'
cloudbr1 <- Displays the bridge name
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5354: Fix security_groups for c8/suse
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5354:
URL: https://github.com/apache/cloudstack/pull/5354#issuecomment-904383905
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5354: Fix security_groups for c8/suse
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5354:
URL: https://github.com/apache/cloudstack/pull/5354#issuecomment-903530935
Thanks @weizhouapache I also had to force push since I needed to rebase, can you add your changes again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5354: Fix security_groups for c8/suse
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5354:
URL: https://github.com/apache/cloudstack/pull/5354#issuecomment-903523611
@davidjumani @DaanHoogland
I reverted a minor change in #5348 in this pr.
@davidjumani could you target this pr to 4.15 ?
the issue also exist in ubuntu 20.04, I will create a testing env and run the test (it should work)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5354: Fix security_groups for c8/suse
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5354:
URL: https://github.com/apache/cloudstack/pull/5354#issuecomment-903556498
@rhtyd This is used only for verifying the rules for tests, does not affect the functioning of the agent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5354: Fix security_groups for c8/suse
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5354:
URL: https://github.com/apache/cloudstack/pull/5354#issuecomment-904394867
Nevermind - reviewed this, LGTM. No tests needed as manual tests are provided and BO doesn't run component test with security groups (yet).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5354: Fix security_groups for c8/suse
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5354:
URL: https://github.com/apache/cloudstack/pull/5354#issuecomment-904383681
LGTM then and based on Wei's tests too.
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5354: Fix security_groups for c8/suse
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5354:
URL: https://github.com/apache/cloudstack/pull/5354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5354: Fix security_groups for c8/suse
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5354:
URL: https://github.com/apache/cloudstack/pull/5354#issuecomment-903482176
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5354: Fix security_groups for c8/suse
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5354:
URL: https://github.com/apache/cloudstack/pull/5354#issuecomment-903564238
> @rhtyd This is used only for verifying the rules for tests, does not affect the functioning of the agent
yes, agree with @davidjumani . it does not impact the functionalities.
it is only used by component test test/integration/component/test_multiple_nic_support.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5354: Fix security_groups for c8/suse
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5354:
URL: https://github.com/apache/cloudstack/pull/5354#issuecomment-903482316
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5354: Fix security_groups for c8/suse
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5354:
URL: https://github.com/apache/cloudstack/pull/5354#issuecomment-903530423
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5354: Fix security_groups for c8/suse
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5354:
URL: https://github.com/apache/cloudstack/pull/5354#issuecomment-903529784
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5354: Fix security_groups for c8/suse
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5354:
URL: https://github.com/apache/cloudstack/pull/5354#issuecomment-903494018
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5354: Fix security_groups for c8/suse
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5354:
URL: https://github.com/apache/cloudstack/pull/5354#issuecomment-903550377
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #5354: Fix security_groups for c8/suse
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #5354:
URL: https://github.com/apache/cloudstack/pull/5354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5354: Fix security_groups for c8/suse
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5354:
URL: https://github.com/apache/cloudstack/pull/5354#issuecomment-904414655
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5354: Fix security_groups for c8/suse
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5354:
URL: https://github.com/apache/cloudstack/pull/5354#issuecomment-903563572
> Thanks @weizhouapache I also had to force push since I needed to rebase, can you add your changes again
@davidjumani thanks. done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org