You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org> on 2022/08/08 03:13:18 UTC

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18821


Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................

IMPALA-11480: Retain all YARN container logs in a Jenkins run

This patch explicitly sets 'yarn.nodemanager.log.retain-seconds' to a
large enough value so that all the YARN container log files created in a
Jenkins run will be archived.

Testing:
 - Verified in a Jenkins run that all the YARN container logs are indeed
   archived.

Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
---
M testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/18821/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18821/1/testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py
File testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py:

http://gerrit.cloudera.org:8080/#/c/18821/1/testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py@59
PS1, Line 59: '86400'
Should we use numbers instead of strings, i.e. 86400 instead of '86400'? I see we use numbers at line 74 and 77.



-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 06:15:15 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 5
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Aug 2022 23:51:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................

IMPALA-11480: Retain all YARN container logs in a Jenkins run

This patch explicitly sets 'yarn.nodemanager.log.retain-seconds' to a
large enough value so that all the YARN container log files created in a
Jenkins run will be archived.

Testing:
 - Verified in a Jenkins run that all the YARN container logs are indeed
   archived.

Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Reviewed-on: http://gerrit.cloudera.org:8080/18821
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 9
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................


Patch Set 8: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 8
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Aug 2022 03:50:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................


Patch Set 2:

(1 comment)

> Patch Set 1:
> 
> (1 comment)

Thanks for the comment Quanlong! I have slightly changed my previous patch according to your suggestion.

http://gerrit.cloudera.org:8080/#/c/18821/1/testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py
File testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py:

http://gerrit.cloudera.org:8080/#/c/18821/1/testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py@59
PS1, Line 59: 86400,
> Should we use numbers instead of strings, i.e. 86400 instead of '86400'? I 
Thanks Quanlong!

Yes. In order to be consistent, I will change '86400' to 86400 (It looks like '86400' works as well) in the next patch set.



-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 18:57:17 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8417/


-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Aug 2022 04:20:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 23:13:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11110/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 03:34:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 23:14:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8437/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 7
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Aug 2022 16:04:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................


Patch Set 8: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 8
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Aug 2022 08:41:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 6
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Aug 2022 23:52:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................


Patch Set 6: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8432/


-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 6
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Aug 2022 04:41:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................


Patch Set 7: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8437/


-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 7
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Aug 2022 21:02:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8417/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 23:14:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................


Patch Set 1:

Hi all, please let me know if you have any comment on the patch.

Thank you very much for the help!


-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 03:14:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................


Patch Set 4:

> Patch Set 4: Verified-1
> 
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8429/

We seemed to be hitting IMPALA-11329.


-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 4
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Aug 2022 22:40:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................

IMPALA-11480: Retain all YARN container logs in a Jenkins run

This patch explicitly sets 'yarn.nodemanager.log.retain-seconds' to a
large enough value so that all the YARN container log files created in a
Jenkins run will be archived.

Testing:
 - Verified in a Jenkins run that all the YARN container logs are indeed
   archived.

Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
---
M testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/18821/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8429/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 4
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Aug 2022 17:33:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 4
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Aug 2022 17:33:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8429/


-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 4
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Aug 2022 22:34:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................


Patch Set 7: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 7
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Aug 2022 16:04:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8432/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 6
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Aug 2022 23:52:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11120/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 19:18:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11480: Retain all YARN container logs in a Jenkins run

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )

Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run
......................................................................


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8440/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3
Gerrit-Change-Number: 18821
Gerrit-PatchSet: 8
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Aug 2022 03:50:14 +0000
Gerrit-HasComments: No