You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/04/27 02:03:32 UTC
[GitHub] [rocketmq] iamqq23ue opened a new issue, #4215: OFFSET_OVERFLOW_BADLY will lead to consumption from begin, a large number of repeated consumption
iamqq23ue opened a new issue, #4215:
URL: https://github.com/apache/rocketmq/issues/4215
version 4.9.3
In DefaultMessageStore.java ，There is the following code：
else if (offset > maxOffset) {
status = GetMessageStatus.OFFSET_OVERFLOW_BADLY;
if (0 == minOffset) {
nextBeginOffset = nextOffsetCorrection(offset, minOffset);
} else {
nextBeginOffset = nextOffsetCorrection(offset, maxOffset);
}
It can be seen that if minOffset=0.Consumption will start from 0.This can lead to repeated consumption of data for several days.
I suggest modifying to:。
else if (offset > maxOffset) {
status = GetMessageStatus.OFFSET_OVERFLOW_BADLY;
nextBeginOffset = nextOffsetCorrection(offset, maxOffset);
If it's ok i can submit a pr .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] iamqq23ue commented on issue #4215: OFFSET_OVERFLOW_BADLY will lead to consumption from begin, a large number of repeated consumption
Posted by GitBox <gi...@apache.org>.
iamqq23ue commented on issue #4215:
URL: https://github.com/apache/rocketmq/issues/4215#issuecomment-1110781253
> > 5.0.0 seems to have changed a lot, we still plan to use version 4.9 for now.
>
> then you can cherry-pick it from 5.0.0 to 4.9.3 and submit a pr :)
thanks. already summit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin closed issue #4215: OFFSET_OVERFLOW_BADLY will lead to consumption from begin, a large number of repeated consumption
Posted by GitBox <gi...@apache.org>.
RongtongJin closed issue #4215: OFFSET_OVERFLOW_BADLY will lead to consumption from begin, a large number of repeated consumption
URL: https://github.com/apache/rocketmq/issues/4215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ltamber commented on issue #4215: OFFSET_OVERFLOW_BADLY will lead to consumption from begin, a large number of repeated consumption
Posted by GitBox <gi...@apache.org>.
ltamber commented on issue #4215:
URL: https://github.com/apache/rocketmq/issues/4215#issuecomment-1110484595
it seem that have been fixed in [here](https://github.com/apache/rocketmq/blob/5.0.0-beta/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java#L702) in branch 5.0.0-beta
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on issue #4215: OFFSET_OVERFLOW_BADLY will lead to consumption from begin, a large number of repeated consumption
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #4215:
URL: https://github.com/apache/rocketmq/issues/4215#issuecomment-1113980867
Merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ltamber commented on issue #4215: OFFSET_OVERFLOW_BADLY will lead to consumption from begin, a large number of repeated consumption
Posted by GitBox <gi...@apache.org>.
ltamber commented on issue #4215:
URL: https://github.com/apache/rocketmq/issues/4215#issuecomment-1110500655
>
then you can cherry-pick it from 5.0.0 to 4.9.3 and submit a pr :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] iamqq23ue commented on issue #4215: OFFSET_OVERFLOW_BADLY will lead to consumption from begin, a large number of repeated consumption
Posted by GitBox <gi...@apache.org>.
iamqq23ue commented on issue #4215:
URL: https://github.com/apache/rocketmq/issues/4215#issuecomment-1110494390
> it seem that have been fixed in [here](https://github.com/apache/rocketmq/blob/5.0.0-beta/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java#L702) in branch 5.0.0-beta
@ltamber 5.0.0 seems to have changed a lot, we still plan to use version 4.9 for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org