[GitHub] [doris] HappenLee commented on a diff in pull request #13020: [Opt](Vec) Support const column check nullable and remove nullable

[GitBox <gi...@apache.org>]

HappenLee commented on code in PR #13020:
URL: https://github.com/apache/doris/pull/13020#discussion_r982445263


##########
be/src/vec/columns/column_nullable.cpp:
##########
@@ -570,6 +570,16 @@ ColumnPtr remove_nullable(const ColumnPtr& column) {
     if (is_column_nullable(*column)) {
         return reinterpret_cast<const ColumnNullable*>(column.get())->get_nested_column_ptr();
     }
+
+    if (is_column_const(*column)) {

Review Comment:
   here two method `add_remove` nullable bosh in `nullable.cpp`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org