You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by BenFradet <gi...@git.apache.org> on 2016/05/01 16:07:36 UTC
[GitHub] spark pull request: [SPARK-14985][ML] Update LinearRegression, Log...
GitHub user BenFradet opened a pull request:
https://github.com/apache/spark/pull/12823
[SPARK-14985][ML] Update LinearRegression, LogisticRegression summary internals to handle model copy
## What changes were proposed in this pull request?
The summaries now have a internal copy of the model
## How was this patch tested?
Reran the concerned suites
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BenFradet/spark SPARK-14985
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12823.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12823
----
commit 9d913b88f571014b53552f5b2605efc532b88dbb
Author: BenFradet <be...@gmail.com>
Date: 2016-04-30T15:57:32Z
creation of an internal copy of the model for the linear regression training summary
commit 030442c3647c3f1bcb81b2ccc07935818b3fee92
Author: BenFradet <be...@gmail.com>
Date: 2016-05-01T13:33:18Z
creation of an internal copy of the model for the logistic regression training summary
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14985][ML] Update LinearRegression, Log...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12823#issuecomment-216052504
**[Test build #57482 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57482/consoleFull)** for PR 12823 at commit [`030442c`](https://github.com/apache/spark/commit/030442c3647c3f1bcb81b2ccc07935818b3fee92).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12823
**[Test build #95021 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95021/testReport)** for PR 12823 at commit [`74e1fa0`](https://github.com/apache/spark/commit/74e1fa0cad9e1b84d6955e03f788b6c294773505).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14985][ML] Update LinearRegression, Log...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12823#issuecomment-216053050
**[Test build #57482 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57482/consoleFull)** for PR 12823 at commit [`030442c`](https://github.com/apache/spark/commit/030442c3647c3f1bcb81b2ccc07935818b3fee92).
* This patch **fails MiMa tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12823
**[Test build #75245 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75245/testReport)** for PR 12823 at commit [`74e1fa0`](https://github.com/apache/spark/commit/74e1fa0cad9e1b84d6955e03f788b6c294773505).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by BenFradet <gi...@git.apache.org>.
Github user BenFradet commented on the issue:
https://github.com/apache/spark/pull/12823
@jkbradley I did close this due to inactivity, I'm reopening it as I now have a bit of time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12823
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75110/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12823
**[Test build #95021 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95021/testReport)** for PR 12823 at commit [`74e1fa0`](https://github.com/apache/spark/commit/74e1fa0cad9e1b84d6955e03f788b6c294773505).
* This patch **fails Spark unit tests**.
* This patch **does not merge cleanly**.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by BenFradet <gi...@git.apache.org>.
Github user BenFradet commented on the issue:
https://github.com/apache/spark/pull/12823
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by BenFradet <gi...@git.apache.org>.
Github user BenFradet commented on the issue:
https://github.com/apache/spark/pull/12823
ping @jkbradley if you could take a look, that'd be great.
If you have the time, there is also the #17431 segue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #12823: [SPARK-14985][ML] Update LinearRegression, Logist...
Posted by BenFradet <gi...@git.apache.org>.
Github user BenFradet closed the pull request at:
https://github.com/apache/spark/pull/12823
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12823
**[Test build #75242 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75242/testReport)** for PR 12823 at commit [`74e1fa0`](https://github.com/apache/spark/commit/74e1fa0cad9e1b84d6955e03f788b6c294773505).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12823
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75242/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by BenFradet <gi...@git.apache.org>.
Github user BenFradet commented on the issue:
https://github.com/apache/spark/pull/12823
@MLnick ok, I'll have a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12823
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75107/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12823
**[Test build #75107 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75107/consoleFull)** for PR 12823 at commit [`030442c`](https://github.com/apache/spark/commit/030442c3647c3f1bcb81b2ccc07935818b3fee92).
* This patch **fails MiMa tests**.
* This patch **does not merge cleanly**.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12823
**[Test build #75169 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75169/testReport)** for PR 12823 at commit [`d0a04bb`](https://github.com/apache/spark/commit/d0a04bb1f0a91384572ca37be2a22418b1377ae3).
* This patch **fails MiMa tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12823
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by BenFradet <gi...@git.apache.org>.
Github user BenFradet commented on the issue:
https://github.com/apache/spark/pull/12823
@MLnick should we wait on those PRs being merged before moving forward with this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12823
**[Test build #75110 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75110/testReport)** for PR 12823 at commit [`a996b6d`](https://github.com/apache/spark/commit/a996b6d39fa5b501d6b13887b3697fbb2fa88295).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12823
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75169/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12823
**[Test build #75242 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75242/testReport)** for PR 12823 at commit [`74e1fa0`](https://github.com/apache/spark/commit/74e1fa0cad9e1b84d6955e03f788b6c294773505).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #12823: [SPARK-14985][ML] Update LinearRegression, Logist...
Posted by BenFradet <gi...@git.apache.org>.
Github user BenFradet closed the pull request at:
https://github.com/apache/spark/pull/12823
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12823
**[Test build #75169 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75169/testReport)** for PR 12823 at commit [`d0a04bb`](https://github.com/apache/spark/commit/d0a04bb1f0a91384572ca37be2a22418b1377ae3).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12823
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #12823: [SPARK-14985][ML] Update LinearRegression, Logist...
Posted by BenFradet <gi...@git.apache.org>.
GitHub user BenFradet reopened a pull request:
https://github.com/apache/spark/pull/12823
[SPARK-14985][ML] Update LinearRegression, LogisticRegression summary internals to handle model copy
## What changes were proposed in this pull request?
The summaries now have a internal copy of the model
## How was this patch tested?
Reran the concerned suites
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BenFradet/spark SPARK-14985
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12823.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12823
----
commit 9d913b88f571014b53552f5b2605efc532b88dbb
Author: BenFradet <be...@gmail.com>
Date: 2016-04-30T15:57:32Z
creation of an internal copy of the model for the linear regression training summary
commit 030442c3647c3f1bcb81b2ccc07935818b3fee92
Author: BenFradet <be...@gmail.com>
Date: 2016-05-01T13:33:18Z
creation of an internal copy of the model for the logistic regression training summary
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12823
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12823
**[Test build #75107 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75107/consoleFull)** for PR 12823 at commit [`030442c`](https://github.com/apache/spark/commit/030442c3647c3f1bcb81b2ccc07935818b3fee92).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12823
**[Test build #75245 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75245/testReport)** for PR 12823 at commit [`74e1fa0`](https://github.com/apache/spark/commit/74e1fa0cad9e1b84d6955e03f788b6c294773505).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14985][ML] Update LinearRegression, Log...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12823#issuecomment-216053053
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12823
**[Test build #75110 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75110/testReport)** for PR 12823 at commit [`a996b6d`](https://github.com/apache/spark/commit/a996b6d39fa5b501d6b13887b3697fbb2fa88295).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by BenFradet <gi...@git.apache.org>.
Github user BenFradet commented on the issue:
https://github.com/apache/spark/pull/12823
`org.apache.spark.storage.BlockManagerProactiveReplicationSuite.proactive block replication - 3 replicas - 2 block manager deletions` doesn't seem to be linked, relaunching the tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12823
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12823
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95021/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12823
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/12823
@BenFradet I'm sorry for dropping the ball on this one. Did you close this due to inactivity? If you're willing, it would be nice to do this cleanup.
To answer your questions:
> Regarding linear regression, should the tValues, pValues, coefficientStandardErrors and the different metrics be moved to the training summary?
Same thing for logistic regression, should the different metrics be moved to the training summary?
These can go in the summary, not just the training summary, since they can be calculated from the model. The training summary just has values which are specific to the training process.
> Also, I noticed some discrepancy regarding the visibility of some fields in linear regression compared to generalized linear regression:
* numInstances is public in lr and regression private in glr
* degreesOfFreedom is private in lr and public in glr
Making numInstances and degreesOfFreedom public sounds good to me.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12823
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75245/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by MLnick <gi...@git.apache.org>.
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/12823
@BenFradet I think this needs to be updated now - and should also take into account #15435 and #17586
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14985][ML] Update LinearRegression, Log...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12823#issuecomment-216053054
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57482/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14985][ML] Update LinearRegression, Log...
Posted by BenFradet <gi...@git.apache.org>.
Github user BenFradet commented on the pull request:
https://github.com/apache/spark/pull/12823#issuecomment-216052601
@jkbradley
Regarding linear regression, should the `tValues`, `pValues`, `coefficientStandardErrors` and the different metrics be moved to the training summary?
Same thing for logistic regression, should the different metrics be moved to the training summary?
Also, I noticed some discrepancy regarding the visibility of some fields in linear regression compared to the generalized linear regression:
- `numInstances` is public in lr and regression private in glr
- `degreesOfFreedom` is private in lr and public in glr
Is this intentional?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12823
Build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org