You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2015/08/26 21:08:42 UTC

logging-log4j2 git commit: Use Generics in Configuration.getAppender() API to avoid type casting.

Repository: logging-log4j2
Updated Branches:
  refs/heads/master d80723c71 -> edfdd8888


Use Generics in Configuration.getAppender() API to avoid type casting.

Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/edfdd888
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/edfdd888
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/edfdd888

Branch: refs/heads/master
Commit: edfdd888802e85c12796b1a8433bb9fd4577f31e
Parents: d80723c
Author: ggregory <gg...@apache.org>
Authored: Wed Aug 26 12:08:29 2015 -0700
Committer: ggregory <gg...@apache.org>
Committed: Wed Aug 26 12:08:29 2015 -0700

----------------------------------------------------------------------
 .../java/org/apache/logging/log4j/core/config/Configuration.java   | 2 +-
 .../apache/logging/log4j/core/config/AbstractLog4j2_1100Test.java  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/edfdd888/log4j-core/src/main/java/org/apache/logging/log4j/core/config/Configuration.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/Configuration.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/Configuration.java
index d8cd780..4395069 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/Configuration.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/Configuration.java
@@ -58,7 +58,7 @@ public interface Configuration extends Filterable {
      * @param name The name of the Appender.
      * @return the Appender with the specified name or null if the Appender cannot be located.
      */
-    Appender getAppender(String name);
+    <T extends Appender> T getAppender(String name);
 
     /**
      * Returns a Map containing all the Appenders and their name.

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/edfdd888/log4j-core/src/test/java/org/apache/logging/log4j/core/config/AbstractLog4j2_1100Test.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/config/AbstractLog4j2_1100Test.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/config/AbstractLog4j2_1100Test.java
index 9a9601e..4bf5acf 100644
--- a/log4j-core/src/test/java/org/apache/logging/log4j/core/config/AbstractLog4j2_1100Test.java
+++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/config/AbstractLog4j2_1100Test.java
@@ -41,7 +41,7 @@ public abstract class AbstractLog4j2_1100Test {
     public void test() {
         final Configuration configuration = context.getConfiguration();
         assertNotNull(configuration);
-        final RollingFileAppender appender = (RollingFileAppender) configuration.getAppender("File");
+        final RollingFileAppender appender = configuration.getAppender("File");
         assertNotNull(appender);
         final CompositeTriggeringPolicy compositeTriggeringPolicy = (CompositeTriggeringPolicy) appender
                 .getTriggeringPolicy();